From: Yang Wei <albin_yang@163.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, yang.wei9@zte.com.cn, albin_yang@163.com
Subject: [PATCH net] net: apple: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles
Date: Tue, 12 Feb 2019 23:52:53 +0800 [thread overview]
Message-ID: <1549986773-4974-1-git-send-email-albin_yang@163.com> (raw)
From: Yang Wei <yang.wei9@zte.com.cn>
dev_consume_skb_irq() should be called in mace_interrupt() when skb
xmit done. It makes drop profiles(dropwatch, perf) more friendly.
Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
drivers/net/ethernet/apple/mace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/apple/mace.c b/drivers/net/ethernet/apple/mace.c
index 68b9ee4..4d9819d 100644
--- a/drivers/net/ethernet/apple/mace.c
+++ b/drivers/net/ethernet/apple/mace.c
@@ -764,7 +764,7 @@ static irqreturn_t mace_interrupt(int irq, void *dev_id)
dev->stats.tx_bytes += mp->tx_bufs[i]->len;
++dev->stats.tx_packets;
}
- dev_kfree_skb_irq(mp->tx_bufs[i]);
+ dev_consume_skb_irq(mp->tx_bufs[i]);
--mp->tx_active;
if (++i >= N_TX_RING)
i = 0;
--
2.7.4
next reply other threads:[~2019-02-12 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 15:52 Yang Wei [this message]
2019-02-14 5:01 ` [PATCH net] net: apple: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-01-28 23:39 Yang Wei
2019-01-29 7:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549986773-4974-1-git-send-email-albin_yang@163.com \
--to=albin_yang@163.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yang.wei9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.