* [PATCH v2 4/4] media: platform: sti: fix possible object reference leak
@ 2019-02-12 23:48 Wen Yang
2019-02-13 9:07 ` Benjamin Gaignard
0 siblings, 1 reply; 2+ messages in thread
From: Wen Yang @ 2019-02-12 23:48 UTC (permalink / raw)
To: benjamin.gaignard
Cc: mchehab, linux-media, linux-kernel, xue.zhihong, wang.yi59,
Wen Yang, Hans Verkuil (hansverk),
Wen Yang
The call to of_parse_phandle() returns a node pointer with refcount
incremented thus it must be explicitly decremented here after the last
usage.
The of_find_device_by_node() takes a reference to the underlying device
structure, we also should release that reference.
Hans Verkuil says:
The cec driver should never take a reference of the hdmi device.
It never accesses the HDMI device, it only needs the HDMI device pointer as
a key in the notifier list.
The real problem is that several CEC drivers take a reference of the HDMI
device and never release it. So those drivers need to be fixed.
This patch fixes those two issues.
Fixes: fc4e009c6c98 ("[media] stih-cec: add CEC notifier support")
Suggested-by: Hans Verkuil (hansverk) <hansverk@cisco.com>
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Hans Verkuil (hansverk) <hansverk@cisco.com>
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Wen Yang <yellowriver2010@hotmail.com>
Cc: linux-media@vger.kernel.org
---
v2->v1:
- move of_node_put() to just after the 'hdmi_dev = of_find_device_by_node(np)'.
- put_device() can be done before the cec = devm_kzalloc line.
drivers/media/platform/sti/cec/stih-cec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c
index d34099f..721021f 100644
--- a/drivers/media/platform/sti/cec/stih-cec.c
+++ b/drivers/media/platform/sti/cec/stih-cec.c
@@ -317,9 +317,11 @@ static int stih_cec_probe(struct platform_device *pdev)
}
hdmi_dev = of_find_device_by_node(np);
+ of_node_put(np);
if (!hdmi_dev)
return -EPROBE_DEFER;
+ put_device(&hdmi_dev->dev);
cec->notifier = cec_notifier_get(&hdmi_dev->dev);
if (!cec->notifier)
return -ENOMEM;
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 4/4] media: platform: sti: fix possible object reference leak
2019-02-12 23:48 [PATCH v2 4/4] media: platform: sti: fix possible object reference leak Wen Yang
@ 2019-02-13 9:07 ` Benjamin Gaignard
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2019-02-13 9:07 UTC (permalink / raw)
To: Wen Yang
Cc: Mauro Carvalho Chehab, linux-media, Linux Kernel Mailing List,
xue.zhihong, wang.yi59, Hans Verkuil (hansverk),
Wen Yang
Le mer. 13 févr. 2019 à 00:49, Wen Yang <wen.yang99@zte.com.cn> a écrit :
>
> The call to of_parse_phandle() returns a node pointer with refcount
> incremented thus it must be explicitly decremented here after the last
> usage.
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we also should release that reference.
>
> Hans Verkuil says:
> The cec driver should never take a reference of the hdmi device.
> It never accesses the HDMI device, it only needs the HDMI device pointer as
> a key in the notifier list.
> The real problem is that several CEC drivers take a reference of the HDMI
> device and never release it. So those drivers need to be fixed.
>
> This patch fixes those two issues.
Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
>
> Fixes: fc4e009c6c98 ("[media] stih-cec: add CEC notifier support")
> Suggested-by: Hans Verkuil (hansverk) <hansverk@cisco.com>
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Cc: Hans Verkuil (hansverk) <hansverk@cisco.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Wen Yang <yellowriver2010@hotmail.com>
> Cc: linux-media@vger.kernel.org
> ---
> v2->v1:
> - move of_node_put() to just after the 'hdmi_dev = of_find_device_by_node(np)'.
> - put_device() can be done before the cec = devm_kzalloc line.
>
> drivers/media/platform/sti/cec/stih-cec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/sti/cec/stih-cec.c b/drivers/media/platform/sti/cec/stih-cec.c
> index d34099f..721021f 100644
> --- a/drivers/media/platform/sti/cec/stih-cec.c
> +++ b/drivers/media/platform/sti/cec/stih-cec.c
> @@ -317,9 +317,11 @@ static int stih_cec_probe(struct platform_device *pdev)
> }
>
> hdmi_dev = of_find_device_by_node(np);
> + of_node_put(np);
> if (!hdmi_dev)
> return -EPROBE_DEFER;
>
> + put_device(&hdmi_dev->dev);
> cec->notifier = cec_notifier_get(&hdmi_dev->dev);
> if (!cec->notifier)
> return -ENOMEM;
> --
> 2.9.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-13 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 23:48 [PATCH v2 4/4] media: platform: sti: fix possible object reference leak Wen Yang
2019-02-13 9:07 ` Benjamin Gaignard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.