* [Buildroot] [PATCH] package/gqrx: link with libatomic when needed
@ 2019-02-22 13:12 Gwenhael Goavec-Merou
2019-03-03 22:09 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Gwenhael Goavec-Merou @ 2019-02-22 13:12 UTC (permalink / raw)
To: buildroot
From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
On some architectures, atomic binutils are provided by the libatomic
library from gcc. Linking with libatomic is therefore necessary,
otherwise the build fails with:
sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line
Fixes:
- http://autobuild.buildroot.net/results/a003ad5324a0c0f55cb8db5d3e5d69bd21999e16/
- http://autobuild.buildroot.net/results/464602175d026d135125e5baa00e0729aec7a931/
Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
---
package/gqrx/gqrx.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/gqrx/gqrx.mk b/package/gqrx/gqrx.mk
index b51bb23eaf..4dbef47222 100644
--- a/package/gqrx/gqrx.mk
+++ b/package/gqrx/gqrx.mk
@@ -12,4 +12,8 @@ GQRX_DEPENDENCIES = boost gnuradio gr-osmosdr qt5base qt5svg
GQRX_CONF_OPTS = -DLINUX_AUDIO_BACKEND=Gr-audio
+ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
+GQRX_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
+endif
+
$(eval $(cmake-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/gqrx: link with libatomic when needed
2019-02-22 13:12 [Buildroot] [PATCH] package/gqrx: link with libatomic when needed Gwenhael Goavec-Merou
@ 2019-03-03 22:09 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2019-03-03 22:09 UTC (permalink / raw)
To: buildroot
>>>>> "Gwenhael" == Gwenhael Goavec-Merou <gwenj@trabucayre.com> writes:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
> On some architectures, atomic binutils are provided by the libatomic
> library from gcc. Linking with libatomic is therefore necessary,
> otherwise the build fails with:
> sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line
> Fixes:
> - http://autobuild.buildroot.net/results/a003ad5324a0c0f55cb8db5d3e5d69bd21999e16/
> - http://autobuild.buildroot.net/results/464602175d026d135125e5baa00e0729aec7a931/
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
We also need to ensure gqrx can only be enabled on architectures where
sync or libatomic is available, so I added that and a comment explaining
why and committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-03 22:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 13:12 [Buildroot] [PATCH] package/gqrx: link with libatomic when needed Gwenhael Goavec-Merou
2019-03-03 22:09 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.