From: Michael Tokarev <1817345@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
Date: Sun, 24 Feb 2019 19:38:56 -0000 [thread overview]
Message-ID: <155103713660.11385.8973225882401821375.malone@gac.canonical.com> (raw)
In-Reply-To: 155085278488.30597.14551761138419562879.malonedeb@chaenomeles.canonical.com
I think it is better to just disallow building in a path containing
spaces, -- there are so many packages and other tools that fails in this
config, might require lots of work to fix this AND to ensure all future
changes are still working, and there's an easy workaround
Just my few cents.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
next prev parent reply other threads:[~2019-02-24 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
2019-02-24 19:38 ` Michael Tokarev [this message]
2019-02-24 19:54 ` [Qemu-devel] [Bug 1817345] " Peter Maydell
2019-02-25 7:36 ` Antonio Ospite
2019-03-09 19:16 ` Deepika Choudhary
2019-03-09 20:54 ` Peter Maydell
2019-03-10 3:46 ` Deepika Choudhary
2019-05-03 17:26 ` Peter Maydell
2019-08-02 17:46 ` Peter Maydell
2019-08-16 4:59 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155103713660.11385.8973225882401821375.malone@gac.canonical.com \
--to=1817345@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.