* [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces
@ 2019-02-22 16:26 Antonio Ospite
2019-02-24 19:38 ` [Qemu-devel] [Bug 1817345] " Michael Tokarev
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Antonio Ospite @ 2019-02-22 16:26 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure --help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
@ 2019-02-24 19:38 ` Michael Tokarev
2019-02-24 19:54 ` Peter Maydell
2019-02-25 7:36 ` Antonio Ospite
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Michael Tokarev @ 2019-02-24 19:38 UTC (permalink / raw)
To: qemu-devel
I think it is better to just disallow building in a path containing
spaces, -- there are so many packages and other tools that fails in this
config, might require lots of work to fix this AND to ensure all future
changes are still working, and there's an easy workaround
Just my few cents.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-24 19:38 ` [Qemu-devel] [Bug 1817345] " Michael Tokarev
@ 2019-02-24 19:54 ` Peter Maydell
0 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2019-02-24 19:54 UTC (permalink / raw)
To: Bug 1817345; +Cc: QEMU Developers
On Sun, 24 Feb 2019 at 19:46, Michael Tokarev
<1817345@bugs.launchpad.net> wrote:
> I think it is better to just disallow building in a path containing
> spaces, -- there are so many packages and other tools that fails in this
> config, might require lots of work to fix this AND to ensure all future
> changes are still working, and there's an easy workaround
Certainly I bet that the problems with spaces in the path do
not stop with the handling of the target-list help message.
Make does not really get on at all with spaces...
It would probably be helpful if we made configure complain
if it finds spaces in the build or source paths.
thanks
-- PMM
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
2019-02-24 19:38 ` [Qemu-devel] [Bug 1817345] " Michael Tokarev
@ 2019-02-25 7:36 ` Antonio Ospite
2019-03-09 19:16 ` Deepika Choudhary
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Antonio Ospite @ 2019-02-25 7:36 UTC (permalink / raw)
To: qemu-devel
I am OK with just checking and complaining.
Linux too solves the problem in this way:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=51193b76bfff5027cf96ba63effae808ad67cca7
A general "shellcheck" pass wouldn't hurt, tho.
Thank you,
Antonio
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
2019-02-24 19:38 ` [Qemu-devel] [Bug 1817345] " Michael Tokarev
2019-02-25 7:36 ` Antonio Ospite
@ 2019-03-09 19:16 ` Deepika Choudhary
2019-03-09 20:54 ` Peter Maydell
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Deepika Choudhary @ 2019-03-09 19:16 UTC (permalink / raw)
To: qemu-devel
If calling from any Unix shell, and the parameter has spaces, then we
need to quote it.we can also use single quotes, these are more powerful.
They stop the shell from interpreting anything ($, !, \, *, ", etc,
except ').
can't we use this approach here??
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
` (2 preceding siblings ...)
2019-03-09 19:16 ` Deepika Choudhary
@ 2019-03-09 20:54 ` Peter Maydell
2019-03-10 3:46 ` Deepika Choudhary
2019-05-03 17:26 ` Peter Maydell
` (2 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Peter Maydell @ 2019-03-09 20:54 UTC (permalink / raw)
To: qemu-devel
Deepika: the tricky part is the makefiles, not the configure script...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-03-09 20:54 ` Peter Maydell
@ 2019-03-10 3:46 ` Deepika Choudhary
0 siblings, 0 replies; 10+ messages in thread
From: Deepika Choudhary @ 2019-03-10 3:46 UTC (permalink / raw)
To: qemu-devel
Oh~
Okay!
On Sun, Mar 10, 2019, 02:30 Peter Maydell <peter.maydell@linaro.org>
wrote:
> Deepika: the tricky part is the makefiles, not the configure script...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1817345
>
> Title:
> configure script breaks when $source_path contains white spaces
>
> Status in QEMU:
> New
>
> Bug description:
> Hi,
>
> I noticed that the configure script breaks when the qemu source
> directory is in a path containing white spaces, in particular the list
> of targets is not correctly generated when calling "./configure
> --help".
>
> Steps to reproduce the problem:
>
> $ mkdir "dir with spaces"
> $ cd dir\ with\ spaces/
> $ git clone https://git.qemu.org/git/qemu.git
> $ cd qemu/
> $ ./configure --help | grep -A3 target-list
>
>
> Actual result:
>
> --target-list=LIST set target list (default: build everything)
> Available targets: dir with *-softmmu dir
> with
> *-linux-user
>
>
> Expected result:
>
> --target-list=LIST set target list (default: build everything)
> Available targets: aarch64-softmmu
> alpha-softmmu
> arm-softmmu cris-softmmu hppa-softmmu
> i386-softmmu
> lm32-softmmu m68k-softmmu microblaze-softmmu
>
>
> This happens because the $mak_wilds variable uses spaces to separate
> different paths, maybe newlines may be used, which are less likely to be in
> directory names.
>
> BTW "shellcheck" may help finding some other problems.
>
> Qemu version:
>
> $ git describe
> v3.1.0-1960-ga05838cb2a
>
> Thanks,
> Antonio
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
>
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
New
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
` (3 preceding siblings ...)
2019-03-09 20:54 ` Peter Maydell
@ 2019-05-03 17:26 ` Peter Maydell
2019-08-02 17:46 ` Peter Maydell
2019-08-16 4:59 ` Thomas Huth
6 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2019-05-03 17:26 UTC (permalink / raw)
To: qemu-devel
Antonio has submitted a patchset here:
https://patchew.org/QEMU/20190503082728.16485-1-ao2@ao2.it/
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
In Progress
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
` (4 preceding siblings ...)
2019-05-03 17:26 ` Peter Maydell
@ 2019-08-02 17:46 ` Peter Maydell
2019-08-16 4:59 ` Thomas Huth
6 siblings, 0 replies; 10+ messages in thread
From: Peter Maydell @ 2019-08-02 17:46 UTC (permalink / raw)
To: qemu-devel
Antonio's patches are in git and will be in the upcoming 4.1.0 release.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
Fix Committed
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
` (5 preceding siblings ...)
2019-08-02 17:46 ` Peter Maydell
@ 2019-08-16 4:59 ` Thomas Huth
6 siblings, 0 replies; 10+ messages in thread
From: Thomas Huth @ 2019-08-16 4:59 UTC (permalink / raw)
To: qemu-devel
Patch included here:
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=4ace32e22713ffd79deb22
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1817345
Title:
configure script breaks when $source_path contains white spaces
Status in QEMU:
Fix Released
Bug description:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure
--help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$ cd dir\ with\ spaces/
$ git clone https://git.qemu.org/git/qemu.git
$ cd qemu/
$ ./configure --help | grep -A3 target-list
Actual result:
--target-list=LIST set target list (default: build everything)
Available targets: dir with *-softmmu dir with
*-linux-user
Expected result:
--target-list=LIST set target list (default: build everything)
Available targets: aarch64-softmmu alpha-softmmu
arm-softmmu cris-softmmu hppa-softmmu i386-softmmu
lm32-softmmu m68k-softmmu microblaze-softmmu
This happens because the $mak_wilds variable uses spaces to separate different paths, maybe newlines may be used, which are less likely to be in directory names.
BTW "shellcheck" may help finding some other problems.
Qemu version:
$ git describe
v3.1.0-1960-ga05838cb2a
Thanks,
Antonio
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1817345/+subscriptions
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-08-16 5:08 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 16:26 [Qemu-devel] [Bug 1817345] [NEW] configure script breaks when $source_path contains white spaces Antonio Ospite
2019-02-24 19:38 ` [Qemu-devel] [Bug 1817345] " Michael Tokarev
2019-02-24 19:54 ` Peter Maydell
2019-02-25 7:36 ` Antonio Ospite
2019-03-09 19:16 ` Deepika Choudhary
2019-03-09 20:54 ` Peter Maydell
2019-03-10 3:46 ` Deepika Choudhary
2019-05-03 17:26 ` Peter Maydell
2019-08-02 17:46 ` Peter Maydell
2019-08-16 4:59 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.