From: Wen Yang <wen.yang99@zte.com.cn>
To: benh@kernel.crashing.org
Cc: paulus@samba.org, mpe@ellerman.id.au, tyreld@linux.vnet.ibm.com,
bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ryder.lee@mediatek.com, lorenzo.pieralisi@arm.com,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
thomas.petazzoni@bootlin.com, shawn.lin@rock-chips.com,
heiko@sntech.de, linux-rockchip@lists.infradead.org,
minghuan.Lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com,
hayashi.kunihiko@socionext.com, yamada.masahiro@socionext.com,
kishon@ti.com, linux-omap@vger.kernel.org, wang.yi59@zte.com.cn,
Wen Yang <wen.yang99@zte.com.cn>
Subject: [PATCH 3/8] PCI: dwc: layerscape: fix a leaked reference by adding missing of_node_put
Date: Wed, 27 Feb 2019 12:40:38 +0800 [thread overview]
Message-ID: <1551242443-27300-3-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551242443-27300-1-git-send-email-wen.yang99@zte.com.cn>
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./drivers/pci/controller/dwc/pci-layerscape.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 198, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Minghuan Lian <minghuan.Lian@nxp.com>
Cc: Mingkai Hu <mingkai.hu@nxp.com>
Cc: Roy Zang <roy.zang@nxp.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index ce45bde2..3a5fa26 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -201,6 +201,7 @@ static int ls_pcie_msi_host_init(struct pcie_port *pp)
return -EINVAL;
}
+ of_node_put(msi_node);
return 0;
}
--
2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Wen Yang <wen.yang99@zte.com.cn>
To: benh@kernel.crashing.org
Cc: heiko@sntech.de, hayashi.kunihiko@socionext.com,
linux-pci@vger.kernel.org, shawn.lin@rock-chips.com,
minghuan.Lian@nxp.com, paulus@samba.org,
thomas.petazzoni@bootlin.com, Wen Yang <wen.yang99@zte.com.cn>,
ryder.lee@mediatek.com, kishon@ti.com,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, wang.yi59@zte.com.cn,
rjui@broadcom.com, lorenzo.pieralisi@arm.com,
linux-mediatek@lists.infradead.org, tyreld@linux.vnet.ibm.com,
matthias.bgg@gmail.com, linux-omap@vger.kernel.org,
mingkai.hu@nxp.com, roy.zang@nxp.com, sbranden@broadcom.com,
yamada.masahiro@socionext.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com
Subject: [PATCH 3/8] PCI: dwc: layerscape: fix a leaked reference by adding missing of_node_put
Date: Wed, 27 Feb 2019 12:40:38 +0800 [thread overview]
Message-ID: <1551242443-27300-3-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551242443-27300-1-git-send-email-wen.yang99@zte.com.cn>
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./drivers/pci/controller/dwc/pci-layerscape.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 198, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Minghuan Lian <minghuan.Lian@nxp.com>
Cc: Mingkai Hu <mingkai.hu@nxp.com>
Cc: Roy Zang <roy.zang@nxp.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index ce45bde2..3a5fa26 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -201,6 +201,7 @@ static int ls_pcie_msi_host_init(struct pcie_port *pp)
return -EINVAL;
}
+ of_node_put(msi_node);
return 0;
}
--
2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Wen Yang <wen.yang99@zte.com.cn>
To: benh@kernel.crashing.org
Cc: heiko@sntech.de, hayashi.kunihiko@socionext.com,
linux-pci@vger.kernel.org, shawn.lin@rock-chips.com,
minghuan.Lian@nxp.com, paulus@samba.org,
thomas.petazzoni@bootlin.com, Wen Yang <wen.yang99@zte.com.cn>,
ryder.lee@mediatek.com, mpe@ellerman.id.au, kishon@ti.com,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org, wang.yi59@zte.com.cn,
rjui@broadcom.com, lorenzo.pieralisi@arm.com,
linux-mediatek@lists.infradead.org, tyreld@linux.vnet.ibm.com,
matthias.bgg@gmail.com, linux-omap@vger.kernel.org,
mingkai.hu@nxp.com, roy.zang@nxp.com, sbranden@broadcom.com,
yamada.masahiro@socionext.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, bhelgaas@google.com
Subject: [PATCH 3/8] PCI: dwc: layerscape: fix a leaked reference by adding missing of_node_put
Date: Wed, 27 Feb 2019 12:40:38 +0800 [thread overview]
Message-ID: <1551242443-27300-3-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1551242443-27300-1-git-send-email-wen.yang99@zte.com.cn>
The call to of_parse_phandle returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./drivers/pci/controller/dwc/pci-layerscape.c:204:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 198, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Minghuan Lian <minghuan.Lian@nxp.com>
Cc: Mingkai Hu <mingkai.hu@nxp.com>
Cc: Roy Zang <roy.zang@nxp.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-pci@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pci/controller/dwc/pci-layerscape.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pci-layerscape.c b/drivers/pci/controller/dwc/pci-layerscape.c
index ce45bde2..3a5fa26 100644
--- a/drivers/pci/controller/dwc/pci-layerscape.c
+++ b/drivers/pci/controller/dwc/pci-layerscape.c
@@ -201,6 +201,7 @@ static int ls_pcie_msi_host_init(struct pcie_port *pp)
return -EINVAL;
}
+ of_node_put(msi_node);
return 0;
}
--
2.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-27 4:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 4:40 [PATCH 1/8] PCI: dwc: pci-dra7xx: fix a leaked reference by adding missing of_node_put Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` [PATCH 2/8] PCI: uniphier: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang [this message]
2019-02-27 4:40 ` [PATCH 3/8] PCI: dwc: layerscape: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` [PATCH 4/8] PCI: rockchip: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` [PATCH 5/8] PCI: aardvark: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` [PATCH 6/8] PCI: iproc: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` [PATCH 7/8] PCI: mediatek: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-03-01 1:59 ` Honghui Zhang
2019-03-01 1:59 ` Honghui Zhang
2019-03-01 1:59 ` Honghui Zhang
2019-03-01 1:59 ` Honghui Zhang
2019-02-27 4:40 ` [PATCH 8/8] PCI: rpadlpar: " Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-02-27 4:40 ` Wen Yang
2019-04-01 10:03 ` [PATCH 1/8] PCI: dwc: pci-dra7xx: " Lorenzo Pieralisi
2019-04-01 10:03 ` Lorenzo Pieralisi
2019-04-01 10:03 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551242443-27300-3-git-send-email-wen.yang99@zte.com.cn \
--to=wen.yang99@zte.com.cn \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rjui@broadcom.com \
--cc=roy.zang@nxp.com \
--cc=ryder.lee@mediatek.com \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tyreld@linux.vnet.ibm.com \
--cc=wang.yi59@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.