All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@impinj.com>
To: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: "linux-imx@nxp.com" <linux-imx@nxp.com>,
	"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>,
	"cphealy@gmail.com" <cphealy@gmail.com>,
	"aisheng.dong@nxp.com" <aisheng.dong@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"fabio.estevam@nxp.com" <fabio.estevam@nxp.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"leonard.crestez@nxp.com" <leonard.crestez@nxp.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ
Date: Thu, 28 Feb 2019 21:23:58 +0000	[thread overview]
Message-ID: <1551389037.6059.3.camel@impinj.com> (raw)
In-Reply-To: <1549964166.2546.21.camel@pengutronix.de>

On Tue, 2019-02-12 at 10:36 +0100, Lucas Stach wrote:
> Am Montag, den 11.02.2019, 17:51 -0800 schrieb Andrey Smirnov:
> > PCIe IP block has additional clock, "pcie_aux", that needs to be
> > controlled by the driver. Add code to support that.

This breaks iMX7d.

> > 
> > @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> >  			dev_err(dev, "Failed to get PCIE APPS reset control\n");
> >  			return PTR_ERR(imx6_pcie->apps_reset);
> >  		}
> > +
> > +		imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux");
> > +		if (IS_ERR(imx6_pcie->pcie_aux)) {
> > +			dev_err(dev, "pcie_aux clock source missing or invalid\n");
> > +			return PTR_ERR(imx6_pcie->pcie_aux);
> > +		}
> >  		break;
> >  	default:
> >  		break;

One can't see enough context in the patch above, but in linux-next this
section is under

         case IMX7D:
         case IMX8MQ:

It's being applied to imx7d and not just imx8mq and so breaks because
imx7d dts files don't have this clock.  Not sure if this is a bug in
this commit or some kind of merge/rebase mistake.


WARNING: multiple messages have this Message-ID (diff)
From: Trent Piepho <tpiepho@impinj.com>
To: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
	"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>
Cc: "aisheng.dong@nxp.com" <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"hongxing.zhu@nxp.com" <hongxing.zhu@nxp.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"linux-imx@nxp.com" <linux-imx@nxp.com>,
	"fabio.estevam@nxp.com" <fabio.estevam@nxp.com>,
	"leonard.crestez@nxp.com" <leonard.crestez@nxp.com>,
	"cphealy@gmail.com" <cphealy@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ
Date: Thu, 28 Feb 2019 21:23:58 +0000	[thread overview]
Message-ID: <1551389037.6059.3.camel@impinj.com> (raw)
In-Reply-To: <1549964166.2546.21.camel@pengutronix.de>

On Tue, 2019-02-12 at 10:36 +0100, Lucas Stach wrote:
> Am Montag, den 11.02.2019, 17:51 -0800 schrieb Andrey Smirnov:
> > PCIe IP block has additional clock, "pcie_aux", that needs to be
> > controlled by the driver. Add code to support that.

This breaks iMX7d.

> > 
> > @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> >  			dev_err(dev, "Failed to get PCIE APPS reset control\n");
> >  			return PTR_ERR(imx6_pcie->apps_reset);
> >  		}
> > +
> > +		imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux");
> > +		if (IS_ERR(imx6_pcie->pcie_aux)) {
> > +			dev_err(dev, "pcie_aux clock source missing or invalid\n");
> > +			return PTR_ERR(imx6_pcie->pcie_aux);
> > +		}
> >  		break;
> >  	default:
> >  		break;

One can't see enough context in the patch above, but in linux-next this
section is under

         case IMX7D:
         case IMX8MQ:

It's being applied to imx7d and not just imx8mq and so breaks because
imx7d dts files don't have this clock.  Not sure if this is a bug in
this commit or some kind of merge/rebase mistake.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-28 21:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12  1:51 [PATCH 0/2] "pcie_aux" clock for i.MX8MQ Andrey Smirnov
2019-02-12  1:51 ` Andrey Smirnov
2019-02-12  1:51 ` [PATCH 1/2] dt-bindings: imx6q-pcie: Add "pcie_aux" clock for imx8mq Andrey Smirnov
2019-02-12  1:51   ` Andrey Smirnov
2019-02-12  8:57   ` Lucas Stach
2019-02-12  8:57     ` Lucas Stach
2019-02-25 23:39   ` Rob Herring
2019-02-25 23:39     ` Rob Herring
2019-02-25 23:39     ` Rob Herring
2019-02-12  1:51 ` [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Andrey Smirnov
2019-02-12  1:51   ` Andrey Smirnov
2019-02-12  9:36   ` Lucas Stach
2019-02-12  9:36     ` Lucas Stach
2019-02-28 21:23     ` Trent Piepho [this message]
2019-02-28 21:23       ` Trent Piepho
2019-02-28 21:23       ` Trent Piepho
2019-03-01  1:16       ` Andrey Smirnov
2019-03-01  1:16         ` Andrey Smirnov
2019-03-01  1:16         ` Andrey Smirnov
2019-02-19 12:42 ` [PATCH 0/2] " Lorenzo Pieralisi
2019-02-19 12:42   ` Lorenzo Pieralisi
2019-02-19 12:46   ` Lucas Stach
2019-02-19 12:46     ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551389037.6059.3.camel@impinj.com \
    --to=tpiepho@impinj.com \
    --cc=aisheng.dong@nxp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.