* [PATCH v2 1/2] dt-bindings: usb: add documentation for typec switch via GPIO
@ 2019-03-01 1:25 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-01 1:25 UTC (permalink / raw)
To: robh+dt, heikki.krogerus
Cc: gregkh, hdegoede, andy.shevchenko, linux-usb, devicetree, dl-linux-imx
Some typec super speed active channel switch can be controlled via
a GPIO, this binding can be used to specify the switch node by
a GPIO and the remote endpoint of its consumre.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
No change on v2 for this patch.
.../devicetree/bindings/usb/typec-switch-gpio.txt | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt
new file mode 100644
index 0000000..4ef76cf
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt
@@ -0,0 +1,30 @@
+Typec orientation switch via a GPIO
+-----------------------------------
+
+Required properties:
+- compatible: should be set one of following:
+ - "nxp,ptn36043" for NXP Type-C SuperSpeed active switch.
+
+- gpios: the GPIO used to switch the super speed active channel,
+ GPIO_ACTIVE_HIGH: GPIO state high for cc1;
+ GPIO_ACTIVE_LOW: GPIO state low for cc1.
+- orientation-switch: must be present.
+
+Required sub-node:
+- port: specify the remote endpoint of typec switch consumer.
+
+Example:
+
+ptn36043 {
+ compatible = "nxp,ptn36043";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ss_sel>;
+ gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>;
+ orientation-switch;
+
+ port {
+ usb3_data_ss: endpoint {
+ remote-endpoint = <&typec_con_ss>;
+ };
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [v2,1/2] dt-bindings: usb: add documentation for typec switch via GPIO
@ 2019-03-01 1:25 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-01 1:25 UTC (permalink / raw)
To: robh+dt, heikki.krogerus
Cc: gregkh, hdegoede, andy.shevchenko, linux-usb, devicetree, dl-linux-imx
Some typec super speed active channel switch can be controlled via
a GPIO, this binding can be used to specify the switch node by
a GPIO and the remote endpoint of its consumre.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
No change on v2 for this patch.
.../devicetree/bindings/usb/typec-switch-gpio.txt | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt
new file mode 100644
index 0000000..4ef76cf
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/typec-switch-gpio.txt
@@ -0,0 +1,30 @@
+Typec orientation switch via a GPIO
+-----------------------------------
+
+Required properties:
+- compatible: should be set one of following:
+ - "nxp,ptn36043" for NXP Type-C SuperSpeed active switch.
+
+- gpios: the GPIO used to switch the super speed active channel,
+ GPIO_ACTIVE_HIGH: GPIO state high for cc1;
+ GPIO_ACTIVE_LOW: GPIO state low for cc1.
+- orientation-switch: must be present.
+
+Required sub-node:
+- port: specify the remote endpoint of typec switch consumer.
+
+Example:
+
+ptn36043 {
+ compatible = "nxp,ptn36043";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ss_sel>;
+ gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>;
+ orientation-switch;
+
+ port {
+ usb3_data_ss: endpoint {
+ remote-endpoint = <&typec_con_ss>;
+ };
+ };
+};
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-01 1:25 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-01 1:25 UTC (permalink / raw)
To: robh+dt, heikki.krogerus
Cc: gregkh, hdegoede, andy.shevchenko, linux-usb, devicetree, dl-linux-imx
This patch adds a simple typec switch driver which only needs
a GPIO to switch the super speed active channel according to
typec orientation.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
Changes for v2:
- Use the correct head files for gpio api and of_device_id:
#include <linux/gpio/consumer.h>
#include <linux/mod_devicetable.h>
- Add driver dependency on GPIOLIB
drivers/usb/typec/mux/Kconfig | 7 +++
drivers/usb/typec/mux/Makefile | 1 +
drivers/usb/typec/mux/gpio-switch.c | 105 ++++++++++++++++++++++++++++++++++++
3 files changed, 113 insertions(+)
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
index 01ed0d5..27120e6 100644
--- a/drivers/usb/typec/mux/Kconfig
+++ b/drivers/usb/typec/mux/Kconfig
@@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
switch / mux chip found on some devices with a Type-C port.
+config TYPEC_SWITCH_GPIO
+ tristate "Simple Super Speed Active Switch via GPIO"
+ depends on GPIOLIB
+ help
+ Say Y or M if your system has a typec super speed channel
+ switch via a simple GPIO control.
+
endmenu
diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile
index 1332e46..e29377c 100644
--- a/drivers/usb/typec/mux/Makefile
+++ b/drivers/usb/typec/mux/Makefile
@@ -1,3 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
+obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
diff --git a/drivers/usb/typec/mux/gpio-switch.c b/drivers/usb/typec/mux/gpio-switch.c
new file mode 100644
index 0000000..b01844c
--- /dev/null
+++ b/drivers/usb/typec/mux/gpio-switch.c
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0
+/**
+ * gpio-switch.c - typec switch via a simple GPIO control.
+ *
+ * Copyright 2019 NXP
+ * Author: Jun Li <jun.li@nxp.com>
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
+#include <linux/usb/typec_mux.h>
+
+struct gpio_typec_switch {
+ struct typec_switch sw;
+ struct mutex lock;
+ struct gpio_desc *ss_sel;
+};
+
+static int switch_gpio_set(struct typec_switch *sw,
+ enum typec_orientation orientation)
+{
+ struct gpio_typec_switch *gpio_sw = container_of(sw,
+ struct gpio_typec_switch, sw);
+
+ mutex_lock(&gpio_sw->lock);
+
+ switch (orientation) {
+ case TYPEC_ORIENTATION_NORMAL:
+ gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
+ break;
+ case TYPEC_ORIENTATION_REVERSE:
+ gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
+ break;
+ case TYPEC_ORIENTATION_NONE:
+ break;
+ }
+
+ mutex_unlock(&gpio_sw->lock);
+
+ return 0;
+}
+
+static int typec_switch_gpio_probe(struct platform_device *pdev)
+{
+ struct gpio_typec_switch *gpio_sw;
+ struct device *dev = &pdev->dev;
+ int ret;
+
+ gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
+ if (!gpio_sw)
+ return -ENOMEM;
+
+ platform_set_drvdata(pdev, gpio_sw);
+
+ gpio_sw->sw.dev = dev;
+ gpio_sw->sw.set = switch_gpio_set;
+ mutex_init(&gpio_sw->lock);
+
+ /* Get the super speed active channel selection GPIO */
+ gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
+ if (IS_ERR(gpio_sw->ss_sel))
+ return PTR_ERR(gpio_sw->ss_sel);
+
+ ret = typec_switch_register(&gpio_sw->sw);
+ if (ret) {
+ dev_err(dev, "Error registering typec switch: %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int typec_switch_gpio_remove(struct platform_device *pdev)
+{
+ struct gpio_typec_switch *gpio_sw = platform_get_drvdata(pdev);
+
+ typec_switch_unregister(&gpio_sw->sw);
+
+ return 0;
+}
+
+static const struct of_device_id of_typec_switch_gpio_match[] = {
+ { .compatible = "nxp,ptn36043" },
+ { /* Sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
+
+static struct platform_driver typec_switch_gpio_driver = {
+ .probe = typec_switch_gpio_probe,
+ .remove = typec_switch_gpio_remove,
+ .driver = {
+ .name = "typec-switch-gpio",
+ .of_match_table = of_typec_switch_gpio_match,
+ },
+};
+
+module_platform_driver(typec_switch_gpio_driver);
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
+MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [v2,2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-01 1:25 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-01 1:25 UTC (permalink / raw)
To: robh+dt, heikki.krogerus
Cc: gregkh, hdegoede, andy.shevchenko, linux-usb, devicetree, dl-linux-imx
This patch adds a simple typec switch driver which only needs
a GPIO to switch the super speed active channel according to
typec orientation.
Signed-off-by: Li Jun <jun.li@nxp.com>
---
Changes for v2:
- Use the correct head files for gpio api and of_device_id:
#include <linux/gpio/consumer.h>
#include <linux/mod_devicetable.h>
- Add driver dependency on GPIOLIB
drivers/usb/typec/mux/Kconfig | 7 +++
drivers/usb/typec/mux/Makefile | 1 +
drivers/usb/typec/mux/gpio-switch.c | 105 ++++++++++++++++++++++++++++++++++++
3 files changed, 113 insertions(+)
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
index 01ed0d5..27120e6 100644
--- a/drivers/usb/typec/mux/Kconfig
+++ b/drivers/usb/typec/mux/Kconfig
@@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
switch / mux chip found on some devices with a Type-C port.
+config TYPEC_SWITCH_GPIO
+ tristate "Simple Super Speed Active Switch via GPIO"
+ depends on GPIOLIB
+ help
+ Say Y or M if your system has a typec super speed channel
+ switch via a simple GPIO control.
+
endmenu
diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile
index 1332e46..e29377c 100644
--- a/drivers/usb/typec/mux/Makefile
+++ b/drivers/usb/typec/mux/Makefile
@@ -1,3 +1,4 @@
# SPDX-License-Identifier: GPL-2.0
obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
+obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
diff --git a/drivers/usb/typec/mux/gpio-switch.c b/drivers/usb/typec/mux/gpio-switch.c
new file mode 100644
index 0000000..b01844c
--- /dev/null
+++ b/drivers/usb/typec/mux/gpio-switch.c
@@ -0,0 +1,105 @@
+// SPDX-License-Identifier: GPL-2.0
+/**
+ * gpio-switch.c - typec switch via a simple GPIO control.
+ *
+ * Copyright 2019 NXP
+ * Author: Jun Li <jun.li@nxp.com>
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
+#include <linux/usb/typec_mux.h>
+
+struct gpio_typec_switch {
+ struct typec_switch sw;
+ struct mutex lock;
+ struct gpio_desc *ss_sel;
+};
+
+static int switch_gpio_set(struct typec_switch *sw,
+ enum typec_orientation orientation)
+{
+ struct gpio_typec_switch *gpio_sw = container_of(sw,
+ struct gpio_typec_switch, sw);
+
+ mutex_lock(&gpio_sw->lock);
+
+ switch (orientation) {
+ case TYPEC_ORIENTATION_NORMAL:
+ gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
+ break;
+ case TYPEC_ORIENTATION_REVERSE:
+ gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
+ break;
+ case TYPEC_ORIENTATION_NONE:
+ break;
+ }
+
+ mutex_unlock(&gpio_sw->lock);
+
+ return 0;
+}
+
+static int typec_switch_gpio_probe(struct platform_device *pdev)
+{
+ struct gpio_typec_switch *gpio_sw;
+ struct device *dev = &pdev->dev;
+ int ret;
+
+ gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
+ if (!gpio_sw)
+ return -ENOMEM;
+
+ platform_set_drvdata(pdev, gpio_sw);
+
+ gpio_sw->sw.dev = dev;
+ gpio_sw->sw.set = switch_gpio_set;
+ mutex_init(&gpio_sw->lock);
+
+ /* Get the super speed active channel selection GPIO */
+ gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
+ if (IS_ERR(gpio_sw->ss_sel))
+ return PTR_ERR(gpio_sw->ss_sel);
+
+ ret = typec_switch_register(&gpio_sw->sw);
+ if (ret) {
+ dev_err(dev, "Error registering typec switch: %d\n", ret);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int typec_switch_gpio_remove(struct platform_device *pdev)
+{
+ struct gpio_typec_switch *gpio_sw = platform_get_drvdata(pdev);
+
+ typec_switch_unregister(&gpio_sw->sw);
+
+ return 0;
+}
+
+static const struct of_device_id of_typec_switch_gpio_match[] = {
+ { .compatible = "nxp,ptn36043" },
+ { /* Sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
+
+static struct platform_driver typec_switch_gpio_driver = {
+ .probe = typec_switch_gpio_probe,
+ .remove = typec_switch_gpio_remove,
+ .driver = {
+ .name = "typec-switch-gpio",
+ .of_match_table = of_typec_switch_gpio_match,
+ },
+};
+
+module_platform_driver(typec_switch_gpio_driver);
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
+MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-02 16:27 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2019-03-02 16:27 UTC (permalink / raw)
To: Jun Li
Cc: robh+dt, heikki.krogerus, gregkh, hdegoede, linux-usb,
devicetree, dl-linux-imx
On Fri, Mar 1, 2019 at 3:25 AM Jun Li <jun.li@nxp.com> wrote:
>
> This patch adds a simple typec switch driver which only needs
> a GPIO to switch the super speed active channel according to
> typec orientation.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
One minor below.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
>
> Changes for v2:
> - Use the correct head files for gpio api and of_device_id:
> #include <linux/gpio/consumer.h>
> #include <linux/mod_devicetable.h>
> - Add driver dependency on GPIOLIB
>
> drivers/usb/typec/mux/Kconfig | 7 +++
> drivers/usb/typec/mux/Makefile | 1 +
> drivers/usb/typec/mux/gpio-switch.c | 105 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 113 insertions(+)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 01ed0d5..27120e6 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
> Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
> switch / mux chip found on some devices with a Type-C port.
>
> +config TYPEC_SWITCH_GPIO
> + tristate "Simple Super Speed Active Switch via GPIO"
> + depends on GPIOLIB
> + help
> + Say Y or M if your system has a typec super speed channel
> + switch via a simple GPIO control.
> +
> endmenu
> diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile
> index 1332e46..e29377c 100644
> --- a/drivers/usb/typec/mux/Makefile
> +++ b/drivers/usb/typec/mux/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0
>
> obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
> +obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
> diff --git a/drivers/usb/typec/mux/gpio-switch.c b/drivers/usb/typec/mux/gpio-switch.c
> new file mode 100644
> index 0000000..b01844c
> --- /dev/null
> +++ b/drivers/usb/typec/mux/gpio-switch.c
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**
> + * gpio-switch.c - typec switch via a simple GPIO control.
If under any circumstances file will be renamed this become outdated.
So, better not to include file name in the file.
> + *
> + * Copyright 2019 NXP
> + * Author: Jun Li <jun.li@nxp.com>
> + *
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/usb/typec_mux.h>
> +
> +struct gpio_typec_switch {
> + struct typec_switch sw;
> + struct mutex lock;
> + struct gpio_desc *ss_sel;
> +};
> +
> +static int switch_gpio_set(struct typec_switch *sw,
> + enum typec_orientation orientation)
> +{
> + struct gpio_typec_switch *gpio_sw = container_of(sw,
> + struct gpio_typec_switch, sw);
> +
> + mutex_lock(&gpio_sw->lock);
> +
> + switch (orientation) {
> + case TYPEC_ORIENTATION_NORMAL:
> + gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
> + break;
> + case TYPEC_ORIENTATION_REVERSE:
> + gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
> + break;
> + case TYPEC_ORIENTATION_NONE:
> + break;
> + }
> +
> + mutex_unlock(&gpio_sw->lock);
> +
> + return 0;
> +}
> +
> +static int typec_switch_gpio_probe(struct platform_device *pdev)
> +{
> + struct gpio_typec_switch *gpio_sw;
> + struct device *dev = &pdev->dev;
> + int ret;
> +
> + gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
> + if (!gpio_sw)
> + return -ENOMEM;
> +
> + platform_set_drvdata(pdev, gpio_sw);
> +
> + gpio_sw->sw.dev = dev;
> + gpio_sw->sw.set = switch_gpio_set;
> + mutex_init(&gpio_sw->lock);
> +
> + /* Get the super speed active channel selection GPIO */
> + gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
> + if (IS_ERR(gpio_sw->ss_sel))
> + return PTR_ERR(gpio_sw->ss_sel);
> +
> + ret = typec_switch_register(&gpio_sw->sw);
> + if (ret) {
> + dev_err(dev, "Error registering typec switch: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int typec_switch_gpio_remove(struct platform_device *pdev)
> +{
> + struct gpio_typec_switch *gpio_sw = platform_get_drvdata(pdev);
> +
> + typec_switch_unregister(&gpio_sw->sw);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id of_typec_switch_gpio_match[] = {
> + { .compatible = "nxp,ptn36043" },
> + { /* Sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
> +
> +static struct platform_driver typec_switch_gpio_driver = {
> + .probe = typec_switch_gpio_probe,
> + .remove = typec_switch_gpio_remove,
> + .driver = {
> + .name = "typec-switch-gpio",
> + .of_match_table = of_typec_switch_gpio_match,
> + },
> +};
> +
> +module_platform_driver(typec_switch_gpio_driver);
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
> +MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
> --
> 2.7.4
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v2,2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-02 16:27 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2019-03-02 16:27 UTC (permalink / raw)
To: Jun Li
Cc: robh+dt, heikki.krogerus, gregkh, hdegoede, linux-usb,
devicetree, dl-linux-imx
On Fri, Mar 1, 2019 at 3:25 AM Jun Li <jun.li@nxp.com> wrote:
>
> This patch adds a simple typec switch driver which only needs
> a GPIO to switch the super speed active channel according to
> typec orientation.
FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
One minor below.
>
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
>
> Changes for v2:
> - Use the correct head files for gpio api and of_device_id:
> #include <linux/gpio/consumer.h>
> #include <linux/mod_devicetable.h>
> - Add driver dependency on GPIOLIB
>
> drivers/usb/typec/mux/Kconfig | 7 +++
> drivers/usb/typec/mux/Makefile | 1 +
> drivers/usb/typec/mux/gpio-switch.c | 105 ++++++++++++++++++++++++++++++++++++
> 3 files changed, 113 insertions(+)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 01ed0d5..27120e6 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
> Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
> switch / mux chip found on some devices with a Type-C port.
>
> +config TYPEC_SWITCH_GPIO
> + tristate "Simple Super Speed Active Switch via GPIO"
> + depends on GPIOLIB
> + help
> + Say Y or M if your system has a typec super speed channel
> + switch via a simple GPIO control.
> +
> endmenu
> diff --git a/drivers/usb/typec/mux/Makefile b/drivers/usb/typec/mux/Makefile
> index 1332e46..e29377c 100644
> --- a/drivers/usb/typec/mux/Makefile
> +++ b/drivers/usb/typec/mux/Makefile
> @@ -1,3 +1,4 @@
> # SPDX-License-Identifier: GPL-2.0
>
> obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
> +obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
> diff --git a/drivers/usb/typec/mux/gpio-switch.c b/drivers/usb/typec/mux/gpio-switch.c
> new file mode 100644
> index 0000000..b01844c
> --- /dev/null
> +++ b/drivers/usb/typec/mux/gpio-switch.c
> @@ -0,0 +1,105 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/**
> + * gpio-switch.c - typec switch via a simple GPIO control.
If under any circumstances file will be renamed this become outdated.
So, better not to include file name in the file.
> + *
> + * Copyright 2019 NXP
> + * Author: Jun Li <jun.li@nxp.com>
> + *
> + */
> +
> +#include <linux/module.h>
> +#include <linux/mutex.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/usb/typec_mux.h>
> +
> +struct gpio_typec_switch {
> + struct typec_switch sw;
> + struct mutex lock;
> + struct gpio_desc *ss_sel;
> +};
> +
> +static int switch_gpio_set(struct typec_switch *sw,
> + enum typec_orientation orientation)
> +{
> + struct gpio_typec_switch *gpio_sw = container_of(sw,
> + struct gpio_typec_switch, sw);
> +
> + mutex_lock(&gpio_sw->lock);
> +
> + switch (orientation) {
> + case TYPEC_ORIENTATION_NORMAL:
> + gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
> + break;
> + case TYPEC_ORIENTATION_REVERSE:
> + gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
> + break;
> + case TYPEC_ORIENTATION_NONE:
> + break;
> + }
> +
> + mutex_unlock(&gpio_sw->lock);
> +
> + return 0;
> +}
> +
> +static int typec_switch_gpio_probe(struct platform_device *pdev)
> +{
> + struct gpio_typec_switch *gpio_sw;
> + struct device *dev = &pdev->dev;
> + int ret;
> +
> + gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
> + if (!gpio_sw)
> + return -ENOMEM;
> +
> + platform_set_drvdata(pdev, gpio_sw);
> +
> + gpio_sw->sw.dev = dev;
> + gpio_sw->sw.set = switch_gpio_set;
> + mutex_init(&gpio_sw->lock);
> +
> + /* Get the super speed active channel selection GPIO */
> + gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
> + if (IS_ERR(gpio_sw->ss_sel))
> + return PTR_ERR(gpio_sw->ss_sel);
> +
> + ret = typec_switch_register(&gpio_sw->sw);
> + if (ret) {
> + dev_err(dev, "Error registering typec switch: %d\n", ret);
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int typec_switch_gpio_remove(struct platform_device *pdev)
> +{
> + struct gpio_typec_switch *gpio_sw = platform_get_drvdata(pdev);
> +
> + typec_switch_unregister(&gpio_sw->sw);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id of_typec_switch_gpio_match[] = {
> + { .compatible = "nxp,ptn36043" },
> + { /* Sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
> +
> +static struct platform_driver typec_switch_gpio_driver = {
> + .probe = typec_switch_gpio_probe,
> + .remove = typec_switch_gpio_remove,
> + .driver = {
> + .name = "typec-switch-gpio",
> + .of_match_table = of_typec_switch_gpio_match,
> + },
> +};
> +
> +module_platform_driver(typec_switch_gpio_driver);
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
> +MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-05 7:10 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-05 7:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: robh+dt, heikki.krogerus, gregkh, hdegoede, linux-usb,
devicetree, dl-linux-imx
Hi Andy,
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: 2019年3月3日 0:27
> To: Jun Li <jun.li@nxp.com>
> Cc: robh+dt@kernel.org; heikki.krogerus@linux.intel.com;
> gregkh@linuxfoundation.org; hdegoede@redhat.com; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control
>
> On Fri, Mar 1, 2019 at 3:25 AM Jun Li <jun.li@nxp.com> wrote:
> >
> > This patch adds a simple typec switch driver which only needs a GPIO
> > to switch the super speed active channel according to typec
> > orientation.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> One minor below.
>
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> >
> > Changes for v2:
> > - Use the correct head files for gpio api and of_device_id:
> > #include <linux/gpio/consumer.h>
> > #include <linux/mod_devicetable.h>
> > - Add driver dependency on GPIOLIB
> >
> > drivers/usb/typec/mux/Kconfig | 7 +++
> > drivers/usb/typec/mux/Makefile | 1 +
> > drivers/usb/typec/mux/gpio-switch.c | 105
> > ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 113 insertions(+)
> >
> > diff --git a/drivers/usb/typec/mux/Kconfig
> > b/drivers/usb/typec/mux/Kconfig index 01ed0d5..27120e6 100644
> > --- a/drivers/usb/typec/mux/Kconfig
> > +++ b/drivers/usb/typec/mux/Kconfig
> > @@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
> > Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
> > switch / mux chip found on some devices with a Type-C port.
> >
> > +config TYPEC_SWITCH_GPIO
> > + tristate "Simple Super Speed Active Switch via GPIO"
> > + depends on GPIOLIB
> > + help
> > + Say Y or M if your system has a typec super speed channel
> > + switch via a simple GPIO control.
> > +
> > endmenu
> > diff --git a/drivers/usb/typec/mux/Makefile
> > b/drivers/usb/typec/mux/Makefile index 1332e46..e29377c 100644
> > --- a/drivers/usb/typec/mux/Makefile
> > +++ b/drivers/usb/typec/mux/Makefile
> > @@ -1,3 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0
> >
> > obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
> > +obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
> > diff --git a/drivers/usb/typec/mux/gpio-switch.c
> > b/drivers/usb/typec/mux/gpio-switch.c
> > new file mode 100644
> > index 0000000..b01844c
> > --- /dev/null
> > +++ b/drivers/usb/typec/mux/gpio-switch.c
> > @@ -0,0 +1,105 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/**
>
> > + * gpio-switch.c - typec switch via a simple GPIO control.
>
> If under any circumstances file will be renamed this become outdated.
> So, better not to include file name in the file.
OK, I will remove this.
Thanks
Li Jun
>
> > + *
> > + * Copyright 2019 NXP
> > + * Author: Jun Li <jun.li@nxp.com>
> > + *
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/kernel.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/usb/typec_mux.h>
> > +
> > +struct gpio_typec_switch {
> > + struct typec_switch sw;
> > + struct mutex lock;
> > + struct gpio_desc *ss_sel;
> > +};
> > +
> > +static int switch_gpio_set(struct typec_switch *sw,
> > + enum typec_orientation orientation) {
> > + struct gpio_typec_switch *gpio_sw = container_of(sw,
> > + struct gpio_typec_switch, sw);
> > +
> > + mutex_lock(&gpio_sw->lock);
> > +
> > + switch (orientation) {
> > + case TYPEC_ORIENTATION_NORMAL:
> > + gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
> > + break;
> > + case TYPEC_ORIENTATION_REVERSE:
> > + gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
> > + break;
> > + case TYPEC_ORIENTATION_NONE:
> > + break;
> > + }
> > +
> > + mutex_unlock(&gpio_sw->lock);
> > +
> > + return 0;
> > +}
> > +
> > +static int typec_switch_gpio_probe(struct platform_device *pdev) {
> > + struct gpio_typec_switch *gpio_sw;
> > + struct device *dev = &pdev->dev;
> > + int ret;
> > +
> > + gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
> > + if (!gpio_sw)
> > + return -ENOMEM;
> > +
> > + platform_set_drvdata(pdev, gpio_sw);
> > +
> > + gpio_sw->sw.dev = dev;
> > + gpio_sw->sw.set = switch_gpio_set;
> > + mutex_init(&gpio_sw->lock);
> > +
> > + /* Get the super speed active channel selection GPIO */
> > + gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
> > + if (IS_ERR(gpio_sw->ss_sel))
> > + return PTR_ERR(gpio_sw->ss_sel);
> > +
> > + ret = typec_switch_register(&gpio_sw->sw);
> > + if (ret) {
> > + dev_err(dev, "Error registering typec switch: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int typec_switch_gpio_remove(struct platform_device *pdev) {
> > + struct gpio_typec_switch *gpio_sw =
> > +platform_get_drvdata(pdev);
> > +
> > + typec_switch_unregister(&gpio_sw->sw);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct of_device_id of_typec_switch_gpio_match[] = {
> > + { .compatible = "nxp,ptn36043" },
> > + { /* Sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
> > +
> > +static struct platform_driver typec_switch_gpio_driver = {
> > + .probe = typec_switch_gpio_probe,
> > + .remove = typec_switch_gpio_remove,
> > + .driver = {
> > + .name = "typec-switch-gpio",
> > + .of_match_table = of_typec_switch_gpio_match,
> > + },
> > +};
> > +
> > +module_platform_driver(typec_switch_gpio_driver);
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
> > +MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
> > --
> > 2.7.4
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* [v2,2/2] usb: typec: add typec switch via GPIO control
@ 2019-03-05 7:10 ` Jun Li
0 siblings, 0 replies; 8+ messages in thread
From: Jun Li @ 2019-03-05 7:10 UTC (permalink / raw)
To: Andy Shevchenko
Cc: robh+dt, heikki.krogerus, gregkh, hdegoede, linux-usb,
devicetree, dl-linux-imx
Hi Andy,
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: 2019年3月3日 0:27
> To: Jun Li <jun.li@nxp.com>
> Cc: robh+dt@kernel.org; heikki.krogerus@linux.intel.com;
> gregkh@linuxfoundation.org; hdegoede@redhat.com; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH v2 2/2] usb: typec: add typec switch via GPIO control
>
> On Fri, Mar 1, 2019 at 3:25 AM Jun Li <jun.li@nxp.com> wrote:
> >
> > This patch adds a simple typec switch driver which only needs a GPIO
> > to switch the super speed active channel according to typec
> > orientation.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> One minor below.
>
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> >
> > Changes for v2:
> > - Use the correct head files for gpio api and of_device_id:
> > #include <linux/gpio/consumer.h>
> > #include <linux/mod_devicetable.h>
> > - Add driver dependency on GPIOLIB
> >
> > drivers/usb/typec/mux/Kconfig | 7 +++
> > drivers/usb/typec/mux/Makefile | 1 +
> > drivers/usb/typec/mux/gpio-switch.c | 105
> > ++++++++++++++++++++++++++++++++++++
> > 3 files changed, 113 insertions(+)
> >
> > diff --git a/drivers/usb/typec/mux/Kconfig
> > b/drivers/usb/typec/mux/Kconfig index 01ed0d5..27120e6 100644
> > --- a/drivers/usb/typec/mux/Kconfig
> > +++ b/drivers/usb/typec/mux/Kconfig
> > @@ -9,4 +9,11 @@ config TYPEC_MUX_PI3USB30532
> > Say Y or M if your system has a Pericom PI3USB30532 Type-C cross
> > switch / mux chip found on some devices with a Type-C port.
> >
> > +config TYPEC_SWITCH_GPIO
> > + tristate "Simple Super Speed Active Switch via GPIO"
> > + depends on GPIOLIB
> > + help
> > + Say Y or M if your system has a typec super speed channel
> > + switch via a simple GPIO control.
> > +
> > endmenu
> > diff --git a/drivers/usb/typec/mux/Makefile
> > b/drivers/usb/typec/mux/Makefile index 1332e46..e29377c 100644
> > --- a/drivers/usb/typec/mux/Makefile
> > +++ b/drivers/usb/typec/mux/Makefile
> > @@ -1,3 +1,4 @@
> > # SPDX-License-Identifier: GPL-2.0
> >
> > obj-$(CONFIG_TYPEC_MUX_PI3USB30532) += pi3usb30532.o
> > +obj-$(CONFIG_TYPEC_SWITCH_GPIO) += gpio-switch.o
> > diff --git a/drivers/usb/typec/mux/gpio-switch.c
> > b/drivers/usb/typec/mux/gpio-switch.c
> > new file mode 100644
> > index 0000000..b01844c
> > --- /dev/null
> > +++ b/drivers/usb/typec/mux/gpio-switch.c
> > @@ -0,0 +1,105 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/**
>
> > + * gpio-switch.c - typec switch via a simple GPIO control.
>
> If under any circumstances file will be renamed this become outdated.
> So, better not to include file name in the file.
OK, I will remove this.
Thanks
Li Jun
>
> > + *
> > + * Copyright 2019 NXP
> > + * Author: Jun Li <jun.li@nxp.com>
> > + *
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/mutex.h>
> > +#include <linux/kernel.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/gpio/consumer.h>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/usb/typec_mux.h>
> > +
> > +struct gpio_typec_switch {
> > + struct typec_switch sw;
> > + struct mutex lock;
> > + struct gpio_desc *ss_sel;
> > +};
> > +
> > +static int switch_gpio_set(struct typec_switch *sw,
> > + enum typec_orientation orientation) {
> > + struct gpio_typec_switch *gpio_sw = container_of(sw,
> > + struct gpio_typec_switch, sw);
> > +
> > + mutex_lock(&gpio_sw->lock);
> > +
> > + switch (orientation) {
> > + case TYPEC_ORIENTATION_NORMAL:
> > + gpiod_set_value_cansleep(gpio_sw->ss_sel, 1);
> > + break;
> > + case TYPEC_ORIENTATION_REVERSE:
> > + gpiod_set_value_cansleep(gpio_sw->ss_sel, 0);
> > + break;
> > + case TYPEC_ORIENTATION_NONE:
> > + break;
> > + }
> > +
> > + mutex_unlock(&gpio_sw->lock);
> > +
> > + return 0;
> > +}
> > +
> > +static int typec_switch_gpio_probe(struct platform_device *pdev) {
> > + struct gpio_typec_switch *gpio_sw;
> > + struct device *dev = &pdev->dev;
> > + int ret;
> > +
> > + gpio_sw = devm_kzalloc(dev, sizeof(*gpio_sw), GFP_KERNEL);
> > + if (!gpio_sw)
> > + return -ENOMEM;
> > +
> > + platform_set_drvdata(pdev, gpio_sw);
> > +
> > + gpio_sw->sw.dev = dev;
> > + gpio_sw->sw.set = switch_gpio_set;
> > + mutex_init(&gpio_sw->lock);
> > +
> > + /* Get the super speed active channel selection GPIO */
> > + gpio_sw->ss_sel = devm_gpiod_get(dev, NULL, GPIOD_OUT_LOW);
> > + if (IS_ERR(gpio_sw->ss_sel))
> > + return PTR_ERR(gpio_sw->ss_sel);
> > +
> > + ret = typec_switch_register(&gpio_sw->sw);
> > + if (ret) {
> > + dev_err(dev, "Error registering typec switch: %d\n", ret);
> > + return ret;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int typec_switch_gpio_remove(struct platform_device *pdev) {
> > + struct gpio_typec_switch *gpio_sw =
> > +platform_get_drvdata(pdev);
> > +
> > + typec_switch_unregister(&gpio_sw->sw);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct of_device_id of_typec_switch_gpio_match[] = {
> > + { .compatible = "nxp,ptn36043" },
> > + { /* Sentinel */ }
> > +};
> > +MODULE_DEVICE_TABLE(of, of_typec_switch_gpio_match);
> > +
> > +static struct platform_driver typec_switch_gpio_driver = {
> > + .probe = typec_switch_gpio_probe,
> > + .remove = typec_switch_gpio_remove,
> > + .driver = {
> > + .name = "typec-switch-gpio",
> > + .of_match_table = of_typec_switch_gpio_match,
> > + },
> > +};
> > +
> > +module_platform_driver(typec_switch_gpio_driver);
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("TypeC Super Speed Switch GPIO driver");
> > +MODULE_AUTHOR("Jun Li <jun.li@nxp.com>");
> > --
> > 2.7.4
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-03-05 7:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 1:25 [PATCH v2 1/2] dt-bindings: usb: add documentation for typec switch via GPIO Jun Li
2019-03-01 1:25 ` [v2,1/2] " Jun Li
2019-03-01 1:25 ` [PATCH v2 2/2] usb: typec: add typec switch via GPIO control Jun Li
2019-03-01 1:25 ` [v2,2/2] " Jun Li
2019-03-02 16:27 ` [PATCH v2 2/2] " Andy Shevchenko
2019-03-02 16:27 ` [v2,2/2] " Andy Shevchenko
2019-03-05 7:10 ` [PATCH v2 2/2] " Jun Li
2019-03-05 7:10 ` [v2,2/2] " Jun Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.