* [PATCH v3] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-04 17:34 Debleena Sen
2019-03-04 19:01 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Debleena Sen @ 2019-03-04 17:34 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
Delete extra whitespace and tab space and use one tab space to
remove the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message
---
drivers/staging/pi433/pi433_if.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b231463..53928af 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
#include "pi433_if.h"
#include "rf69.h"
-#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Staging: pi433: Fix line over 80 characters issue
2019-03-04 17:34 [PATCH v3] Staging: pi433: Fix line over 80 characters issue Debleena Sen
@ 2019-03-04 19:01 ` Greg KH
2019-03-04 19:30 ` Debleena Sen
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2019-03-04 19:01 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Mon, Mar 04, 2019 at 09:34:10AM -0800, Debleena Sen wrote:
> Delete extra whitespace and tab space and use one tab space to
> remove the checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
>
> Changes in v3:
> - Add version change log
> Changes in v2:
> - Add "and use one tab space" to the log message
> ---
> drivers/staging/pi433/pi433_if.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
The "changes in" lines go below the --- line, not above it :(
(note, one kernel subsystem does want it above the line, the graphics
developers. But they are crazy anyway and like doing things
differently, so don't worry about them just yet...)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Staging: pi433: Fix line over 80 characters issue
2019-03-04 19:01 ` Greg KH
@ 2019-03-04 19:30 ` Debleena Sen
2019-03-05 7:03 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Debleena Sen @ 2019-03-04 19:30 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Tue, Mar 5, 2019 at 12:31 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Mar 04, 2019 at 09:34:10AM -0800, Debleena Sen wrote:
> > Delete extra whitespace and tab space and use one tab space to
> > remove the checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> >
> > Changes in v3:
> > - Add version change log
> > Changes in v2:
> > - Add "and use one tab space" to the log message
> > ---
> > drivers/staging/pi433/pi433_if.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> The "changes in" lines go below the --- line, not above it :(
>
> (note, one kernel subsystem does want it above the line, the graphics
> developers. But they are crazy anyway and like doing things
> differently, so don't worry about them just yet...)
>
> thanks,
>
> greg k-h
>
How do I put them below "---"?
I tried to but couldn't understand how :'((
[-- Attachment #2: Type: text/html, Size: 1571 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] Staging: pi433: Fix line over 80 characters issue
2019-03-04 19:30 ` Debleena Sen
@ 2019-03-05 7:03 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-03-05 7:03 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Tue, Mar 05, 2019 at 01:00:37AM +0530, Debleena Sen wrote:
> On Tue, Mar 5, 2019 at 12:31 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Mon, Mar 04, 2019 at 09:34:10AM -0800, Debleena Sen wrote:
> > > Delete extra whitespace and tab space and use one tab space to
> > > remove the checkpatch.pl warning:
> > > WARNING: line over 80 characters
> > >
> > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > >
> > > Changes in v3:
> > > - Add version change log
> > > Changes in v2:
> > > - Add "and use one tab space" to the log message
> > > ---
> > > drivers/staging/pi433/pi433_if.c | 8 ++++----
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > The "changes in" lines go below the --- line, not above it :(
> >
> > (note, one kernel subsystem does want it above the line, the graphics
> > developers. But they are crazy anyway and like doing things
> > differently, so don't worry about them just yet...)
> >
> > thanks,
> >
> > greg k-h
> >
>
> How do I put them below "---"?
> I tried to but couldn't understand how :'((
You have to edit the patch itself, after you run 'git format-patch'.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-03 7:46 Debleena Sen
0 siblings, 0 replies; 5+ messages in thread
From: Debleena Sen @ 2019-03-03 7:46 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
This patch re-formats the code to remove the checkpatch.pl warning(on
line no. 566):
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
drivers/staging/pi433/rf69.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e19b9ce..0c189a7 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
{
switch (flag) {
case mode_switch_completed:
- return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
+ return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+ MASK_IRQFLAGS1_MODE_READY);
case ready_to_receive:
return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
case ready_to_send:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-05 7:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 17:34 [PATCH v3] Staging: pi433: Fix line over 80 characters issue Debleena Sen
2019-03-04 19:01 ` Greg KH
2019-03-04 19:30 ` Debleena Sen
2019-03-05 7:03 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-03-03 7:46 Debleena Sen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.