Re: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   88687719c8..b6179aaff9  master     -> master
 t [tag update]            patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
1255bffda9 s390-bios: dasd-ipl: Use control unit type to customize error data
c5cbb3e0e3 s390-bios: Support booting from real dasd device
94998e8aef s390-bios: Add channel command codes/structs needed for dasd-ipl
8cab135f1f s390-bios: Use control unit type to determine boot method
0839e39d7e s390-bios: Refactor virtio to run channel programs via cio
47ecb89929 s390-bios: cio error handling
6ed51be6e9 s390-bios: Support for running format-0/1 channel programs
e91f12a0e8 s390-bios: ptr2u32 and u32toptr
ddb9098d6a s390-bios: Map low core memory
fcbe10b9a4 s390-bios: Decouple channel i/o logic from virtio
7054d8f76c s390-bios: Clean up cio.h
8dd54ea4db s390-bios: Factor finding boot device out of virtio code path
b2c9cd304a s390-bios: Extend find_dev() for non-virtio devices
bc538e2273 s390-bios: decouple common boot logic from virtio
5921529560 s390-bios: decouple cio setup from virtio
771e74f350 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/16 Checking commit 771e74f3508a (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#205: 
new file mode 100644

total: 0 errors, 1 warnings, 181 lines checked

Patch 1/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/16 Checking commit 592152956073 (s390-bios: decouple cio setup from virtio)
3/16 Checking commit bc538e2273cc (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/16 Checking commit b2c9cd304a79 (s390-bios: Extend find_dev() for non-virtio devices)
5/16 Checking commit 8dd54ea4dbb8 (s390-bios: Factor finding boot device out of virtio code path)
6/16 Checking commit 7054d8f76cdc (s390-bios: Clean up cio.h)
7/16 Checking commit fcbe10b9a4ce (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 122 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/16 Checking commit ddb9098d6af2 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 116 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit e91f12a0e82d (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 9/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/16 Checking commit 6ed51be6e9de (s390-bios: Support for running format-0/1 channel programs)
11/16 Checking commit 47ecb89929ac (s390-bios: cio error handling)
12/16 Checking commit 0839e39d7ed3 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#103: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#116: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 107 lines checked

Patch 12/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/16 Checking commit 8cab135f1f9a (s390-bios: Use control unit type to determine boot method)
14/16 Checking commit 94998e8aef86 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/16 Checking commit c5cbb3e0e34d (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 446 lines checked

Patch 15/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/16 Checking commit 1255bffda9a8 (s390-bios: dasd-ipl: Use control unit type to customize error data)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com