Re: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
b7aaa9c703 s390-bios: dasd-ipl: Use control unit type to customize error data
52085b8f83 s390-bios: Support booting from real dasd device
69408610f4 s390-bios: Add channel command codes/structs needed for dasd-ipl
cc0aaac6c7 s390-bios: Use control unit type to determine boot method
434eec95bf s390-bios: Refactor virtio to run channel programs via cio
66dd80c18c s390-bios: cio error handling
657592efa5 s390-bios: Support for running format-0/1 channel programs
1375c50da1 s390-bios: ptr2u32 and u32toptr
637b957361 s390-bios: Map low core memory
66e4245468 s390-bios: Decouple channel i/o logic from virtio
31d8ec0aff s390-bios: Clean up cio.h
88c8d0052e s390-bios: Factor finding boot device out of virtio code path
fe2b50f585 s390-bios: Extend find_dev() for non-virtio devices
ad96715604 s390-bios: decouple common boot logic from virtio
2541ee0520 s390-bios: decouple cio setup from virtio
e08dc9e136 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/16 Checking commit e08dc9e1365f (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#205: 
new file mode 100644

total: 0 errors, 1 warnings, 181 lines checked

Patch 1/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/16 Checking commit 2541ee05208e (s390-bios: decouple cio setup from virtio)
3/16 Checking commit ad967156046b (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/16 Checking commit fe2b50f585af (s390-bios: Extend find_dev() for non-virtio devices)
5/16 Checking commit 88c8d0052e0c (s390-bios: Factor finding boot device out of virtio code path)
6/16 Checking commit 31d8ec0aff5d (s390-bios: Clean up cio.h)
7/16 Checking commit 66e424546827 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 122 lines checked

Patch 7/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/16 Checking commit 637b95736185 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 116 lines checked

Patch 8/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/16 Checking commit 1375c50da1bd (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 9/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/16 Checking commit 657592efa58a (s390-bios: Support for running format-0/1 channel programs)
11/16 Checking commit 66dd80c18cec (s390-bios: cio error handling)
12/16 Checking commit 434eec95bf37 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#103: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#116: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 107 lines checked

Patch 12/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/16 Checking commit cc0aaac6c7f4 (s390-bios: Use control unit type to determine boot method)
14/16 Checking commit 69408610f403 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/16 Checking commit 52085b8f83c6 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25: 
new file mode 100644

total: 0 errors, 1 warnings, 446 lines checked

Patch 15/16 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/16 Checking commit b7aaa9c703e1 (s390-bios: dasd-ipl: Use control unit type to customize error data)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com