All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Harvey Hunt <harveyhuntnexus@gmail.com>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B
Date: Mon, 04 Mar 2019 19:22:22 +0100	[thread overview]
Message-ID: <1551723742.4932.2@crapouillou.net> (raw)
In-Reply-To: <20190304104554.09be4cd4@xps13>

Hi Miquel,

On Mon, Mar 4, 2019 at 10:45 AM, Miquel Raynal 
<miquel.raynal@bootlin.com> wrote:
> Hi Paul,
> 
> Paul Cercueil <paul@crapouillou.net <mailto:paul@crapouillou.net>> 
> wrote on Sat,  9 Feb 2019 16:22:57
> -0300:
> 
>>  Add compatible strings to probe the jz4780-nand and jz4780-bch 
>> drivers
>>  from devicetree on the JZ4725B and JZ4740 SoCs from Ingenic.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net 
>> <mailto:paul@crapouillou.net>>
>>  ---
>> 
>>  Changes:
>> 
>>  v2: - Change 'ingenic,jz4725b-nand' compatible string to
>>        'ingenic,jz4740-nand' to reflect driver change
>>      - Add 'ingenic,jz4740-bch' compatible string
>>      - Document 'ingenic,oob-layout' property
>> 
>>  v3: - Removed 'ingenic,oob-layout' property
>>      - Update compatible strings to what the driver supports
>> 
>>  v4: No change
>> 
>>   Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 10 
>> ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt 
>> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  index 29ea5853ca91..a5b940f18bf6 100644
>>  --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and 
>> thus NAND device nodes must
>>   be children of the NEMC node.
>> 
>>   Required NAND controller device properties:
>>  -- compatible: Should be set to "ingenic,jz4780-nand".
>>  +- compatible: Should be one of:
>>  +  * ingenic,jz4740-nand
>>  +  * ingenic,jz4725b-nand
>>  +  * ingenic,jz4780-nand
> 
> Wouldn't "-nand-controller" suffix be better? Of course in the driver
> you should still check for jz4780-nand.

So I would be compatible with:
* ingenic,jz4740-nand-controller
* ingenic,jz4725b-nand-controller
* ingenic,jz4780-nand
?

>>   - reg: For each bank with a NAND chip attached, should specify a 
>> bank number,
>>     an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC 
>> bank).
>> 
>>  @@ -72,7 +75,10 @@ NAND devices. The following is a description of 
>> the device properties for a
>>   BCH controller.
>> 
>>   Required BCH properties:
>>  -- compatible: Should be set to "ingenic,jz4780-bch".
>>  +- compatible: Should be one of:
>>  +  * ingenic,jz4740-ecc
>>  +  * ingenic,jz4725b-bch
>>  +  * ingenic,jz4780-bch
>>   - reg: Should specify the BCH controller registers location and 
>> length.
>>   - clocks: Clock for the BCH controller.
>> 
> 
> Thanks,
> Miquèl



WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	Harvey Hunt <harveyhuntnexus@gmail.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B
Date: Mon, 04 Mar 2019 19:22:22 +0100	[thread overview]
Message-ID: <1551723742.4932.2@crapouillou.net> (raw)
In-Reply-To: <20190304104554.09be4cd4@xps13>

Hi Miquel,

On Mon, Mar 4, 2019 at 10:45 AM, Miquel Raynal 
<miquel.raynal@bootlin.com> wrote:
> Hi Paul,
> 
> Paul Cercueil <paul@crapouillou.net <mailto:paul@crapouillou.net>> 
> wrote on Sat,  9 Feb 2019 16:22:57
> -0300:
> 
>>  Add compatible strings to probe the jz4780-nand and jz4780-bch 
>> drivers
>>  from devicetree on the JZ4725B and JZ4740 SoCs from Ingenic.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net 
>> <mailto:paul@crapouillou.net>>
>>  ---
>> 
>>  Changes:
>> 
>>  v2: - Change 'ingenic,jz4725b-nand' compatible string to
>>        'ingenic,jz4740-nand' to reflect driver change
>>      - Add 'ingenic,jz4740-bch' compatible string
>>      - Document 'ingenic,oob-layout' property
>> 
>>  v3: - Removed 'ingenic,oob-layout' property
>>      - Update compatible strings to what the driver supports
>> 
>>  v4: No change
>> 
>>   Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 10 
>> ++++++++--
>>   1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt 
>> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  index 29ea5853ca91..a5b940f18bf6 100644
>>  --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>>  @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), and 
>> thus NAND device nodes must
>>   be children of the NEMC node.
>> 
>>   Required NAND controller device properties:
>>  -- compatible: Should be set to "ingenic,jz4780-nand".
>>  +- compatible: Should be one of:
>>  +  * ingenic,jz4740-nand
>>  +  * ingenic,jz4725b-nand
>>  +  * ingenic,jz4780-nand
> 
> Wouldn't "-nand-controller" suffix be better? Of course in the driver
> you should still check for jz4780-nand.

So I would be compatible with:
* ingenic,jz4740-nand-controller
* ingenic,jz4725b-nand-controller
* ingenic,jz4780-nand
?

>>   - reg: For each bank with a NAND chip attached, should specify a 
>> bank number,
>>     an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC 
>> bank).
>> 
>>  @@ -72,7 +75,10 @@ NAND devices. The following is a description of 
>> the device properties for a
>>   BCH controller.
>> 
>>   Required BCH properties:
>>  -- compatible: Should be set to "ingenic,jz4780-bch".
>>  +- compatible: Should be one of:
>>  +  * ingenic,jz4740-ecc
>>  +  * ingenic,jz4725b-bch
>>  +  * ingenic,jz4780-bch
>>   - reg: Should specify the BCH controller registers location and 
>> length.
>>   - clocks: Clock for the BCH controller.
>> 
> 
> Thanks,
> Miquèl



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-03-04 18:22 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 19:22 [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Paul Cercueil
2019-02-09 19:22 ` Paul Cercueil
2019-02-09 19:22 ` [PATCH v4 2/9] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation Paul Cercueil
2019-02-09 19:22   ` Paul Cercueil
2019-02-13 21:46   ` Rob Herring
2019-02-13 21:46     ` Rob Herring
2019-02-13 21:46     ` Rob Herring
2019-03-04  9:50   ` Miquel Raynal
2019-03-04  9:50     ` Miquel Raynal
2019-03-04 18:23     ` Paul Cercueil
2019-03-04 18:23       ` Paul Cercueil
2019-03-04 18:58       ` Miquel Raynal
2019-03-04 18:58         ` Miquel Raynal
2019-03-13 12:59         ` Paul Cercueil
2019-03-13 12:59           ` Paul Cercueil
2019-03-13 13:12           ` Miquel Raynal
2019-03-13 13:12             ` Miquel Raynal
2019-02-09 19:22 ` [PATCH v4 3/9] mtd: rawnand: Move drivers for Ingenic SoCs to subfolder Paul Cercueil
2019-02-09 19:22   ` Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 4/9] mtd: rawnand: ingenic: Use SPDX license notifiers Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 5/9] mtd: rawnand: ingenic: Rename jz4780_nand driver to ingenic_nand Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 6/9] mtd: rawnand: ingenic: Separate top-level and SoC specific code Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-03-04 10:20   ` Miquel Raynal
2019-03-04 10:20     ` Miquel Raynal
2019-03-04 18:26     ` Paul Cercueil
2019-03-04 18:26       ` Paul Cercueil
2019-03-04 19:04       ` Miquel Raynal
2019-03-04 19:04         ` Miquel Raynal
2019-02-09 19:23 ` [PATCH v4 7/9] mtd: rawnand: ingenic: Add support for the JZ4740 Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-03-04 10:34   ` Miquel Raynal
2019-03-04 10:34     ` Miquel Raynal
2019-03-04 18:28     ` Paul Cercueil
2019-03-04 18:28       ` Paul Cercueil
2019-03-04 19:07       ` Miquel Raynal
2019-03-04 19:07         ` Miquel Raynal
2019-02-09 19:23 ` [PATCH v4 8/9] mtd: rawnand: ingenic: Add support for the JZ4725B Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-03-04 10:35   ` Miquel Raynal
2019-03-04 10:35     ` Miquel Raynal
2019-03-04 18:30     ` Paul Cercueil
2019-03-04 18:30       ` Paul Cercueil
2019-03-04 19:09       ` Miquel Raynal
2019-03-04 19:09         ` Miquel Raynal
2019-03-13 12:46         ` Paul Cercueil
2019-03-13 12:46           ` Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 9/9] mtd: rawnand: ingenic: Add ooblayout for the Qi Ben Nanonote Paul Cercueil
2019-02-09 19:23   ` Paul Cercueil
2019-02-13 21:45 ` [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Rob Herring
2019-02-13 21:45   ` Rob Herring
2019-02-13 21:45   ` Rob Herring
2019-03-04  9:45 ` Miquel Raynal
2019-03-04  9:45   ` Miquel Raynal
2019-03-04 18:22   ` Paul Cercueil [this message]
2019-03-04 18:22     ` Paul Cercueil
2019-03-04 18:51     ` Miquel Raynal
2019-03-04 18:51       ` Miquel Raynal
2019-03-04 18:51       ` Miquel Raynal
2019-03-13 12:55       ` Paul Cercueil
2019-03-13 12:55         ` Paul Cercueil
2019-03-13 13:09         ` Boris Brezillon
2019-03-13 13:09           ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551723742.4932.2@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=bbrezillon@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=harveyhuntnexus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.