* [PATCH v4] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-05 15:06 Debleena Sen
0 siblings, 0 replies; 6+ messages in thread
From: Debleena Sen @ 2019-03-05 15:06 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
Delete extra whitespace and tab space and use one tab space to
remove the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
Changes in v4:
- Add version change log in the right place
Changes in v3:
- Add version change log
Changes in v2:
- Add "and use one tab space" to the log message
drivers/staging/pi433/pi433_if.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index b231463..53928af 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -45,10 +45,10 @@
#include "pi433_if.h"
#include "rf69.h"
-#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
-#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
-#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
-#define NUM_DIO 2
+#define N_PI433_MINORS BIT(MINORBITS) /*32*/ /* ... up to 256 */
+#define MAX_MSG_SIZE 900 /* min: FIFO_SIZE! */
+#define MSG_FIFO_SIZE 65536 /* 65536 = 2^16 */
+#define NUM_DIO 2
static dev_t pi433_dev;
static DEFINE_IDR(pi433_idr);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 16:24 ` Debleena Sen
@ 2019-03-06 9:15 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-03-06 9:15 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Tue, Mar 05, 2019 at 09:54:44PM +0530, Debleena Sen wrote:
> On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > > Break the line and match the indentation to remove the
> > > checkpatch.pl warning:
> > > WARNING: line over 80 characters
> > >
> > > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > > ---
> > > drivers/staging/pi433/rf69.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > What changed from the previous versions? That information always goes
> > below the --- line please.
> >
> > Please fix up and resend.
> >
> > thanks,
> >
> > greg k-h
> >
>
> I'm not able to find the commit.
>
> I tried using "git reset --mixed e19b9ce" but it shows an error:
>
> error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
> commit
> fatal: could not parse object 'e19b9ce'
>
> How can I recover it so that I can add the changes?
I have no idea what you are trying to do here, sorry. Why are you
running 'git reset'?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
@ 2019-03-05 16:24 ` Debleena Sen
2019-03-06 9:15 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Debleena Sen @ 2019-03-05 16:24 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Mar 5, 2019 at 1:10 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions? That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>
I'm not able to find the commit.
I tried using "git reset --mixed e19b9ce" but it shows an error:
error: object e19b9ce794a8534f0ad19bfa1c60260fd74b9bb9 is a blob, not a
commit
fatal: could not parse object 'e19b9ce'
How can I recover it so that I can add the changes?
Thank you,
Debleena
[-- Attachment #2: Type: text/html, Size: 1593 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-05 7:40 ` Greg KH
@ 2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
1 sibling, 0 replies; 6+ messages in thread
From: Debleena Sen @ 2019-03-05 14:00 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Tue, 5 Mar 2019, 13:10 Greg KH, <gregkh@linuxfoundation.org> wrote:
> On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> > Break the line and match the indentation to remove the
> > checkpatch.pl warning:
> > WARNING: line over 80 characters
> >
> > Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> What changed from the previous versions? That information always goes
> below the --- line please.
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>
Will do.
Thnaks,
Debleena
[-- Attachment #2: Type: text/html, Size: 1220 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4] Staging: pi433: Fix line over 80 characters issue
2019-03-03 10:01 Debleena Sen
@ 2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2019-03-05 7:40 UTC (permalink / raw)
To: Debleena Sen; +Cc: outreachy-kernel
On Sun, Mar 03, 2019 at 02:01:36AM -0800, Debleena Sen wrote:
> Break the line and match the indentation to remove the
> checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What changed from the previous versions? That information always goes
below the --- line please.
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4] Staging: pi433: Fix line over 80 characters issue
@ 2019-03-03 10:01 Debleena Sen
2019-03-05 7:40 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Debleena Sen @ 2019-03-03 10:01 UTC (permalink / raw)
To: gregkh, outreachy-kernel; +Cc: Debleena Sen
Break the line and match the indentation to remove the
checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Debleena Sen <idebleenasen@gmail.com>
---
drivers/staging/pi433/rf69.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index e19b9ce..0c189a7 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
{
switch (flag) {
case mode_switch_completed:
- return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_MODE_READY);
+ return (rf69_read_reg(spi, REG_IRQFLAGS1) &
+ MASK_IRQFLAGS1_MODE_READY);
case ready_to_receive:
return (rf69_read_reg(spi, REG_IRQFLAGS1) & MASK_IRQFLAGS1_RX_READY);
case ready_to_send:
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-06 9:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05 15:06 [PATCH v4] Staging: pi433: Fix line over 80 characters issue Debleena Sen
-- strict thread matches above, loose matches on Subject: below --
2019-03-03 10:01 Debleena Sen
2019-03-05 7:40 ` Greg KH
2019-03-05 14:00 ` Debleena Sen
2019-03-05 16:24 ` Debleena Sen
2019-03-06 9:15 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.