* [PATCH] staging: speakup: Fix NULL comparison warning
@ 2019-03-06 12:42 Daniela Mormocea
2019-03-07 20:05 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Daniela Mormocea @ 2019-03-06 12:42 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Daniela Mormocea
Replace NULL comparison with '!' operator as indicated
by checkpatch
Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
---
drivers/staging/speakup/spk_ttyio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
index 0057eb9..5a9eff0 100644
--- a/drivers/staging/speakup/spk_ttyio.c
+++ b/drivers/staging/speakup/spk_ttyio.c
@@ -47,7 +47,7 @@ static int spk_ttyio_ldisc_open(struct tty_struct *tty)
{
struct spk_ldisc_data *ldisc_data;
- if (tty->ops->write == NULL)
+ if (!tty->ops->write)
return -EOPNOTSUPP;
speakup_tty = tty;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: Fix NULL comparison warning
2019-03-06 12:42 [PATCH] staging: speakup: Fix NULL comparison warning Daniela Mormocea
@ 2019-03-07 20:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-07 20:05 UTC (permalink / raw)
To: Daniela Mormocea; +Cc: outreachy-kernel
On Wed, Mar 06, 2019 at 02:42:42PM +0200, Daniela Mormocea wrote:
> Replace NULL comparison with '!' operator as indicated
> by checkpatch
>
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> drivers/staging/speakup/spk_ttyio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c
> index 0057eb9..5a9eff0 100644
> --- a/drivers/staging/speakup/spk_ttyio.c
> +++ b/drivers/staging/speakup/spk_ttyio.c
> @@ -47,7 +47,7 @@ static int spk_ttyio_ldisc_open(struct tty_struct *tty)
> {
> struct spk_ldisc_data *ldisc_data;
>
> - if (tty->ops->write == NULL)
> + if (!tty->ops->write)
> return -EOPNOTSUPP;
> speakup_tty = tty;
>
Someone already sent this same fix to the same file just before you did,
sorry.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-07 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 12:42 [PATCH] staging: speakup: Fix NULL comparison warning Daniela Mormocea
2019-03-07 20:05 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.