All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors
@ 2019-03-13 19:37 Andrew Cooper
  2019-03-14  8:20 ` Jan Beulich
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2019-03-13 19:37 UTC (permalink / raw)
  To: Xen-devel; +Cc: Andrew Cooper, Wei Liu, Jan Beulich, Roger Pau Monné

Just SGX Launch Configuration is missing for one of my test boxes.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 tools/misc/xen-cpuid.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c
index d87a72e..2e4ca57 100644
--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -127,6 +127,8 @@ static const char *str_7c0[32] =
     [14] = "avx512_vpopcntdq",
 
     [22] = "rdpid",
+
+    [30] = "sgx-lc",
 };
 
 static const char *str_e7d[32] =
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors
  2019-03-13 19:37 [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors Andrew Cooper
@ 2019-03-14  8:20 ` Jan Beulich
  2019-03-14 11:06   ` Andrew Cooper
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2019-03-14  8:20 UTC (permalink / raw)
  To: Andrew Cooper; +Cc: Xen-devel, Wei Liu, Roger Pau Monne

>>> On 13.03.19 at 20:37, <andrew.cooper3@citrix.com> wrote:
> --- a/tools/misc/xen-cpuid.c
> +++ b/tools/misc/xen-cpuid.c
> @@ -127,6 +127,8 @@ static const char *str_7c0[32] =
>      [14] = "avx512_vpopcntdq",
>  
>      [22] = "rdpid",
> +
> +    [30] = "sgx-lc",
>  };
>  
>  static const char *str_e7d[32] =

Hmm, to be honest I don't see why this needs to go in ahead of
https://lists.xenproject.org/archives/html/xen-devel/2018-12/msg01813.html
posted almost 3 months ago, and already taking care of the bit.
I'm fine to switch from underscore to dash there if that's
desired, but it looks inconsistent with pre-existing entries (as
the context of your patch also shows).

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors
  2019-03-14  8:20 ` Jan Beulich
@ 2019-03-14 11:06   ` Andrew Cooper
  0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2019-03-14 11:06 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Xen-devel, Wei Liu, Roger Pau Monne

On 14/03/2019 08:20, Jan Beulich wrote:
>>>> On 13.03.19 at 20:37, <andrew.cooper3@citrix.com> wrote:
>> --- a/tools/misc/xen-cpuid.c
>> +++ b/tools/misc/xen-cpuid.c
>> @@ -127,6 +127,8 @@ static const char *str_7c0[32] =
>>      [14] = "avx512_vpopcntdq",
>>  
>>      [22] = "rdpid",
>> +
>> +    [30] = "sgx-lc",
>>  };
>>  
>>  static const char *str_e7d[32] =
> Hmm, to be honest I don't see why this needs to go in ahead of
> https://lists.xenproject.org/archives/html/xen-devel/2018-12/msg01813.html
> posted almost 3 months ago, and already taking care of the bit.

Because its hidden at the end of a series I haven't gotten to the end of
yet.  But yes - it does look to be a more complete patch so lets start
there.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-14 11:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 19:37 [PATCH] tools/cpuid: Update xen-cpuid for Coffee Lake processors Andrew Cooper
2019-03-14  8:20 ` Jan Beulich
2019-03-14 11:06   ` Andrew Cooper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.