* [PATCH RESEND] aacraid: Fix performance issue (QD) on logical drives
@ 2019-03-13 23:21 ` Sagar Biradar
0 siblings, 0 replies; 3+ messages in thread
From: Sagar Biradar @ 2019-03-13 23:21 UTC (permalink / raw)
To: Martin K. Petersen, James Bottomley
Cc: Sagar Biradar, linux-scsi, aacraid, Dave Carroll, Scott Benesh,
Brian King, stable, Sagar Biradar
Fix performance issue where the queue depth for SmartIOC logical
volumes is set to 1, and allow the usual logical volume code
to be executed
Fixes: a052865fe2871a3888 (aacraid: Set correct Queue Depth for HBA1000
RAW disks)
Signed-off-by: Sagar Biradar <Sagar.Biradar@microchip.com>
Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
---
drivers/scsi/aacraid/linit.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 7e56a11..cceffac 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -413,13 +413,16 @@ static int aac_slave_configure(struct scsi_device *sdev)
if (chn < AAC_MAX_BUSES && tid < AAC_MAX_TARGETS && aac->sa_firmware) {
devtype = aac->hba_map[chn][tid].devtype;
- if (devtype == AAC_DEVTYPE_NATIVE_RAW)
+ if (devtype == AAC_DEVTYPE_NATIVE_RAW) {
depth = aac->hba_map[chn][tid].qd_limit;
- else if (devtype == AAC_DEVTYPE_ARC_RAW)
+ set_timeout = 1;
+ goto common_config;
+ }
+ if (devtype == AAC_DEVTYPE_ARC_RAW) {
set_qd_dev_type = true;
-
- set_timeout = 1;
- goto common_config;
+ set_timeout = 1;
+ goto common_config;
+ }
}
if (aac->jbod && (sdev->type == TYPE_DISK))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH RESEND] aacraid: Fix performance issue (QD) on logical drives
@ 2019-03-13 23:21 ` Sagar Biradar
0 siblings, 0 replies; 3+ messages in thread
From: Sagar Biradar @ 2019-03-13 23:21 UTC (permalink / raw)
To: Martin K. Petersen, James Bottomley
Cc: Sagar Biradar, linux-scsi, aacraid, Dave Carroll, Scott Benesh,
Brian King, stable, Sagar Biradar
Fix performance issue where the queue depth for SmartIOC logical
volumes is set to 1, and allow the usual logical volume code
to be executed
Fixes: a052865fe2871a3888 (aacraid: Set correct Queue Depth for HBA1000
RAW disks)
Signed-off-by: Sagar Biradar <Sagar.Biradar@microchip.com>
Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
---
drivers/scsi/aacraid/linit.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 7e56a11..cceffac 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -413,13 +413,16 @@ static int aac_slave_configure(struct scsi_device *sdev)
if (chn < AAC_MAX_BUSES && tid < AAC_MAX_TARGETS && aac->sa_firmware) {
devtype = aac->hba_map[chn][tid].devtype;
- if (devtype == AAC_DEVTYPE_NATIVE_RAW)
+ if (devtype == AAC_DEVTYPE_NATIVE_RAW) {
depth = aac->hba_map[chn][tid].qd_limit;
- else if (devtype == AAC_DEVTYPE_ARC_RAW)
+ set_timeout = 1;
+ goto common_config;
+ }
+ if (devtype == AAC_DEVTYPE_ARC_RAW) {
set_qd_dev_type = true;
-
- set_timeout = 1;
- goto common_config;
+ set_timeout = 1;
+ goto common_config;
+ }
}
if (aac->jbod && (sdev->type == TYPE_DISK))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] aacraid: Fix performance issue (QD) on logical drives
2019-03-13 23:21 ` Sagar Biradar
(?)
@ 2019-03-13 22:45 ` Greg KH
-1 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-03-13 22:45 UTC (permalink / raw)
To: Sagar Biradar
Cc: Martin K. Petersen, James Bottomley, linux-scsi, aacraid,
Dave Carroll, Scott Benesh, Brian King, stable
On Wed, Mar 13, 2019 at 04:21:24PM -0700, Sagar Biradar wrote:
> Fix performance issue where the queue depth for SmartIOC logical
> volumes is set to 1, and allow the usual logical volume code
> to be executed
>
> Fixes: a052865fe2871a3888 (aacraid: Set correct Queue Depth for HBA1000
> RAW disks)
>
> Signed-off-by: Sagar Biradar <Sagar.Biradar@microchip.com>
> Reviewed-by: Dave Carroll <david.carroll@microsemi.com>
> ---
> drivers/scsi/aacraid/linit.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-13 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 23:21 [PATCH RESEND] aacraid: Fix performance issue (QD) on logical drives Sagar Biradar
2019-03-13 23:21 ` Sagar Biradar
2019-03-13 22:45 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.