All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] [Outreachy kernel] staging: vt6655: spaces around operators
@ 2019-03-21  9:25 Payal Kshirsagar
  2019-03-21 19:02 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Payal Kshirsagar @ 2019-03-21  9:25 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Payal Kshirsagar

Add spaces around operators

Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>

---

In v1, prefer spaces around operator,
In v2, 'prefer' changed to 'add',
In v3, changes are mentioned
and in v4 changes written below '---'.

 drivers/staging/vt6655/device_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index b370985..866d794 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -592,7 +592,7 @@ static int device_init_rd1_ring(struct vnt_private *priv)
 			goto err_free_rd;
 		}
 
-		desc->next = &priv->aRD1Ring[(i+1) % priv->opts.rx_descs1];
+		desc->next = &priv->aRD1Ring[(i + 1) % priv->opts.rx_descs1];
 		desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc));
 	}
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] [Outreachy kernel] staging: vt6655: spaces around operators
  2019-03-21  9:25 [PATCH v4] [Outreachy kernel] staging: vt6655: spaces around operators Payal Kshirsagar
@ 2019-03-21 19:02 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-21 19:02 UTC (permalink / raw)
  To: Payal Kshirsagar; +Cc: outreachy-kernel

On Thu, Mar 21, 2019 at 02:55:15PM +0530, Payal Kshirsagar wrote:
> Add spaces around operators

That says _what_ you did (which is obvious looking at the patch), but it
does not say _why_ you did this, which is what needs to be in a
changelog text.

Please fix up and resend.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-21 19:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21  9:25 [PATCH v4] [Outreachy kernel] staging: vt6655: spaces around operators Payal Kshirsagar
2019-03-21 19:02 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.