From: Chris Wilson <chris@chris-wilson.co.uk> To: Andi Shyti <andi@etezian.org> Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH i-g-t 22/24] i915: Add gem_ctx_engines Date: Fri, 22 Mar 2019 16:48:42 +0000 [thread overview] Message-ID: <155327331714.26447.17391579505829010917@skylake-alporthouse-com> (raw) In-Reply-To: <20190322164007.GA18131@jack.zhora.eu> Quoting Andi Shyti (2019-03-22 16:40:07) > Hi Chris, > > sorry for the late reply, I got 5 version of this same patch and > I couldn't figure out what was what :) > > Could you please add some versioning or note if version is > the same? > > Some nits and questions.... > > > +static bool has_context_engines(int i915) > > +{ > > + struct drm_i915_gem_context_param param = { > > + .ctx_id = 0, > > + .param = I915_CONTEXT_PARAM_ENGINES, > > + }; > > + return __gem_context_set_param(i915, ¶m) == 0; > > +} > > I had it and removed it so many times in gem_engine_topology, > shall I put it back and we take it from there? (maybe in the > future). > > [...] > > + igt_assert_eq(__gem_context_set_param(i915, ¶m), -ENOENT); > > + > > + mprotect(engines, 4096, PROT_READ); > > (from the last review) mprotect can fail, do we care? Debatable, yes we care as we won't get the expected faults in the next tests, but do we want to call this the test failure? I want something other than igt_require/igt_assert! > > + idx = 0; > > + memset(&engines, 0, sizeof(engines)); > > + for_each_engine_class_instance(i915, e) { > > + engines.class_instance[idx].engine_class = e->class; > > + engines.class_instance[idx].engine_instance = e->instance; > > + idx++; > > + } > > + idx *= sizeof(*engines.class_instance); > > + p.size = base + idx; > > (I normally review from bottom to top) You used at least three > different ways to calculate param's size (some unclear to who > is new to igt some more clear). > > Does it make sense to have a global define and we keep it > consistent? > > p.size = SIZEOF_CTX_PARAM(idx); Definitely not shouting about it. I honestly believe that a plethora of styles within tests is a good thing, and everything using the same code pattern reduces the amount of test serendipity. While this is a bit of trivial math and should not affect the outcome in anyway, I quite like having bits and pieces fall naturally out of the code because the code should also be an example of different ways it might be used. > it's a piece of code that I think it will be ussed a lot. > > > + /* Unadulterated I915_EXEC_DEFAULT should work */ > > + execbuf.flags = 0; > > + igt_assert_eq(__gem_execbuf(i915, &execbuf), 0); > > why aren't you using simply gem_execbuf()? So the style matched the open calls to __gem_execbuf() later. > > + execbuf.flags = j; > > + err =__gem_execbuf(i915, &execbuf); > > + if (j == i) { > > + igt_assert_f(err == 0, > > + "Failed to report the valid engine for slot %d\n", > > + i); > > + } else { > > + igt_assert_f(err == -EINVAL, > > + "Failed to report an invalid engine for slot %d (valid at %d)\n", > > + j, i); > > + } > > + } > > + > > + do_ioctl(i915, DRM_IOCTL_I915_GEM_BUSY, &busy); > > + if (i != -1) { > > + igt_assert_eq(busy.busy, 1 << (e->class + 16)); > > + } else { > > + igt_assert_eq(busy.busy, 0); > > + } > > + > > (from the last review) this is not kernel style, not that I care > much, but I thought you did. Indeed, _we_ do care ;) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk> To: Andi Shyti <andi@etezian.org> Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Andi Shyti <andi@etezian.org> Subject: Re: [igt-dev] [PATCH i-g-t 22/24] i915: Add gem_ctx_engines Date: Fri, 22 Mar 2019 16:48:42 +0000 [thread overview] Message-ID: <155327331714.26447.17391579505829010917@skylake-alporthouse-com> (raw) In-Reply-To: <20190322164007.GA18131@jack.zhora.eu> Quoting Andi Shyti (2019-03-22 16:40:07) > Hi Chris, > > sorry for the late reply, I got 5 version of this same patch and > I couldn't figure out what was what :) > > Could you please add some versioning or note if version is > the same? > > Some nits and questions.... > > > +static bool has_context_engines(int i915) > > +{ > > + struct drm_i915_gem_context_param param = { > > + .ctx_id = 0, > > + .param = I915_CONTEXT_PARAM_ENGINES, > > + }; > > + return __gem_context_set_param(i915, ¶m) == 0; > > +} > > I had it and removed it so many times in gem_engine_topology, > shall I put it back and we take it from there? (maybe in the > future). > > [...] > > + igt_assert_eq(__gem_context_set_param(i915, ¶m), -ENOENT); > > + > > + mprotect(engines, 4096, PROT_READ); > > (from the last review) mprotect can fail, do we care? Debatable, yes we care as we won't get the expected faults in the next tests, but do we want to call this the test failure? I want something other than igt_require/igt_assert! > > + idx = 0; > > + memset(&engines, 0, sizeof(engines)); > > + for_each_engine_class_instance(i915, e) { > > + engines.class_instance[idx].engine_class = e->class; > > + engines.class_instance[idx].engine_instance = e->instance; > > + idx++; > > + } > > + idx *= sizeof(*engines.class_instance); > > + p.size = base + idx; > > (I normally review from bottom to top) You used at least three > different ways to calculate param's size (some unclear to who > is new to igt some more clear). > > Does it make sense to have a global define and we keep it > consistent? > > p.size = SIZEOF_CTX_PARAM(idx); Definitely not shouting about it. I honestly believe that a plethora of styles within tests is a good thing, and everything using the same code pattern reduces the amount of test serendipity. While this is a bit of trivial math and should not affect the outcome in anyway, I quite like having bits and pieces fall naturally out of the code because the code should also be an example of different ways it might be used. > it's a piece of code that I think it will be ussed a lot. > > > + /* Unadulterated I915_EXEC_DEFAULT should work */ > > + execbuf.flags = 0; > > + igt_assert_eq(__gem_execbuf(i915, &execbuf), 0); > > why aren't you using simply gem_execbuf()? So the style matched the open calls to __gem_execbuf() later. > > + execbuf.flags = j; > > + err =__gem_execbuf(i915, &execbuf); > > + if (j == i) { > > + igt_assert_f(err == 0, > > + "Failed to report the valid engine for slot %d\n", > > + i); > > + } else { > > + igt_assert_f(err == -EINVAL, > > + "Failed to report an invalid engine for slot %d (valid at %d)\n", > > + j, i); > > + } > > + } > > + > > + do_ioctl(i915, DRM_IOCTL_I915_GEM_BUSY, &busy); > > + if (i != -1) { > > + igt_assert_eq(busy.busy, 1 << (e->class + 16)); > > + } else { > > + igt_assert_eq(busy.busy, 0); > > + } > > + > > (from the last review) this is not kernel style, not that I care > much, but I thought you did. Indeed, _we_ do care ;) -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-22 16:48 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-22 9:21 [PATCH i-g-t 01/24] i915/gem_exec_latency: Measure the latency of context switching Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 02/24] lib: Add GPU power measurement Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 8:36 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 8:36 ` Tvrtko Ursulin 2019-03-26 8:49 ` Chris Wilson 2019-03-26 8:49 ` Chris Wilson 2019-03-26 9:18 ` [PATCH i-g-t v2] " Chris Wilson 2019-03-26 9:18 ` [igt-dev] " Chris Wilson 2019-03-26 9:52 ` Tvrtko Ursulin 2019-03-26 9:52 ` Tvrtko Ursulin 2019-03-26 10:06 ` Chris Wilson 2019-03-26 10:06 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 03/24] i915/gem_exec_schedule: Measure semaphore power consumption Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 8:46 ` Tvrtko Ursulin 2019-03-26 8:46 ` [Intel-gfx] " Tvrtko Ursulin 2019-03-26 9:23 ` Chris Wilson 2019-03-26 9:23 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 04/24] i915/gem_exec_whisper: Measure total power consumed Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 8:47 ` Tvrtko Ursulin 2019-03-26 8:47 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 05/24] i915/gem_exec_schedule: Verify that using HW semaphores doesn't block Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 9:19 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 9:19 ` Tvrtko Ursulin 2019-03-26 10:03 ` Chris Wilson 2019-03-26 10:03 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 06/24] i915/gem_exec_nop: poll-sequential requires ordering between rings Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 9:38 ` Tvrtko Ursulin 2019-03-26 9:38 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 07/24] i915/gem_sync: Make switch-default asymmetric Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 9:57 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 9:57 ` [Intel-gfx] " Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 08/24] i915/gem_ctx_param: Remove kneecapping Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 9:58 ` Tvrtko Ursulin 2019-03-26 9:58 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 09/24] i915/gem_exec_big: Add a single shot test Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-26 10:06 ` [igt-dev] " Tvrtko Ursulin 2019-03-26 10:06 ` Tvrtko Ursulin 2019-03-26 10:21 ` Chris Wilson 2019-03-26 10:21 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 10/24] kms_fence_pin_leak: Ask for the GPU before use Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:10 ` Tvrtko Ursulin 2019-03-26 10:10 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 11/24] drm-uapi: Import i915_drm.h upto 53073249452d Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 12/24] lib/i915: Improve gem_context error messages Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:14 ` Tvrtko Ursulin 2019-03-26 10:14 ` Tvrtko Ursulin 2019-03-22 9:21 ` [PATCH i-g-t 13/24] i915/gem_ctx_param: Test set/get (copy) VM Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:22 ` Tvrtko Ursulin 2019-03-26 10:22 ` Tvrtko Ursulin 2019-03-26 10:33 ` Tvrtko Ursulin 2019-03-26 10:33 ` Tvrtko Ursulin 2019-03-26 10:51 ` Chris Wilson 2019-03-26 10:51 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 14/24] i915/gem_ctx_create: Basic checks for constructor properties Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 10:46 ` Tvrtko Ursulin 2019-03-26 10:46 ` Tvrtko Ursulin 2019-03-26 11:06 ` Chris Wilson 2019-03-26 11:06 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 15/24] i915: Add gem_vm_create Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 11:21 ` Tvrtko Ursulin 2019-03-26 11:21 ` Tvrtko Ursulin 2019-03-26 11:37 ` Chris Wilson 2019-03-26 11:37 ` Chris Wilson 2019-03-26 11:48 ` Tvrtko Ursulin 2019-03-26 11:48 ` Tvrtko Ursulin 2019-03-26 14:11 ` Chris Wilson 2019-03-26 14:11 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 16/24] drm-uapi: Import i915_drm.h upto 364df3d04d51 Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 17/24] i915: Add gem_ctx_clone Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-26 15:44 ` Tvrtko Ursulin 2019-03-26 15:44 ` Tvrtko Ursulin 2019-03-26 15:49 ` Chris Wilson 2019-03-26 15:49 ` Chris Wilson 2019-03-26 15:54 ` Chris Wilson 2019-03-26 15:54 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 18/24] i915: Exercise creating context with shared GTT Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 19/24] i915/gem_ctx_switch: Exercise queues Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 20/24] i915/gem_exec_whisper: Fork all-engine tests one-per-engine Chris Wilson 2019-03-22 9:21 ` [Intel-gfx] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 21/24] i915/gem_exec_whisper: debugfs/next_seqno is defunct Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 22/24] i915: Add gem_ctx_engines Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 16:40 ` Andi Shyti 2019-03-22 16:40 ` [igt-dev] " Andi Shyti 2019-03-22 16:48 ` Chris Wilson [this message] 2019-03-22 16:48 ` Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 23/24] i915: Add gem_exec_balancer Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 9:21 ` [PATCH i-g-t 24/24] i915/gem_exec_balancer: Exercise bonded pairs Chris Wilson 2019-03-22 9:21 ` [igt-dev] " Chris Wilson 2019-03-22 10:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,01/24] i915/gem_exec_latency: Measure the latency of context switching Patchwork 2019-03-23 6:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2019-03-26 11:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,01/24] i915/gem_exec_latency: Measure the latency of context switching (rev2) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=155327331714.26447.17391579505829010917@skylake-alporthouse-com \ --to=chris@chris-wilson.co.uk \ --cc=andi@etezian.org \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.