From: Vandita Kulkarni <vandita.kulkarni@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: ville.syrjala@intel.com, jani.nikula@intel.com
Subject: [v3 1/2] drm/i915/icl: Ungate ddi clocks before IO enable
Date: Mon, 25 Mar 2019 16:56:41 +0530 [thread overview]
Message-ID: <1553513202-13863-1-git-send-email-vandita.kulkarni@intel.com> (raw)
IO enable sequencing needs ddi clocks enabled.
These clocks will be gated at a later point in
the enable sequence.
v2: Fix the commit header (Uma)
v3: Remove the redundant read (Ville)
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/icl_dsi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
index 92440ff..4aef5dd 100644
--- a/drivers/gpu/drm/i915/icl_dsi.c
+++ b/drivers/gpu/drm/i915/icl_dsi.c
@@ -589,6 +589,12 @@ static void gen11_dsi_map_pll(struct intel_encoder *encoder,
val |= DPCLKA_CFGCR0_DDI_CLK_SEL(pll->info->id, port);
}
I915_WRITE(DPCLKA_CFGCR0_ICL, val);
+
+ for_each_dsi_port(port, intel_dsi->ports) {
+ val &= ~DPCLKA_CFGCR0_DDI_CLK_OFF(port);
+ }
+ I915_WRITE(DPCLKA_CFGCR0_ICL, val);
+
POSTING_READ(DPCLKA_CFGCR0_ICL);
mutex_unlock(&dev_priv->dpll_lock);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2019-03-25 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 11:26 Vandita Kulkarni [this message]
2019-03-25 11:26 ` [v3 2/2] drm/i915/icl: Fix port disable sequence for mipi-dsi Vandita Kulkarni
2019-03-26 6:07 ` Shankar, Uma
2019-03-25 12:33 ` ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/icl: Ungate ddi clocks before IO enable Patchwork
2019-03-27 15:04 ` [v3 1/2] " Jani Nikula
2019-03-27 19:36 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915/icl: Ungate ddi clocks before IO enable (rev2) Patchwork
2019-03-28 15:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-04-02 18:48 ` ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915/icl: Ungate ddi clocks before IO enable (rev3) Patchwork
2019-04-03 6:52 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553513202-13863-1-git-send-email-vandita.kulkarni@intel.com \
--to=vandita.kulkarni@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.