All of lore.kernel.org
 help / color / mirror / Atom feed
From: <twischer@de.adit-jv.com>
To: <patch@alsa-project.org>, <broonie@kernel.org>, <perex@perex.cz>,
	<tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	Timo Wischer <twischer@de.adit-jv.com>
Subject: [PATCH 01/10] ALSA: aloop: Describe units of variables
Date: Mon, 25 Mar 2019 17:00:35 +0100	[thread overview]
Message-ID: <1553529644-5654-2-git-send-email-twischer@de.adit-jv.com> (raw)
In-Reply-To: <1553529644-5654-1-git-send-email-twischer@de.adit-jv.com>

From: Timo Wischer <twischer@de.adit-jv.com>

Describe the unit of the variables used to calculate the hw pointer
depending on jiffies ticks.

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
---
 sound/drivers/aloop.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c
index 8c3fbe1..70145e6 100644
--- a/sound/drivers/aloop.c
+++ b/sound/drivers/aloop.c
@@ -116,8 +116,10 @@ struct loopback_pcm {
 	/* flags */
 	unsigned int period_update_pending :1;
 	/* timer stuff */
-	unsigned int irq_pos;		/* fractional IRQ position */
-	unsigned int period_size_frac;
+	unsigned int irq_pos;		/* fractional IRQ position in jiffies
+					 * ticks
+					 */
+	unsigned int period_size_frac;	/* period size in jiffies ticks */
 	unsigned int last_drift;
 	unsigned long last_jiffies;
 	struct timer_list timer;
-- 
2.7.4


WARNING: multiple messages have this Message-ID (diff)
From: <twischer@de.adit-jv.com>
To: patch@alsa-project.org, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Timo Wischer <twischer@de.adit-jv.com>
Subject: [PATCH 01/10] ALSA: aloop: Describe units of variables
Date: Mon, 25 Mar 2019 17:00:35 +0100	[thread overview]
Message-ID: <1553529644-5654-2-git-send-email-twischer@de.adit-jv.com> (raw)
In-Reply-To: <1553529644-5654-1-git-send-email-twischer@de.adit-jv.com>

From: Timo Wischer <twischer@de.adit-jv.com>

Describe the unit of the variables used to calculate the hw pointer
depending on jiffies ticks.

Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
---
 sound/drivers/aloop.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/drivers/aloop.c b/sound/drivers/aloop.c
index 8c3fbe1..70145e6 100644
--- a/sound/drivers/aloop.c
+++ b/sound/drivers/aloop.c
@@ -116,8 +116,10 @@ struct loopback_pcm {
 	/* flags */
 	unsigned int period_update_pending :1;
 	/* timer stuff */
-	unsigned int irq_pos;		/* fractional IRQ position */
-	unsigned int period_size_frac;
+	unsigned int irq_pos;		/* fractional IRQ position in jiffies
+					 * ticks
+					 */
+	unsigned int period_size_frac;	/* period size in jiffies ticks */
 	unsigned int last_drift;
 	unsigned long last_jiffies;
 	struct timer_list timer;
-- 
2.7.4

  reply	other threads:[~2019-03-25 16:01 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 16:00 [PATCH 00/10] ALSA: aloop: Support selection of snd_timer twischer
2019-03-25 16:00 ` twischer
2019-03-25 16:00 ` twischer [this message]
2019-03-25 16:00   ` [PATCH 01/10] ALSA: aloop: Describe units of variables twischer
2019-03-25 16:00 ` [PATCH 02/10] ALSA: aloop: loopback_timer_start: Support return of error code twischer
2019-03-25 16:00   ` twischer
2019-03-25 16:00 ` [PATCH 03/10] ALSA: aloop: loopback_timer_stop: " twischer
2019-03-25 16:00   ` twischer
2019-03-25 16:00 ` [PATCH 04/10] ALSA: aloop: Use always spin_lock_irqsave() for cable->lock twischer
2019-03-25 16:00   ` twischer
2019-03-25 16:07   ` Takashi Iwai
2019-03-25 16:07     ` Takashi Iwai
2019-03-25 16:40     ` Timo Wischer
2019-03-25 16:58       ` Takashi Iwai
2019-03-25 16:58         ` Takashi Iwai
2019-03-26  8:12         ` Timo Wischer
2019-03-26  8:12           ` Timo Wischer
2019-03-26  7:49 ` [PATCH 05/10] ALSA: aloop: Use callback functions for timer specific implementations twischer
2019-03-26  7:49   ` twischer
2019-03-26  7:49   ` [PATCH 06/10] ALSA: aloop: Rename all jiffies timer specific functions twischer
2019-03-26  7:49     ` twischer
2019-03-26  7:49   ` [PATCH 07/10] ALSA: aloop: Move CABLE_VALID_BOTH to the top of file twischer
2019-03-26  7:49     ` twischer
2019-03-26  7:49   ` [PATCH 08/10] ALSA: aloop: Support selection of snd_timer instead of jiffies twischer
2019-03-26  7:49     ` twischer
2019-03-26  7:49   ` [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link() twischer
2019-03-26  7:49     ` twischer
2019-03-26  8:35     ` Takashi Iwai
2019-03-26  8:35       ` Takashi Iwai
2019-03-26 11:25       ` Timo Wischer
2019-03-26 14:23         ` Takashi Iwai
2019-03-26 14:23           ` Takashi Iwai
2019-03-26 15:16           ` Timo Wischer
2019-03-26 15:16             ` Timo Wischer
2019-03-26 16:00             ` Takashi Iwai
2019-03-26 16:00               ` Takashi Iwai
2019-03-27  8:34               ` Timo Wischer
2019-03-27  8:34                 ` Timo Wischer
2019-03-27  9:11                 ` Takashi Iwai
2019-03-27  9:11                   ` Takashi Iwai
2019-03-27  9:26                   ` Timo Wischer
2019-03-27  9:26                     ` Timo Wischer
2019-03-27  9:38                     ` Takashi Iwai
2019-03-27  9:38                       ` Takashi Iwai
2019-04-04 10:18                       ` Timo Wischer
2019-04-04 10:18                         ` Timo Wischer
2019-04-05 15:21                         ` Takashi Iwai
2019-04-05 15:21                           ` Takashi Iwai
2019-03-26  7:52 ` [PATCH 10/10] ALSA: aloop: Use timer of linked card if chosen twischer
2019-03-26  7:52   ` twischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553529644-5654-2-git-send-email-twischer@de.adit-jv.com \
    --to=twischer@de.adit-jv.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patch@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.