* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
@ 2019-03-28 9:36 Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Xiao Yang @ 2019-03-28 9:36 UTC (permalink / raw)
To: ltp
Use LTP_CHECK_LIBC_FUNCS if only libc implementations need to be checked.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
configure.ac | 23 +----------------------
m4/ltp-epoll_pwait.m4 | 25 -------------------------
m4/ltp-execveat.m4 | 25 -------------------------
m4/ltp-fallocate.m4 | 25 -------------------------
m4/ltp-fchownat.m4 | 25 -------------------------
m4/ltp-fstatat.m4 | 26 --------------------------
m4/ltp-kcmp.m4 | 23 -----------------------
m4/ltp-libc-funcs.m4 | 14 ++++++++++++++
m4/ltp-mkdirat.m4 | 25 -------------------------
m4/ltp-mknodat.m4 | 25 -------------------------
m4/ltp-openat.m4 | 25 -------------------------
m4/ltp-preadv.m4 | 23 -----------------------
m4/ltp-preadv2.m4 | 9 ---------
m4/ltp-pwritev.m4 | 23 -----------------------
m4/ltp-pwritev2.m4 | 9 ---------
m4/ltp-readlinkat.m4 | 25 -------------------------
m4/ltp-renameat.m4 | 25 -------------------------
m4/ltp-renameat2.m4 | 27 ---------------------------
m4/ltp-splice.m4 | 25 -------------------------
m4/ltp-sync_file_range.m4 | 10 ----------
m4/ltp-syncfs.m4 | 10 ----------
m4/ltp-tee.m4 | 25 -------------------------
m4/ltp-unshare.m4 | 25 -------------------------
m4/ltp-vmsplice.m4 | 25 -------------------------
24 files changed, 15 insertions(+), 507 deletions(-)
delete mode 100644 m4/ltp-epoll_pwait.m4
delete mode 100644 m4/ltp-execveat.m4
delete mode 100644 m4/ltp-fallocate.m4
delete mode 100644 m4/ltp-fchownat.m4
delete mode 100644 m4/ltp-fstatat.m4
delete mode 100644 m4/ltp-kcmp.m4
create mode 100644 m4/ltp-libc-funcs.m4
delete mode 100644 m4/ltp-mkdirat.m4
delete mode 100644 m4/ltp-mknodat.m4
delete mode 100644 m4/ltp-openat.m4
delete mode 100644 m4/ltp-preadv.m4
delete mode 100644 m4/ltp-preadv2.m4
delete mode 100644 m4/ltp-pwritev.m4
delete mode 100644 m4/ltp-pwritev2.m4
delete mode 100644 m4/ltp-readlinkat.m4
delete mode 100644 m4/ltp-renameat.m4
delete mode 100644 m4/ltp-renameat2.m4
delete mode 100644 m4/ltp-splice.m4
delete mode 100644 m4/ltp-sync_file_range.m4
delete mode 100644 m4/ltp-syncfs.m4
delete mode 100644 m4/ltp-tee.m4
delete mode 100644 m4/ltp-unshare.m4
delete mode 100644 m4/ltp-vmsplice.m4
diff --git a/configure.ac b/configure.ac
index d71d832..c231e33 100644
--- a/configure.ac
+++ b/configure.ac
@@ -182,7 +182,6 @@ LTP_CHECK_SYSCALL_EVENTFD
LTP_CHECK_SYSCALL_MODIFY_LDT
LTP_CHECK_SYSCALL_QUOTACTL
LTP_CHECK_SYSCALL_SIGNALFD
-LTP_CHECK_SYSCALL_UNSHARE
LTP_CHECK_SYSCALL_UTIMENSAT
LTP_CHECK_TASKSTATS
LTP_CHECK_TIME
@@ -193,36 +192,17 @@ LTP_CHECK_MREMAP_FIXED
LTP_CHECK_KERNEL_DEVEL
LTP_CHECK_XFS_QUOTACTL
LTP_CHECK_CLONE_SUPPORTS_7_ARGS
-LTP_CHECK_MKDIRAT
-LTP_CHECK_FCHOWNAT
-LTP_CHECK_FSTATAT
-LTP_CHECK_MKNODAT
-LTP_CHECK_READLINKAT
-LTP_CHECK_OPENAT
-LTP_CHECK_EXECVEAT
-LTP_CHECK_RENAMEAT
-LTP_CHECK_RENAMEAT2
LTP_CHECK_STATX
-LTP_CHECK_FALLOCATE
LTP_CHECK_SYSCALL_FCNTL
LTP_CHECK_SYSCALL_PERF_EVENT_OPEN
if test "x$with_tirpc" = xyes; then
LTP_CHECK_TIRPC
fi
-LTP_CHECK_TEE
-LTP_CHECK_SPLICE
-LTP_CHECK_VMSPLICE
LTP_CHECK_TIMERFD
LTP_CHECK_IOVEC
LTP_CHECK_LINUXRANDOM
LTP_CHECK_IF_LINK
-LTP_CHECK_KCMP
LTP_CHECK_KCMP_TYPE
-LTP_CHECK_PREADV
-LTP_CHECK_PWRITEV
-LTP_CHECK_PREADV2
-LTP_CHECK_PWRITEV2
-LTP_CHECK_EPOLL_PWAIT
LTP_CHECK_KEYUTILS_SUPPORT
LTP_CHECK_SYNC_ADD_AND_FETCH
LTP_CHECK_BUILTIN_CLEAR_CACHE
@@ -234,10 +214,9 @@ LTP_CHECK_TPACKET_V3
LTP_CHECK_RLIMIT64
LTP_DETECT_HOST_CPU
LTP_CHECK_PERF_EVENT
-LTP_CHECK_SYNCFS
-LTP_CHECK_SYNC_FILE_RANGE
LTP_CHECK_FTS_H
LTP_CHECK_FIDEDUPE
+LTP_CHECK_LIBC_FUNCS
if test "x$with_numa" = xyes; then
LTP_CHECK_SYSCALL_NUMA
diff --git a/m4/ltp-epoll_pwait.m4 b/m4/ltp-epoll_pwait.m4
deleted file mode 100644
index e918110..0000000
--- a/m4/ltp-epoll_pwait.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) 2016 Fujitsu Ltd.
-dnl Author: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program.
-dnl
-
-dnl
-dnl LTP_CHECK_EPOLL_PWAIT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_EPOLL_PWAIT],[
-AC_CHECK_FUNCS(epoll_pwait,,)
-])
diff --git a/m4/ltp-execveat.m4 b/m4/ltp-execveat.m4
deleted file mode 100644
index 8cb6147..0000000
--- a/m4/ltp-execveat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_EXECVEAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_EXECVEAT],[
-AC_CHECK_FUNCS(execveat,,)
-])
diff --git a/m4/ltp-fallocate.m4 b/m4/ltp-fallocate.m4
deleted file mode 100644
index c7d509e..0000000
--- a/m4/ltp-fallocate.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_FALLOCATE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_FALLOCATE],[
-AC_CHECK_FUNCS(fallocate,,)
-])
diff --git a/m4/ltp-fchownat.m4 b/m4/ltp-fchownat.m4
deleted file mode 100644
index a46a397..0000000
--- a/m4/ltp-fchownat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_FCHOWNAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_FCHOWNAT],[
-AC_CHECK_FUNCS(fchownat,,)
-])
diff --git a/m4/ltp-fstatat.m4 b/m4/ltp-fstatat.m4
deleted file mode 100644
index 8814ade..0000000
--- a/m4/ltp-fstatat.m4
+++ /dev/null
@@ -1,26 +0,0 @@
-dnl
-dnl Copyright (c) 2016 Oracle and/or its affiliates. All Rights Reserved.
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program. If not, see <http://www.gnu.org/licenses/>.
-dnl
-dnl Author: Alexey Kodanev <alexey.kodanev@oracle.com>
-dnl
-
-dnl
-dnl LTP_CHECK_FSTATAT
-dnl -----------------
-dnl
-AC_DEFUN([LTP_CHECK_FSTATAT],[
-AC_CHECK_FUNCS(fstatat,,)
-])
diff --git a/m4/ltp-kcmp.m4 b/m4/ltp-kcmp.m4
deleted file mode 100644
index 70bf375..0000000
--- a/m4/ltp-kcmp.m4
+++ /dev/null
@@ -1,23 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2015
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software Foundation,
-dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-dnl Author: Cedric Hnyda <chnyda@suse.com>
-dnl
-
-AC_DEFUN([LTP_CHECK_KCMP],[
-AC_CHECK_FUNCS(kcmp,,)
-])
diff --git a/m4/ltp-libc-funcs.m4 b/m4/ltp-libc-funcs.m4
new file mode 100644
index 0000000..ebbe2c9
--- /dev/null
+++ b/m4/ltp-libc-funcs.m4
@@ -0,0 +1,14 @@
+dnl SPDX-License-Identifier: GPL-2.0-or-later
+dnl Copyright (c) 2019 Fujitsu Ltd.
+dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
+
+dnl
+dnl LTP_CHECK_LIBC_FUNCS
+dnl ----------------------------
+dnl
+
+AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
+AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
+mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
+splice syncfs sync_file_range tee unshare vmsplice,,)
+])
diff --git a/m4/ltp-mkdirat.m4 b/m4/ltp-mkdirat.m4
deleted file mode 100644
index 40786c3..0000000
--- a/m4/ltp-mkdirat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_MKDIRAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_MKDIRAT],[
-AC_CHECK_FUNCS(mkdirat,,)
-])
diff --git a/m4/ltp-mknodat.m4 b/m4/ltp-mknodat.m4
deleted file mode 100644
index 1ec22c7..0000000
--- a/m4/ltp-mknodat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_MKNODAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_MKNODAT],[
-AC_CHECK_FUNCS(mknodat,,)
-])
diff --git a/m4/ltp-openat.m4 b/m4/ltp-openat.m4
deleted file mode 100644
index aa3b0a3..0000000
--- a/m4/ltp-openat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_OPENAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_OPENAT],[
-AC_CHECK_FUNCS(openat,,)
-])
diff --git a/m4/ltp-preadv.m4 b/m4/ltp-preadv.m4
deleted file mode 100644
index 2046902..0000000
--- a/m4/ltp-preadv.m4
+++ /dev/null
@@ -1,23 +0,0 @@
-dnl
-dnl Copyright (c) 2015 Fujitsu Ltd.
-dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
-dnl
-dnl This program is free software; you can redistribute it and/or modify it
-dnl under the terms of version 2 of the GNU General Public License as
-dnl published by the Free Software Foundation.
-dnl
-dnl This program is distributed in the hope that it would be useful, but
-dnl WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl alone with this program.
-dnl
-
-dnl
-dnl LTP_CHECK_PREADV
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_PREADV],[
-AC_CHECK_FUNCS(preadv,,)
-])
diff --git a/m4/ltp-preadv2.m4 b/m4/ltp-preadv2.m4
deleted file mode 100644
index a1e5327..0000000
--- a/m4/ltp-preadv2.m4
+++ /dev/null
@@ -1,9 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2018 FUJITSU LIMITED. All rights reserved.
-dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
-
-dnl LTP_CHECK_PREADV2
-dnl ----------------------------
-AC_DEFUN([LTP_CHECK_PREADV2],[
-AC_CHECK_FUNCS(preadv2,,)
-])
diff --git a/m4/ltp-pwritev.m4 b/m4/ltp-pwritev.m4
deleted file mode 100644
index 6565332..0000000
--- a/m4/ltp-pwritev.m4
+++ /dev/null
@@ -1,23 +0,0 @@
-dnl
-dnl Copyright (c) 2015 Fujitsu Ltd.
-dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
-dnl
-dnl This program is free software; you can redistribute it and/or modify it
-dnl under the terms of version 2 of the GNU General Public License as
-dnl published by the Free Software Foundation.
-dnl
-dnl This program is distributed in the hope that it would be useful, but
-dnl WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl alone with this program.
-dnl
-
-dnl
-dnl LTP_CHECK_PWRITEV
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_PWRITEV],[
-AC_CHECK_FUNCS(pwritev,,)
-])
diff --git a/m4/ltp-pwritev2.m4 b/m4/ltp-pwritev2.m4
deleted file mode 100644
index 38148ac..0000000
--- a/m4/ltp-pwritev2.m4
+++ /dev/null
@@ -1,9 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2019 FUJITSU LIMITED. All rights reserved.
-dnl Author: Jinhui Huang <huangjh.jy@cn.fujitsu.com>
-
-dnl LTP_CHECK_PWRITEV2
-dnl ----------------------------
-AC_DEFUN([LTP_CHECK_PWRITEV2],[
-AC_CHECK_FUNCS(pwritev2,,)
-])
diff --git a/m4/ltp-readlinkat.m4 b/m4/ltp-readlinkat.m4
deleted file mode 100644
index 6866f3b..0000000
--- a/m4/ltp-readlinkat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_READLINKAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_READLINKAT],[
-AC_CHECK_FUNCS(readlinkat,,)
-])
diff --git a/m4/ltp-renameat.m4 b/m4/ltp-renameat.m4
deleted file mode 100644
index f40c58e..0000000
--- a/m4/ltp-renameat.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software Foundation,
-dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_RENAMEAT
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_RENAMEAT],[
-AC_CHECK_FUNCS(renameat,,)
-])
diff --git a/m4/ltp-renameat2.m4 b/m4/ltp-renameat2.m4
deleted file mode 100644
index 2bc7313..0000000
--- a/m4/ltp-renameat2.m4
+++ /dev/null
@@ -1,27 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2015
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software Foundation,
-dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-dnl Author: Cedric Hnyda <chnyda@suse.com>
-dnl
-
-dnl
-dnl LTP_CHECK_RENAMEAT2
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_RENAMEAT2],[
-AC_CHECK_FUNCS(renameat2,,)
-])
diff --git a/m4/ltp-splice.m4 b/m4/ltp-splice.m4
deleted file mode 100644
index 0ddaae0..0000000
--- a/m4/ltp-splice.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_SPLICE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_SPLICE],[
-AC_CHECK_FUNCS(splice,,)
-])
diff --git a/m4/ltp-sync_file_range.m4 b/m4/ltp-sync_file_range.m4
deleted file mode 100644
index b47a091..0000000
--- a/m4/ltp-sync_file_range.m4
+++ /dev/null
@@ -1,10 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2019 Linaro Limited. All rights reserved.
-
-dnl
-dnl LTP_CHECK_SYNC_FILE_RANGE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_SYNC_FILE_RANGE],[
-AC_CHECK_FUNCS(sync_file_range,,)
-])
diff --git a/m4/ltp-syncfs.m4 b/m4/ltp-syncfs.m4
deleted file mode 100644
index 836a055..0000000
--- a/m4/ltp-syncfs.m4
+++ /dev/null
@@ -1,10 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2019 Linaro Limited. All rights reserved.
-
-dnl
-dnl LTP_CHECK_SYNCFS
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_SYNCFS],[
-AC_CHECK_FUNCS(syncfs,,)
-])
diff --git a/m4/ltp-tee.m4 b/m4/ltp-tee.m4
deleted file mode 100644
index eb4a6b2..0000000
--- a/m4/ltp-tee.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software Foundation,
-dnl Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_TEE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_TEE],[
-AC_CHECK_FUNCS(tee,,)
-])
diff --git a/m4/ltp-unshare.m4 b/m4/ltp-unshare.m4
deleted file mode 100644
index de8da73..0000000
--- a/m4/ltp-unshare.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Cisco Systems Inc., 2009
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-dnl Author: Ngie Cooper <yaneurabeya@gmail.com>
-dnl
-
-dnl
-dnl LTP_CHECK_SYSCALL_UNSHARE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_SYSCALL_UNSHARE],[AC_CHECK_FUNCS_ONCE(unshare)])
diff --git a/m4/ltp-vmsplice.m4 b/m4/ltp-vmsplice.m4
deleted file mode 100644
index 6129cfe..0000000
--- a/m4/ltp-vmsplice.m4
+++ /dev/null
@@ -1,25 +0,0 @@
-dnl
-dnl Copyright (c) Linux Test Project, 2014
-dnl
-dnl This program is free software; you can redistribute it and/or modify
-dnl it under the terms of the GNU General Public License as published by
-dnl the Free Software Foundation; either version 2 of the License, or
-dnl (at your option) any later version.
-dnl
-dnl This program is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-dnl the GNU General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU General Public License
-dnl along with this program; if not, write to the Free Software
-dnl Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-dnl
-
-dnl
-dnl LTP_CHECK_SPLICE
-dnl ----------------------------
-dnl
-AC_DEFUN([LTP_CHECK_VMSPLICE],[
-AC_CHECK_FUNCS(vmsplice,,)
-])
--
1.8.3.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
@ 2019-03-28 9:36 ` Xiao Yang
2019-03-28 15:24 ` Petr Vorel
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2 siblings, 1 reply; 12+ messages in thread
From: Xiao Yang @ 2019-03-28 9:36 UTC (permalink / raw)
To: ltp
Don't alway skip libc stime() for Android, because bionic(Android libc)
may implement it in the future.
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
m4/ltp-libc-funcs.m4 | 2 +-
testcases/kernel/syscalls/stime/stime_var.h | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/m4/ltp-libc-funcs.m4 b/m4/ltp-libc-funcs.m4
index ebbe2c9..122073f 100644
--- a/m4/ltp-libc-funcs.m4
+++ b/m4/ltp-libc-funcs.m4
@@ -10,5 +10,5 @@ dnl
AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
-splice syncfs sync_file_range tee unshare vmsplice,,)
+splice stime syncfs sync_file_range tee unshare vmsplice,,)
])
diff --git a/testcases/kernel/syscalls/stime/stime_var.h b/testcases/kernel/syscalls/stime/stime_var.h
index b014f0a..48d46b3 100644
--- a/testcases/kernel/syscalls/stime/stime_var.h
+++ b/testcases/kernel/syscalls/stime/stime_var.h
@@ -8,6 +8,7 @@
#define STIME_VAR__
#include <sys/time.h>
+#include "config.h"
#include "lapi/syscalls.h"
#define TEST_VARIANTS 3
@@ -16,8 +17,8 @@ static int do_stime(time_t *ntime)
{
switch (tst_variant) {
case 0:
-#ifdef __ANDROID__
- tst_brk(TCONF, "libc stime() is not implemented on Android");
+#ifndef HAVE_STIME
+ tst_brk(TCONF, "libc stime() is not implemented");
#else
return stime(ntime);
#endif
--
1.8.3.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
@ 2019-03-28 14:56 ` Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2 siblings, 0 replies; 12+ messages in thread
From: Petr Vorel @ 2019-03-28 14:56 UTC (permalink / raw)
To: ltp
Hi Xiao,
> Use LTP_CHECK_LIBC_FUNCS if only libc implementations need to be checked.
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
IMHO good idea.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
@ 2019-03-28 15:12 ` Petr Vorel
2019-04-04 10:31 ` Cyril Hrubis
2 siblings, 1 reply; 12+ messages in thread
From: Petr Vorel @ 2019-03-28 15:12 UTC (permalink / raw)
To: ltp
Hi Xiao,
...
> +++ b/m4/ltp-libc-funcs.m4
> @@ -0,0 +1,14 @@
> +dnl SPDX-License-Identifier: GPL-2.0-or-later
> +dnl Copyright (c) 2019 Fujitsu Ltd.
> +dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> +
> +dnl
> +dnl LTP_CHECK_LIBC_FUNCS
> +dnl ----------------------------
> +dnl
> +
> +AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> +AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> +mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> +splice syncfs sync_file_range tee unshare vmsplice,,)
> +])
Note about formatting: maybe it'd be easier to edit the file if each function
was on separate line.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
@ 2019-03-28 15:24 ` Petr Vorel
2019-03-29 3:19 ` Xiao Yang
0 siblings, 1 reply; 12+ messages in thread
From: Petr Vorel @ 2019-03-28 15:24 UTC (permalink / raw)
To: ltp
Hi Xiao, Steve,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> diff --git a/m4/ltp-libc-funcs.m4 b/m4/ltp-libc-funcs.m4
> index ebbe2c9..122073f 100644
> --- a/m4/ltp-libc-funcs.m4
> +++ b/m4/ltp-libc-funcs.m4
> @@ -10,5 +10,5 @@ dnl
> AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> -splice syncfs sync_file_range tee unshare vmsplice,,)
> +splice stime syncfs sync_file_range tee unshare vmsplice,,)
I hope AC_CHECK_FUNCS is working well on cross compilation (I guess so, but
noticed some problems on autotools with PKG_CHECK_MODULES, but that's different
as it's using pkg-config).
...
> diff --git a/testcases/kernel/syscalls/stime/stime_var.h b/testcases/kernel/syscalls/stime/stime_var.h
...
> -#ifdef __ANDROID__
> - tst_brk(TCONF, "libc stime() is not implemented on Android");
> +#ifndef HAVE_STIME
> + tst_brk(TCONF, "libc stime() is not implemented");
> #else
> return stime(ntime);
> #endif
Kind regards,
Petr
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically
2019-03-28 15:24 ` Petr Vorel
@ 2019-03-29 3:19 ` Xiao Yang
2019-04-17 17:10 ` Petr Vorel
0 siblings, 1 reply; 12+ messages in thread
From: Xiao Yang @ 2019-03-29 3:19 UTC (permalink / raw)
To: ltp
On 2019/03/28 23:24, Petr Vorel wrote:
> Hi Xiao, Steve,
>
> Reviewed-by: Petr Vorel<pvorel@suse.cz>
>
>> diff --git a/m4/ltp-libc-funcs.m4 b/m4/ltp-libc-funcs.m4
>> index ebbe2c9..122073f 100644
>> --- a/m4/ltp-libc-funcs.m4
>> +++ b/m4/ltp-libc-funcs.m4
>> @@ -10,5 +10,5 @@ dnl
>> AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
>> AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
>> mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
>> -splice syncfs sync_file_range tee unshare vmsplice,,)
>> +splice stime syncfs sync_file_range tee unshare vmsplice,,)
> I hope AC_CHECK_FUNCS is working well on cross compilation (I guess so, but
> noticed some problems on autotools with PKG_CHECK_MODULES, but that's different
> as it's using pkg-config).
> ...
Hi Petr,
I wonder the detail of your problems, so could you provide the
operations and error messages?
Best Regards,
Xiao Yang
>> diff --git a/testcases/kernel/syscalls/stime/stime_var.h b/testcases/kernel/syscalls/stime/stime_var.h
> ...
>> -#ifdef __ANDROID__
>> - tst_brk(TCONF, "libc stime() is not implemented on Android");
>> +#ifndef HAVE_STIME
>> + tst_brk(TCONF, "libc stime() is not implemented");
>> #else
>> return stime(ntime);
>> #endif
>
> Kind regards,
> Petr
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-03-28 15:12 ` Petr Vorel
@ 2019-04-04 10:31 ` Cyril Hrubis
2019-04-04 11:58 ` Petr Vorel
0 siblings, 1 reply; 12+ messages in thread
From: Cyril Hrubis @ 2019-04-04 10:31 UTC (permalink / raw)
To: ltp
Hi!
> > +++ b/m4/ltp-libc-funcs.m4
> > @@ -0,0 +1,14 @@
> > +dnl SPDX-License-Identifier: GPL-2.0-or-later
> > +dnl Copyright (c) 2019 Fujitsu Ltd.
> > +dnl Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> > +
> > +dnl
> > +dnl LTP_CHECK_LIBC_FUNCS
> > +dnl ----------------------------
> > +dnl
> > +
> > +AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> > +AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> > +mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> > +splice syncfs sync_file_range tee unshare vmsplice,,)
> > +])
> Note about formatting: maybe it'd be easier to edit the file if each function
> was on separate line.
Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
step would be moving these there as well.
Other than that this is a great cleanup, thanks for doing this.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-04-04 10:31 ` Cyril Hrubis
@ 2019-04-04 11:58 ` Petr Vorel
2019-04-05 3:15 ` Xiao Yang
0 siblings, 1 reply; 12+ messages in thread
From: Petr Vorel @ 2019-04-04 11:58 UTC (permalink / raw)
To: ltp
Hi,
> > Note about formatting: maybe it'd be easier to edit the file if each function
> > was on separate line.
> Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
> step would be moving these there as well.
+1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
> Other than that this is a great cleanup, thanks for doing this.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-04-04 11:58 ` Petr Vorel
@ 2019-04-05 3:15 ` Xiao Yang
2019-04-05 7:13 ` Petr Vorel
0 siblings, 1 reply; 12+ messages in thread
From: Xiao Yang @ 2019-04-05 3:15 UTC (permalink / raw)
To: ltp
Hi Petr, Cyril
Thanks for your comment.
I will send v2 patch as you suggested. :-)
Best Regards,
Xiao Yang
On 2019/04/04 19:58, Petr Vorel wrote:
> Hi,
>
>>> Note about formatting: maybe it'd be easier to edit the file if each function
>>> was on separate line.
>> Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
>> step would be moving these there as well.
> +1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
>
>> Other than that this is a great cleanup, thanks for doing this.
> Kind regards,
> Petr
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-04-05 3:15 ` Xiao Yang
@ 2019-04-05 7:13 ` Petr Vorel
2019-04-05 7:32 ` Xiao Yang
0 siblings, 1 reply; 12+ messages in thread
From: Petr Vorel @ 2019-04-05 7:13 UTC (permalink / raw)
To: ltp
Hi Xiao, Cyril,
> Thanks for your comment.
> I will send v2 patch as you suggested. :-)
v2 has LTP_CHECK_LIBC_FUNCS in m4/ltp-libc-funcs.m4.
IMHO it'd be better to have simple AC_CHECK_FUNCS() in configure.ac, i.e. the
same way we handle AC_CHECK_HEADERS(). It might not be good to mix configure.ac
and m4/ltp-*.m4, but I guess general functions like this is easier to find in
configure.ac than in some of m4/ltp-*.m4.
Kind regards,
Petr
> Best Regards,
> Xiao Yang
> On 2019/04/04 19:58, Petr Vorel wrote:
> > Hi,
> > > > Note about formatting: maybe it'd be easier to edit the file if each function
> > > > was on separate line.
> > > Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
> > > step would be moving these there as well.
> > +1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
> > > Other than that this is a great cleanup, thanks for doing this.
> > Kind regards,
> > Petr
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations
2019-04-05 7:13 ` Petr Vorel
@ 2019-04-05 7:32 ` Xiao Yang
0 siblings, 0 replies; 12+ messages in thread
From: Xiao Yang @ 2019-04-05 7:32 UTC (permalink / raw)
To: ltp
On 2019/04/05 15:13, Petr Vorel wrote:
> Hi Xiao, Cyril,
>
>> Thanks for your comment.
>> I will send v2 patch as you suggested. :-)
> v2 has LTP_CHECK_LIBC_FUNCS in m4/ltp-libc-funcs.m4.
> IMHO it'd be better to have simple AC_CHECK_FUNCS() in configure.ac, i.e. the
> same way we handle AC_CHECK_HEADERS(). It might not be good to mix configure.ac
> and m4/ltp-*.m4, but I guess general functions like this is easier to find in
> configure.ac than in some of m4/ltp-*.m4.
Hi Petr,
Sorry, I missed your last comment.
It seems easier to remove LTP_CHECK_LIBC_FUNCS directly.
I will send v3 patch soon.
Best Regards,
Xiao Yang
>
> Kind regards,
> Petr
>
>> Best Regards,
>> Xiao Yang
>> On 2019/04/04 19:58, Petr Vorel wrote:
>>> Hi,
>>>>> Note about formatting: maybe it'd be easier to edit the file if each function
>>>>> was on separate line.
>>>> Agreed, also we have AC_CHECK_FUNCS() in the configure.ac so the best
>>>> step would be moving these there as well.
>>> +1 (easier to find general things like this in configure.ac than in m4/ltp-*.m4.
>>>> Other than that this is a great cleanup, thanks for doing this.
>>> Kind regards,
>>> Petr
>
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically
2019-03-29 3:19 ` Xiao Yang
@ 2019-04-17 17:10 ` Petr Vorel
0 siblings, 0 replies; 12+ messages in thread
From: Petr Vorel @ 2019-04-17 17:10 UTC (permalink / raw)
To: ltp
Hi Xiao,
...
> > > +++ b/m4/ltp-libc-funcs.m4
> > > @@ -10,5 +10,5 @@ dnl
> > > AC_DEFUN([LTP_CHECK_LIBC_FUNCS],[
> > > AC_CHECK_FUNCS(epoll_pwait execveat fallocate fchownat fstatat kcmp mkdirat \
> > > mknodat openat preadv preadv2 pwritev pwritev2 readlinkat renameat renameat2 \
> > > -splice syncfs sync_file_range tee unshare vmsplice,,)
> > > +splice stime syncfs sync_file_range tee unshare vmsplice,,)
> > I hope AC_CHECK_FUNCS is working well on cross compilation (I guess so, but
> > noticed some problems on autotools with PKG_CHECK_MODULES, but that's different
> > as it's using pkg-config).
> > ...
> Hi Petr,
> I wonder the detail of your problems, so could you provide the operations
> and error messages?
autotools fails preadv and pwritev detection with AC_CHECK_FUNCS for android
build [1]. Not sure if it's a problem of my setup or autotools bug.
> Best Regards,
> Xiao Yang
Kind regards,
Petr
[1] http://lists.linux.it/pipermail/ltp/2019-April/011722.html
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-04-17 17:10 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 9:36 [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Xiao Yang
2019-03-28 9:36 ` [LTP] [PATCH 2/2] syscalls/stime: detect if libc stime() is implemented dynamically Xiao Yang
2019-03-28 15:24 ` Petr Vorel
2019-03-29 3:19 ` Xiao Yang
2019-04-17 17:10 ` Petr Vorel
2019-03-28 14:56 ` [LTP] [PATCH 1/2] m4: Use common LTP_CHECK_LIBC_FUNCS to check libc implementations Petr Vorel
2019-03-28 15:12 ` Petr Vorel
2019-04-04 10:31 ` Cyril Hrubis
2019-04-04 11:58 ` Petr Vorel
2019-04-05 3:15 ` Xiao Yang
2019-04-05 7:13 ` Petr Vorel
2019-04-05 7:32 ` Xiao Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.