From: Wen Yang <wen.yang99@zte.com.cn> To: linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Wen Yang <wen.yang99@zte.com.cn>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Viresh Kumar <viresh.kumar@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/7] cpufreq: imx6q: fix possible object reference leak Date: Mon, 1 Apr 2019 09:37:49 +0800 [thread overview] Message-ID: <1554082674-2049-3-git-send-email-wen.yang99@zte.com.cn> (raw) In-Reply-To: <1554082674-2049-1-git-send-email-wen.yang99@zte.com.cn> The call to of_node_get returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/cpufreq/imx6q-cpufreq.c:391:4-10: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. ./drivers/cpufreq/imx6q-cpufreq.c:395:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/cpufreq/imx6q-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index a4ff09f..3e17560 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -388,11 +388,11 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) ret = imx6ul_opp_check_speed_grading(cpu_dev); if (ret) { if (ret == -EPROBE_DEFER) - return ret; + goto put_node; dev_err(cpu_dev, "failed to read ocotp: %d\n", ret); - return ret; + goto put_node; } } else { imx6q_opp_check_speed_grading(cpu_dev); -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Wen Yang <wen.yang99@zte.com.cn> To: linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Fabio Estevam <festevam@gmail.com>, linux-pm@vger.kernel.org, Viresh Kumar <viresh.kumar@linaro.org>, Sascha Hauer <s.hauer@pengutronix.de>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, NXP Linux Team <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Shawn Guo <shawnguo@kernel.org>, Wen Yang <wen.yang99@zte.com.cn>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/7] cpufreq: imx6q: fix possible object reference leak Date: Mon, 1 Apr 2019 09:37:49 +0800 [thread overview] Message-ID: <1554082674-2049-3-git-send-email-wen.yang99@zte.com.cn> (raw) In-Reply-To: <1554082674-2049-1-git-send-email-wen.yang99@zte.com.cn> The call to of_node_get returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./drivers/cpufreq/imx6q-cpufreq.c:391:4-10: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. ./drivers/cpufreq/imx6q-cpufreq.c:395:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 348, but without a corresponding object release within this function. Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/cpufreq/imx6q-cpufreq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index a4ff09f..3e17560 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -388,11 +388,11 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) ret = imx6ul_opp_check_speed_grading(cpu_dev); if (ret) { if (ret == -EPROBE_DEFER) - return ret; + goto put_node; dev_err(cpu_dev, "failed to read ocotp: %d\n", ret); - return ret; + goto put_node; } } else { imx6q_opp_check_speed_grading(cpu_dev); -- 2.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-01 1:38 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-01 1:37 [PATCH 0/7] fix possible object reference leaks in cpufreq Wen Yang 2019-04-01 1:37 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Wen Yang 2019-04-01 1:37 ` Wen Yang 2019-04-01 1:37 ` Wen Yang 2019-04-02 13:54 ` [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-02 13:54 ` Markus Elfring 2019-04-08 10:21 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Viresh Kumar 2019-04-08 10:21 ` Viresh Kumar 2019-04-01 1:37 ` Wen Yang [this message] 2019-04-01 1:37 ` [PATCH 2/7] cpufreq: imx6q: " Wen Yang 2019-04-01 1:37 ` [PATCH 3/7] cpufreq: kirkwood: " Wen Yang 2019-04-03 13:17 ` [3/7] " Markus Elfring 2019-04-03 13:17 ` Markus Elfring 2019-04-01 1:37 ` [PATCH 4/7] cpufreq: maple: " Wen Yang 2019-04-03 13:50 ` [4/7] cpufreq: maple: Checking implementation of maple_cpufreq_init() Markus Elfring 2019-04-03 13:50 ` Markus Elfring 2019-04-01 1:37 ` [PATCH 5/7] cpufreq/pasemi: fix possible object reference leak Wen Yang 2019-04-01 1:37 ` Wen Yang 2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring 2019-04-03 14:23 ` Markus Elfring 2019-04-03 14:23 ` Markus Elfring 2019-04-03 15:31 ` Dan Carpenter 2019-04-03 15:31 ` Dan Carpenter 2019-04-03 15:31 ` Dan Carpenter 2019-04-01 1:37 ` [PATCH 6/7] cpufreq: pmac32: fix possible object reference leak Wen Yang 2019-04-01 1:37 ` Wen Yang 2019-04-01 1:37 ` [PATCH 7/7] cpufreq: ppc_cbe: " Wen Yang 2019-04-02 10:43 ` Markus Elfring 2019-04-02 10:43 ` Markus Elfring 2019-04-02 10:50 ` Julia Lawall 2019-04-02 10:50 ` Julia Lawall 2019-04-02 12:50 ` Markus Elfring 2019-04-02 12:50 ` Markus Elfring 2019-04-02 13:15 ` Julia Lawall 2019-04-02 13:15 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1554082674-2049-3-git-send-email-wen.yang99@zte.com.cn \ --to=wen.yang99@zte.com.cn \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=viresh.kumar@linaro.org \ --cc=wang.yi59@zte.com.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.