All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH v3] arm/mach-at91/pm : fix possible object reference leak
  2019-04-01 16:26 ` Peng Hao
@ 2019-04-01  8:51   ` Mukesh Ojha
  -1 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-01  8:51 UTC (permalink / raw)
  To: Peng Hao, ludovic.desroches, nicolas.ferre, alexandre.belloni
  Cc: linux-kernel, linux-arm-kernel


On 4/1/2019 9:56 PM, Peng Hao wrote:
> of_find_device_by_node() takes a reference to the struct device
> when it finds a match via get_device. When returning error we should
> call put_device.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>   arch/arm/mach-at91/pm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 51e808a..38511a5 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -591,13 +591,13 @@ static int __init at91_pm_backup_init(void)
>   
>   	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
>   	if (!np)
> -		goto securam_fail;
> +		goto securam_fail_no_get;


s/securam_fail_no_get/securam_fail_no_ref_dev

otherwise looks good.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh


>   
>   	pdev = of_find_device_by_node(np);
>   	of_node_put(np);
>   	if (!pdev) {
>   		pr_warn("%s: failed to find securam device!\n", __func__);
> -		goto securam_fail;
> +		goto securam_fail_no_get;
>   	}
>   
>   	sram_pool = gen_pool_get(&pdev->dev, NULL);
> @@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void)
>   	return 0;
>   
>   securam_fail:
> +	put_device(&pdev->dev);
> +securam_fail_no_get:
>   	iounmap(pm_data.sfrbu);
>   	pm_data.sfrbu = NULL;
>   	return ret;

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v3] arm/mach-at91/pm : fix possible object reference leak
@ 2019-04-01  8:51   ` Mukesh Ojha
  0 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-01  8:51 UTC (permalink / raw)
  To: Peng Hao, ludovic.desroches, nicolas.ferre, alexandre.belloni
  Cc: linux-kernel, linux-arm-kernel


On 4/1/2019 9:56 PM, Peng Hao wrote:
> of_find_device_by_node() takes a reference to the struct device
> when it finds a match via get_device. When returning error we should
> call put_device.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>   arch/arm/mach-at91/pm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 51e808a..38511a5 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -591,13 +591,13 @@ static int __init at91_pm_backup_init(void)
>   
>   	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
>   	if (!np)
> -		goto securam_fail;
> +		goto securam_fail_no_get;


s/securam_fail_no_get/securam_fail_no_ref_dev

otherwise looks good.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh


>   
>   	pdev = of_find_device_by_node(np);
>   	of_node_put(np);
>   	if (!pdev) {
>   		pr_warn("%s: failed to find securam device!\n", __func__);
> -		goto securam_fail;
> +		goto securam_fail_no_get;
>   	}
>   
>   	sram_pool = gen_pool_get(&pdev->dev, NULL);
> @@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void)
>   	return 0;
>   
>   securam_fail:
> +	put_device(&pdev->dev);
> +securam_fail_no_get:
>   	iounmap(pm_data.sfrbu);
>   	pm_data.sfrbu = NULL;
>   	return ret;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH v3] arm/mach-at91/pm : fix possible object reference leak
@ 2019-04-01 16:26 ` Peng Hao
  0 siblings, 0 replies; 4+ messages in thread
From: Peng Hao @ 2019-04-01 16:26 UTC (permalink / raw)
  To: ludovic.desroches, nicolas.ferre, alexandre.belloni, mojha
  Cc: linux-kernel, linux-arm-kernel, Peng Hao

of_find_device_by_node() takes a reference to the struct device
when it finds a match via get_device. When returning error we should
call put_device.

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 arch/arm/mach-at91/pm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index 51e808a..38511a5 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -591,13 +591,13 @@ static int __init at91_pm_backup_init(void)
 
 	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
 	if (!np)
-		goto securam_fail;
+		goto securam_fail_no_get;
 
 	pdev = of_find_device_by_node(np);
 	of_node_put(np);
 	if (!pdev) {
 		pr_warn("%s: failed to find securam device!\n", __func__);
-		goto securam_fail;
+		goto securam_fail_no_get;
 	}
 
 	sram_pool = gen_pool_get(&pdev->dev, NULL);
@@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void)
 	return 0;
 
 securam_fail:
+	put_device(&pdev->dev);
+securam_fail_no_get:
 	iounmap(pm_data.sfrbu);
 	pm_data.sfrbu = NULL;
 	return ret;
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v3] arm/mach-at91/pm : fix possible object reference leak
@ 2019-04-01 16:26 ` Peng Hao
  0 siblings, 0 replies; 4+ messages in thread
From: Peng Hao @ 2019-04-01 16:26 UTC (permalink / raw)
  To: ludovic.desroches, nicolas.ferre, alexandre.belloni, mojha
  Cc: Peng Hao, linux-kernel, linux-arm-kernel

of_find_device_by_node() takes a reference to the struct device
when it finds a match via get_device. When returning error we should
call put_device.

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 arch/arm/mach-at91/pm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
index 51e808a..38511a5 100644
--- a/arch/arm/mach-at91/pm.c
+++ b/arch/arm/mach-at91/pm.c
@@ -591,13 +591,13 @@ static int __init at91_pm_backup_init(void)
 
 	np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-securam");
 	if (!np)
-		goto securam_fail;
+		goto securam_fail_no_get;
 
 	pdev = of_find_device_by_node(np);
 	of_node_put(np);
 	if (!pdev) {
 		pr_warn("%s: failed to find securam device!\n", __func__);
-		goto securam_fail;
+		goto securam_fail_no_get;
 	}
 
 	sram_pool = gen_pool_get(&pdev->dev, NULL);
@@ -620,6 +620,8 @@ static int __init at91_pm_backup_init(void)
 	return 0;
 
 securam_fail:
+	put_device(&pdev->dev);
+securam_fail_no_get:
 	iounmap(pm_data.sfrbu);
 	pm_data.sfrbu = NULL;
 	return ret;
-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-01  8:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 16:26 [PATCH v3] arm/mach-at91/pm : fix possible object reference leak Peng Hao
2019-04-01 16:26 ` Peng Hao
2019-04-01  8:51 ` Mukesh Ojha
2019-04-01  8:51   ` Mukesh Ojha

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.