All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/3] sim: added error handling in set slot callback
@ 2019-04-02  6:25 Antara Borwankar
  2019-04-02 15:27 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Antara Borwankar @ 2019-04-02  6:25 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Adding the handling of error when the driver returns
CME ERROR:4.

This error will be returned for non xmm vendor modems
using ifxmodem driver for sim.
---
 src/sim.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sim.c b/src/sim.c
index 9f0183f..a178cb8 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -680,7 +680,7 @@ static void sim_set_slot_callback(const struct ofono_error *error, void *data)
 
 		sim->pending_active_card_slot = sim->active_card_slot;
 
-		reply = __ofono_error_failed(sim->pending);
+		reply = __ofono_error_from_error(error, sim->pending);
 		__ofono_dbus_pending_reply(&sim->pending, reply);
 
 		return;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/3] sim: added error handling in set slot callback
  2019-04-02  6:25 [PATCH 3/3] sim: added error handling in set slot callback Antara Borwankar
@ 2019-04-02 15:27 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2019-04-02 15:27 UTC (permalink / raw)
  To: ofono

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Hi Antara,

On 04/02/2019 01:25 AM, Antara Borwankar wrote:
> Adding the handling of error when the driver returns
> CME ERROR:4.
> 
> This error will be returned for non xmm vendor modems
> using ifxmodem driver for sim.
> ---
>   src/sim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-02 15:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-02  6:25 [PATCH 3/3] sim: added error handling in set slot callback Antara Borwankar
2019-04-02 15:27 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.