[PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

[PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

[Singh, Sandeep]

From: Sandeep Singh <sandeep.singh@amd.com>

Some of the AMD reference boards used single GPIO line for
multiple devices. So added IRQF_SHARED flag in amd pinctrl driver.


Signed-off-by: Sandeep Singh <Sandeep.Singh@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
---
 drivers/pinctrl/pinctrl-amd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 2a7d638..d834c1e 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -930,8 +930,8 @@ static int amd_gpio_probe(struct platform_device *pdev)
 		goto out2;
 	}
 
-	ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler, 0,
-			       KBUILD_MODNAME, gpio_dev);
+	ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
+			       IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
 	if (ret)
 		goto out2;
 
-- 
2.7.4

[PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

[Singh, Sandeep]

From: Sandeep Singh <sandeep.singh@amd.com>

Some of the AMD reference boards used single GPIO line for
multiple devices. So added IRQF_SHARED flag in amd pinctrl driver.


Signed-off-by: Sandeep Singh <Sandeep.Singh@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
---
 drivers/pinctrl/pinctrl-amd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 2a7d638..d834c1e 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -930,8 +930,8 @@ static int amd_gpio_probe(struct platform_device *pdev)
 		goto out2;
 	}
 
-	ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler, 0,
-			       KBUILD_MODNAME, gpio_dev);
+	ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
+			       IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
 	if (ret)
 		goto out2;
 
-- 
2.7.4

Re: [PATCH] pinctrl: Added IRQF_SHARED flag for amd-pinctrl driver

[Linus Walleij]

On Thu, Apr 4, 2019 at 3:16 PM Singh, Sandeep <Sandeep.Singh@amd.com> wrote:

> From: Sandeep Singh <sandeep.singh@amd.com>
>
> Some of the AMD reference boards used single GPIO line for
> multiple devices. So added IRQF_SHARED flag in amd pinctrl driver.
>
>
> Signed-off-by: Sandeep Singh <Sandeep.Singh@amd.com>
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>

OK makes perfect sense so patch applied.

The patch itself looked funny when I tried to apply it but
as it's just a oneliner I managed to fix it up.

Yours,
Linus Walleij