[meta-python][PATCH] python-cryptography: Add -pthread to link flags

[meta-python][PATCH] python-cryptography: Add -pthread to link flags

[chris.d.garren]

From: Chris Garren <cdgarren@indesign-llc.com>

This builds openssl which needs pthread_atfork(),
but it's not linked which results in runtime errors.

Signed-off-by: Chris Garren <cdgarren@indesign-llc.com>
---
 meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb b/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
index 9c2f884..ce7b5ab 100644
--- a/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
+++ b/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
@@ -1,6 +1,8 @@
 inherit pypi setuptools
 require python-cryptography.inc
 
+LDSHARED += "-pthread"
+
 SRC_URI += " \
     file://run-ptest \
 "
-- 
2.7.4

Re: [meta-python][PATCH] python-cryptography: Add -pthread to link flags

[Khem Raj]

On Fri, Apr 5, 2019 at 11:00 AM <chris.d.garren@gmail.com> wrote:
>
> From: Chris Garren <cdgarren@indesign-llc.com>
>
> This builds openssl which needs pthread_atfork(),
> but it's not linked which results in runtime errors.
>
> Signed-off-by: Chris Garren <cdgarren@indesign-llc.com>
> ---
>  meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb | 2 ++

We are on 2.4.1 on master, so please rebase it, secondly do we need it
for python3
recipe as well if so then move the fix to python-cryptography.inc

>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb b/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
> index 9c2f884..ce7b5ab 100644
> --- a/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
> +++ b/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
> @@ -1,6 +1,8 @@
>  inherit pypi setuptools
>  require python-cryptography.inc
>
> +LDSHARED += "-pthread"
> +
>  SRC_URI += " \
>      file://run-ptest \
>  "
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-python][PATCH] python-cryptography: Add -pthread to link flags

[Chris Garren]

It looks like it was already added to the python3 recipe, so yes, it should
probably be in the .inc file. I will revise.

On Fri, Apr 5, 2019 at 4:34 PM Khem Raj <raj.khem@gmail.com> wrote:

> On Fri, Apr 5, 2019 at 11:00 AM <chris.d.garren@gmail.com> wrote:
> >
> > From: Chris Garren <cdgarren@indesign-llc.com>
> >
> > This builds openssl which needs pthread_atfork(),
> > but it's not linked which results in runtime errors.
> >
> > Signed-off-by: Chris Garren <cdgarren@indesign-llc.com>
> > ---
> >  meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb | 2 ++
>
> We are on 2.4.1 on master, so please rebase it, secondly do we need it
> for python3
> recipe as well if so then move the fix to python-cryptography.inc
>
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta-python/recipes-devtools/python/
> python-cryptography_2.1.4.bb b/meta-python/recipes-devtools/python/
> python-cryptography_2.1.4.bb
> > index 9c2f884..ce7b5ab 100644
> > --- a/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
> > +++ b/meta-python/recipes-devtools/python/python-cryptography_2.1.4.bb
> > @@ -1,6 +1,8 @@
> >  inherit pypi setuptools
> >  require python-cryptography.inc
> >
> > +LDSHARED += "-pthread"
> > +
> >  SRC_URI += " \
> >      file://run-ptest \
> >  "
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>