From: Wesley Sheng <wesley.sheng@microchip.com> To: <kurt.schwemmer@microsemi.com>, <logang@deltatee.com>, <jdmason@kudzu.us>, <dave.jiang@intel.com>, <allenbh@gmail.com>, <linux-pci@vger.kernel.org>, <linux-ntb@googlegroups.com>, <linux-kernel@vger.kernel.org> Cc: <wesleyshenggit@sina.com>, <wesley.sheng@microchip.com>, <kelvin.cao@microchip.com> Subject: [PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function Date: Mon, 8 Apr 2019 22:45:20 +0800 [thread overview] Message-ID: <1554734722-7833-2-git-send-email-wesley.sheng@microchip.com> (raw) In-Reply-To: <1554734722-7833-1-git-send-email-wesley.sheng@microchip.com> From: Joey Zhang <joey.zhang@microchip.com> When a re-initialization is caused by a link event, the driver will re-setup the shared memory window. But at that time, the shared memory is still valid, and it's unnecessary to free, reallocate and then initialize it again. We only need to reconfigure the hardware registers. Remove the redundant steps from switchtec_ntb_reinit_peer() function. Signed-off-by: Joey Zhang <joey.zhang@microchip.com> Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com> --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c index d905d36..947ed0b 100644 --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c @@ -1457,10 +1457,13 @@ static void switchtec_ntb_deinit_db_msg_irq(struct switchtec_ntb *sndev) static int switchtec_ntb_reinit_peer(struct switchtec_ntb *sndev) { - dev_info(&sndev->stdev->dev, "peer reinitialized\n"); - switchtec_ntb_deinit_shared_mw(sndev); - switchtec_ntb_init_mw(sndev); - return switchtec_ntb_init_shared_mw(sndev); + int rc; + + dev_info(&sndev->stdev->dev, "reinitialize shared memory window\n"); + rc = config_rsvd_lut_win(sndev, sndev->mmio_peer_ctrl, 0, + sndev->self_partition, + sndev->self_shared_dma); + return rc; } static int switchtec_ntb_add(struct device *dev, -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Wesley Sheng <wesley.sheng@microchip.com> To: kurt.schwemmer@microsemi.com, logang@deltatee.com, jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com, linux-pci@vger.kernel.org, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org Cc: wesleyshenggit@sina.com, wesley.sheng@microchip.com, kelvin.cao@microchip.com Subject: [PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function Date: Mon, 8 Apr 2019 22:45:20 +0800 [thread overview] Message-ID: <1554734722-7833-2-git-send-email-wesley.sheng@microchip.com> (raw) In-Reply-To: <1554734722-7833-1-git-send-email-wesley.sheng@microchip.com> From: Joey Zhang <joey.zhang@microchip.com> When a re-initialization is caused by a link event, the driver will re-setup the shared memory window. But at that time, the shared memory is still valid, and it's unnecessary to free, reallocate and then initialize it again. We only need to reconfigure the hardware registers. Remove the redundant steps from switchtec_ntb_reinit_peer() function. Signed-off-by: Joey Zhang <joey.zhang@microchip.com> Signed-off-by: Wesley Sheng <wesley.sheng@microchip.com> --- drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c index d905d36..947ed0b 100644 --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c @@ -1457,10 +1457,13 @@ static void switchtec_ntb_deinit_db_msg_irq(struct switchtec_ntb *sndev) static int switchtec_ntb_reinit_peer(struct switchtec_ntb *sndev) { - dev_info(&sndev->stdev->dev, "peer reinitialized\n"); - switchtec_ntb_deinit_shared_mw(sndev); - switchtec_ntb_init_mw(sndev); - return switchtec_ntb_init_shared_mw(sndev); + int rc; + + dev_info(&sndev->stdev->dev, "reinitialize shared memory window\n"); + rc = config_rsvd_lut_win(sndev, sndev->mmio_peer_ctrl, 0, + sndev->self_partition, + sndev->self_shared_dma); + return rc; } static int switchtec_ntb_add(struct device *dev, -- 2.7.4
next prev parent reply other threads:[~2019-04-08 6:46 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-08 14:45 [PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec Wesley Sheng 2019-04-08 14:45 ` Wesley Sheng 2019-04-08 14:45 ` Wesley Sheng [this message] 2019-04-08 14:45 ` [PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function Wesley Sheng 2019-04-08 14:45 ` [PATCH 2/3] ntb_hw_switchtec: Skip unnecessary re-setup of shared memory window for crosslink case Wesley Sheng 2019-04-08 14:45 ` Wesley Sheng 2019-04-08 14:45 ` [PATCH 3/3] ntb_hw_switchtec: Fix setup MW with failure bug Wesley Sheng 2019-04-08 14:45 ` Wesley Sheng 2019-04-08 16:00 ` [PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec Logan Gunthorpe 2019-04-22 14:42 Wesley Sheng 2019-04-22 14:42 ` [PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function Wesley Sheng 2019-04-22 14:42 ` Wesley Sheng 2019-06-06 7:09 [PATCH 0/3] Redundant steps removal and bug fix of ntb_hw_switchtec Kelvin Cao 2019-06-06 7:09 ` [PATCH 1/3] ntb_hw_switchtec: Remove redundant steps of switchtec_ntb_reinit_peer() function Kelvin Cao 2019-06-06 7:09 ` Kelvin Cao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1554734722-7833-2-git-send-email-wesley.sheng@microchip.com \ --to=wesley.sheng@microchip.com \ --cc=allenbh@gmail.com \ --cc=dave.jiang@intel.com \ --cc=jdmason@kudzu.us \ --cc=kelvin.cao@microchip.com \ --cc=kurt.schwemmer@microsemi.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-ntb@googlegroups.com \ --cc=linux-pci@vger.kernel.org \ --cc=logang@deltatee.com \ --cc=wesleyshenggit@sina.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.