From: Stephen Boyd <sboyd@kernel.org> To: Nicholas Mc Guire <hofrat@opentech.at>, Ulf Hansson <ulf.hansson@linaro.org> Cc: Michael Turquette <mturquette@baylibre.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire <hofrat@opentech.at> Subject: Re: [PATCH RFC] clk: ux500: add range to usleep_range Date: Wed, 10 Apr 2019 15:53:51 -0700 [thread overview] Message-ID: <155493683173.20095.12913107010666279046@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1554606804-29453-1-git-send-email-hofrat@opentech.at> Quoting Nicholas Mc Guire (2019-04-06 20:13:24) > Providing a range for usleep_range() allows the hrtimer subsystem to > coalesce timers - the delay is runtime configurable so a factor 2 > is taken to provide the range. > > Signed-off-by: Nicholas Mc Guire <hofrat@opentech.at> > --- I think this driver is in maintenance mode. I'll wait for Ulf to ack or review this change before applying. > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c > index 7c0403b..a1fa3fb 100644 > --- a/drivers/clk/ux500/clk-sysctrl.c > +++ b/drivers/clk/ux500/clk-sysctrl.c > @@ -42,7 +42,7 @@ static int clk_sysctrl_prepare(struct clk_hw *hw) > clk->reg_bits[0]); > > if (!ret && clk->enable_delay_us) > - usleep_range(clk->enable_delay_us, clk->enable_delay_us); > + usleep_range(clk->enable_delay_us, clk->enable_delay_us*2); Please add space around that multiply.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org> To: Nicholas Mc Guire <hofrat@opentech.at>, Ulf Hansson <ulf.hansson@linaro.org> Cc: Michael Turquette <mturquette@baylibre.com>, Nicholas Mc Guire <hofrat@opentech.at>, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] clk: ux500: add range to usleep_range Date: Wed, 10 Apr 2019 15:53:51 -0700 [thread overview] Message-ID: <155493683173.20095.12913107010666279046@swboyd.mtv.corp.google.com> (raw) In-Reply-To: <1554606804-29453-1-git-send-email-hofrat@opentech.at> Quoting Nicholas Mc Guire (2019-04-06 20:13:24) > Providing a range for usleep_range() allows the hrtimer subsystem to > coalesce timers - the delay is runtime configurable so a factor 2 > is taken to provide the range. > > Signed-off-by: Nicholas Mc Guire <hofrat@opentech.at> > --- I think this driver is in maintenance mode. I'll wait for Ulf to ack or review this change before applying. > diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c > index 7c0403b..a1fa3fb 100644 > --- a/drivers/clk/ux500/clk-sysctrl.c > +++ b/drivers/clk/ux500/clk-sysctrl.c > @@ -42,7 +42,7 @@ static int clk_sysctrl_prepare(struct clk_hw *hw) > clk->reg_bits[0]); > > if (!ret && clk->enable_delay_us) > - usleep_range(clk->enable_delay_us, clk->enable_delay_us); > + usleep_range(clk->enable_delay_us, clk->enable_delay_us*2); Please add space around that multiply. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-10 22:53 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-07 3:13 [PATCH RFC] clk: ux500: add range to usleep_range Nicholas Mc Guire 2019-04-07 3:13 ` Nicholas Mc Guire 2019-04-10 22:53 ` Stephen Boyd [this message] 2019-04-10 22:53 ` Stephen Boyd 2019-04-11 2:56 ` Nicholas Mc Guire 2019-04-11 2:56 ` Nicholas Mc Guire 2019-04-11 11:51 ` Joe Perches 2019-04-11 11:51 ` Joe Perches 2019-04-11 12:59 ` Nicholas Mc Guire 2019-04-11 12:59 ` Nicholas Mc Guire 2019-04-11 13:12 ` Joe Perches 2019-04-11 13:12 ` Joe Perches 2019-04-11 13:53 ` Nicholas Mc Guire 2019-04-11 13:53 ` Nicholas Mc Guire 2019-04-11 9:36 ` Ulf Hansson 2019-04-11 9:36 ` Ulf Hansson 2019-04-11 10:38 ` Nicholas Mc Guire 2019-04-11 10:38 ` Nicholas Mc Guire
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=155493683173.20095.12913107010666279046@swboyd.mtv.corp.google.com \ --to=sboyd@kernel.org \ --cc=hofrat@opentech.at \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.