* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-02-08 15:04 ` Matthias Brugger
0 siblings, 0 replies; 13+ messages in thread
From: Matthias Brugger @ 2019-02-08 15:04 UTC (permalink / raw)
To: Seiya Wang, Rob Herring, Mark Rutland
Cc: devicetree, srv_heupstream, linux-mediatek, linux-kernel,
linux-arm-kernel
On 09/01/2019 09:21, Seiya Wang wrote:
> This patch adds the device nodes of ARM Performance Monitor Uint
> for mt8173.
>
> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index 412ffd4d426b..44374c506a1c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -216,6 +216,20 @@
> };
> };
>
> + pmu_a53 {
> + compatible = "arm,cortex-a53-pmu";
> + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu0>, <&cpu1>;
> + };
> +
> + pmu_a72 {
> + compatible = "arm,cortex-a72-pmu";
> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-affinity = <&cpu2>, <&cpu3>;
> + };
There is no a72 but a a57 CPU present.
Typo?
Regards,
Matthias
> +
> psci {
> compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> method = "smc";
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
2019-02-08 15:04 ` Matthias Brugger
(?)
@ 2019-02-11 5:20 ` Seiya Wang
-1 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-02-11 5:20 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
MT8173 is actually using a72, not a57.
I will submit another patch for fixing it.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-02-11 5:20 ` Seiya Wang
0 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-02-11 5:20 UTC (permalink / raw)
To: Matthias Brugger
Cc: Mark Rutland, devicetree, srv_heupstream, linux-kernel,
Rob Herring, linux-mediatek, linux-arm-kernel
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
MT8173 is actually using a72, not a57.
I will submit another patch for fixing it.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-02-11 5:20 ` Seiya Wang
0 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-02-11 5:20 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
MT8173 is actually using a72, not a57.
I will submit another patch for fixing it.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
2019-02-08 15:04 ` Matthias Brugger
(?)
@ 2019-04-16 8:35 ` Seiya Wang
-1 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-04-16 8:35 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
Please also apply this (if no problems) since we have changed to ca72.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-04-16 8:35 ` Seiya Wang
0 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-04-16 8:35 UTC (permalink / raw)
To: Matthias Brugger
Cc: Mark Rutland, devicetree, srv_heupstream, linux-kernel,
Rob Herring, linux-mediatek, linux-arm-kernel
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
Please also apply this (if no problems) since we have changed to ca72.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-04-16 8:35 ` Seiya Wang
0 siblings, 0 replies; 13+ messages in thread
From: Seiya Wang @ 2019-04-16 8:35 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
Please also apply this (if no problems) since we have changed to ca72.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
2019-04-16 8:35 ` Seiya Wang
@ 2019-04-16 8:57 ` Matthias Brugger
-1 siblings, 0 replies; 13+ messages in thread
From: Matthias Brugger @ 2019-04-16 8:57 UTC (permalink / raw)
To: Seiya Wang
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, srv_heupstream
On 16/04/2019 10:35, Seiya Wang wrote:
> On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>>
>> On 09/01/2019 09:21, Seiya Wang wrote:
>>> This patch adds the device nodes of ARM Performance Monitor Uint
>>> for mt8173.
>>>
>>> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 412ffd4d426b..44374c506a1c 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -216,6 +216,20 @@
>>> };
>>> };
>>>
>>> + pmu_a53 {
>>> + compatible = "arm,cortex-a53-pmu";
>>> + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
>>> + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-affinity = <&cpu0>, <&cpu1>;
>>> + };
>>> +
>>> + pmu_a72 {
>>> + compatible = "arm,cortex-a72-pmu";
>>> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
>>> + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-affinity = <&cpu2>, <&cpu3>;
>>> + };
>>
>> There is no a72 but a a57 CPU present.
>> Typo?
>>
>> Regards,
>> Matthias
>
> Please also apply this (if no problems) since we have changed to ca72.
> Thanks.
>
Pushed now to v5.1-next/dts64
Thanks for the heads up :)
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
@ 2019-04-16 8:57 ` Matthias Brugger
0 siblings, 0 replies; 13+ messages in thread
From: Matthias Brugger @ 2019-04-16 8:57 UTC (permalink / raw)
To: Seiya Wang
Cc: Mark Rutland, devicetree, srv_heupstream, linux-kernel,
Rob Herring, linux-mediatek, linux-arm-kernel
On 16/04/2019 10:35, Seiya Wang wrote:
> On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>>
>> On 09/01/2019 09:21, Seiya Wang wrote:
>>> This patch adds the device nodes of ARM Performance Monitor Uint
>>> for mt8173.
>>>
>>> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> index 412ffd4d426b..44374c506a1c 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>>> @@ -216,6 +216,20 @@
>>> };
>>> };
>>>
>>> + pmu_a53 {
>>> + compatible = "arm,cortex-a53-pmu";
>>> + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
>>> + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-affinity = <&cpu0>, <&cpu1>;
>>> + };
>>> +
>>> + pmu_a72 {
>>> + compatible = "arm,cortex-a72-pmu";
>>> + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
>>> + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-affinity = <&cpu2>, <&cpu3>;
>>> + };
>>
>> There is no a72 but a a57 CPU present.
>> Typo?
>>
>> Regards,
>> Matthias
>
> Please also apply this (if no problems) since we have changed to ca72.
> Thanks.
>
Pushed now to v5.1-next/dts64
Thanks for the heads up :)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread