* stm class: Fix possible double free
@ 2019-04-18 7:22 ` Pan Bian
0 siblings, 0 replies; 4+ messages in thread
From: Pan Bian @ 2019-04-18 7:22 UTC (permalink / raw)
To: Alexander Shishkin, Maxime Coquelin, Alexandre Torgue
Cc: linux-stm32, linux-arm-kernel, linux-kernel, Pan Bian
The function stm_register_device() calls put_device(&stm->dev) to
release allocated memory (in stm_device_release()) on error paths.
However, after that, the freed memory stm is released again, resulting
in a double free bug. There is a similar issue in the function
stm_source_register_device. This patch fixes these issues.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/hwtracing/stm/core.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index c7ba8ac..cfb5c4d 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -886,8 +886,10 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
return -ENOMEM;
stm->major = register_chrdev(0, stm_data->name, &stm_fops);
- if (stm->major < 0)
- goto err_free;
+ if (stm->major < 0) {
+ vfree(stm);
+ return err;
+ }
device_initialize(&stm->dev);
stm->dev.devt = MKDEV(stm->major, 0);
@@ -933,8 +935,6 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
/* matches device_initialize() above */
put_device(&stm->dev);
-err_free:
- vfree(stm);
return err;
}
@@ -1277,7 +1277,6 @@ int stm_source_register_device(struct device *parent,
err:
put_device(&src->dev);
- kfree(src);
return err;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* stm class: Fix possible double free
@ 2019-04-18 7:22 ` Pan Bian
0 siblings, 0 replies; 4+ messages in thread
From: Pan Bian @ 2019-04-18 7:22 UTC (permalink / raw)
To: Alexander Shishkin, Maxime Coquelin, Alexandre Torgue
Cc: Pan Bian, linux-stm32, linux-arm-kernel, linux-kernel
The function stm_register_device() calls put_device(&stm->dev) to
release allocated memory (in stm_device_release()) on error paths.
However, after that, the freed memory stm is released again, resulting
in a double free bug. There is a similar issue in the function
stm_source_register_device. This patch fixes these issues.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/hwtracing/stm/core.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index c7ba8ac..cfb5c4d 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -886,8 +886,10 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
return -ENOMEM;
stm->major = register_chrdev(0, stm_data->name, &stm_fops);
- if (stm->major < 0)
- goto err_free;
+ if (stm->major < 0) {
+ vfree(stm);
+ return err;
+ }
device_initialize(&stm->dev);
stm->dev.devt = MKDEV(stm->major, 0);
@@ -933,8 +935,6 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
/* matches device_initialize() above */
put_device(&stm->dev);
-err_free:
- vfree(stm);
return err;
}
@@ -1277,7 +1277,6 @@ int stm_source_register_device(struct device *parent,
err:
put_device(&src->dev);
- kfree(src);
return err;
}
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: stm class: Fix possible double free
2019-04-18 7:22 ` Pan Bian
@ 2019-04-18 8:05 ` Mukesh Ojha
-1 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-18 8:05 UTC (permalink / raw)
To: Pan Bian, Alexander Shishkin, Maxime Coquelin, Alexandre Torgue
Cc: linux-stm32, linux-arm-kernel, linux-kernel
On 4/18/2019 12:52 PM, Pan Bian wrote:
> The function stm_register_device() calls put_device(&stm->dev) to
> release allocated memory (in stm_device_release()) on error paths.
> However, after that, the freed memory stm is released again, resulting
> in a double free bug. There is a similar issue in the function
> stm_source_register_device. This patch fixes these issues.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Looks good to me.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/hwtracing/stm/core.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
> index c7ba8ac..cfb5c4d 100644
> --- a/drivers/hwtracing/stm/core.c
> +++ b/drivers/hwtracing/stm/core.c
> @@ -886,8 +886,10 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
> return -ENOMEM;
>
> stm->major = register_chrdev(0, stm_data->name, &stm_fops);
> - if (stm->major < 0)
> - goto err_free;
> + if (stm->major < 0) {
> + vfree(stm);
> + return err;
> + }
>
> device_initialize(&stm->dev);
> stm->dev.devt = MKDEV(stm->major, 0);
> @@ -933,8 +935,6 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
>
> /* matches device_initialize() above */
> put_device(&stm->dev);
> -err_free:
> - vfree(stm);
>
> return err;
> }
> @@ -1277,7 +1277,6 @@ int stm_source_register_device(struct device *parent,
>
> err:
> put_device(&src->dev);
> - kfree(src);
>
> return err;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: stm class: Fix possible double free
@ 2019-04-18 8:05 ` Mukesh Ojha
0 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-18 8:05 UTC (permalink / raw)
To: Pan Bian, Alexander Shishkin, Maxime Coquelin, Alexandre Torgue
Cc: linux-stm32, linux-arm-kernel, linux-kernel
On 4/18/2019 12:52 PM, Pan Bian wrote:
> The function stm_register_device() calls put_device(&stm->dev) to
> release allocated memory (in stm_device_release()) on error paths.
> However, after that, the freed memory stm is released again, resulting
> in a double free bug. There is a similar issue in the function
> stm_source_register_device. This patch fixes these issues.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Looks good to me.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/hwtracing/stm/core.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
> index c7ba8ac..cfb5c4d 100644
> --- a/drivers/hwtracing/stm/core.c
> +++ b/drivers/hwtracing/stm/core.c
> @@ -886,8 +886,10 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
> return -ENOMEM;
>
> stm->major = register_chrdev(0, stm_data->name, &stm_fops);
> - if (stm->major < 0)
> - goto err_free;
> + if (stm->major < 0) {
> + vfree(stm);
> + return err;
> + }
>
> device_initialize(&stm->dev);
> stm->dev.devt = MKDEV(stm->major, 0);
> @@ -933,8 +935,6 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data,
>
> /* matches device_initialize() above */
> put_device(&stm->dev);
> -err_free:
> - vfree(stm);
>
> return err;
> }
> @@ -1277,7 +1277,6 @@ int stm_source_register_device(struct device *parent,
>
> err:
> put_device(&src->dev);
> - kfree(src);
>
> return err;
> }
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-18 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 7:22 stm class: Fix possible double free Pan Bian
2019-04-18 7:22 ` Pan Bian
2019-04-18 8:05 ` Mukesh Ojha
2019-04-18 8:05 ` Mukesh Ojha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.