* [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ?
@ 2019-01-27 9:26 dcb
2019-01-27 9:31 ` [Qemu-devel] [Bug 1813460] " dcb
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: dcb @ 2019-01-27 9:26 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1813460
Title:
qemu/target/arm/translate-a64.c:2039: bad test ?
Status in QEMU:
New
Bug description:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1813460/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1813460] Re: qemu/target/arm/translate-a64.c:2039: bad test ?
2019-01-27 9:26 [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ? dcb
@ 2019-01-27 9:31 ` dcb
2019-01-27 19:04 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: dcb @ 2019-01-27 9:31 UTC (permalink / raw)
To: qemu-devel
Maybe using gcc flag -Wlogical-op might help find bugs like this in
future.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1813460
Title:
qemu/target/arm/translate-a64.c:2039: bad test ?
Status in QEMU:
New
Bug description:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1813460/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1813460] Re: qemu/target/arm/translate-a64.c:2039: bad test ?
2019-01-27 9:26 [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ? dcb
2019-01-27 9:31 ` [Qemu-devel] [Bug 1813460] " dcb
@ 2019-01-27 19:04 ` Richard Henderson
2019-02-04 13:23 ` Richard Henderson
2019-04-24 5:30 ` Thomas Huth
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2019-01-27 19:04 UTC (permalink / raw)
To: qemu-devel
There is a patch on list for this:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html
Using the flag is a good idea.
** Changed in: qemu
Status: New => In Progress
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1813460
Title:
qemu/target/arm/translate-a64.c:2039: bad test ?
Status in QEMU:
In Progress
Bug description:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1813460/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1813460] Re: qemu/target/arm/translate-a64.c:2039: bad test ?
2019-01-27 9:26 [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ? dcb
2019-01-27 9:31 ` [Qemu-devel] [Bug 1813460] " dcb
2019-01-27 19:04 ` Richard Henderson
@ 2019-02-04 13:23 ` Richard Henderson
2019-04-24 5:30 ` Thomas Huth
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2019-02-04 13:23 UTC (permalink / raw)
To: qemu-devel
The patch is now in master.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1813460
Title:
qemu/target/arm/translate-a64.c:2039: bad test ?
Status in QEMU:
Fix Committed
Bug description:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1813460/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1813460] Re: qemu/target/arm/translate-a64.c:2039: bad test ?
2019-01-27 9:26 [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ? dcb
` (2 preceding siblings ...)
2019-02-04 13:23 ` Richard Henderson
@ 2019-04-24 5:30 ` Thomas Huth
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2019-04-24 5:30 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1813460
Title:
qemu/target/arm/translate-a64.c:2039: bad test ?
Status in QEMU:
Fix Released
Bug description:
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction
always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1813460/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-24 5:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-27 9:26 [Qemu-devel] [Bug 1813460] [NEW] qemu/target/arm/translate-a64.c:2039: bad test ? dcb
2019-01-27 9:31 ` [Qemu-devel] [Bug 1813460] " dcb
2019-01-27 19:04 ` Richard Henderson
2019-02-04 13:23 ` Richard Henderson
2019-04-24 5:30 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.