* [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
@ 2018-11-01 13:18 Martin Liska
2018-12-05 11:40 ` [Qemu-devel] [Bug 1801073] " Alex Bennée
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Martin Liska @ 2018-11-01 13:18 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
New
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
@ 2018-12-05 11:40 ` Alex Bennée
2019-01-18 17:22 ` Peter Maydell
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Alex Bennée @ 2018-12-05 11:40 UTC (permalink / raw)
To: qemu-devel
** Tags added: ipxe
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
New
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
2018-12-05 11:40 ` [Qemu-devel] [Bug 1801073] " Alex Bennée
@ 2019-01-18 17:22 ` Peter Maydell
2019-01-21 9:41 ` Martin Liska
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2019-01-18 17:22 UTC (permalink / raw)
To: qemu-devel
This bug would be better reported to the upstream for the ipxe rom -- we
just ship the source code because we ship the binary.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
New
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
2018-12-05 11:40 ` [Qemu-devel] [Bug 1801073] " Alex Bennée
2019-01-18 17:22 ` Peter Maydell
@ 2019-01-21 9:41 ` Martin Liska
2019-01-21 12:25 ` Martin Liska
2019-04-24 6:06 ` Thomas Huth
4 siblings, 0 replies; 8+ messages in thread
From: Martin Liska @ 2019-01-21 9:41 UTC (permalink / raw)
To: qemu-devel
Thank you, I contacted IPXE folks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
New
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
` (2 preceding siblings ...)
2019-01-21 9:41 ` Martin Liska
@ 2019-01-21 12:25 ` Martin Liska
2019-01-21 12:57 ` Peter Maydell
2019-04-24 6:06 ` Thomas Huth
4 siblings, 1 reply; 8+ messages in thread
From: Martin Liska @ 2019-01-21 12:25 UTC (permalink / raw)
To: qemu-devel
Should be fixed here:
http://git.ipxe.org/ipxe.git/commitdiff/956f6a722
Btw. how do you pull changes from ipxe into qemu repo?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
New
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2019-01-21 12:25 ` Martin Liska
@ 2019-01-21 12:57 ` Peter Maydell
2019-01-21 14:35 ` Gerd Hoffmann
0 siblings, 1 reply; 8+ messages in thread
From: Peter Maydell @ 2019-01-21 12:57 UTC (permalink / raw)
To: Bug 1801073; +Cc: QEMU Developers, Gerd Hoffmann
On Mon, 21 Jan 2019 at 12:47, Martin Liska <mliska@suse.cz> wrote:
>
> Should be fixed here:
> http://git.ipxe.org/ipxe.git/commitdiff/956f6a722
>
> Btw. how do you pull changes from ipxe into qemu repo?
The next step is a QEMU patch which updates our git submodule
to point at a version of IPXE with the fix and also has the
pre-built binaries corresponding to that new version.
Gerd, it looks like you did the last IPXE update -- could
we do another one with this fix in it?
thanks
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2019-01-21 12:57 ` Peter Maydell
@ 2019-01-21 14:35 ` Gerd Hoffmann
0 siblings, 0 replies; 8+ messages in thread
From: Gerd Hoffmann @ 2019-01-21 14:35 UTC (permalink / raw)
To: Peter Maydell; +Cc: Bug 1801073, QEMU Developers
On Mon, Jan 21, 2019 at 12:57:16PM +0000, Peter Maydell wrote:
> On Mon, 21 Jan 2019 at 12:47, Martin Liska <mliska@suse.cz> wrote:
> >
> > Should be fixed here:
> > http://git.ipxe.org/ipxe.git/commitdiff/956f6a722
> >
> > Btw. how do you pull changes from ipxe into qemu repo?
>
> The next step is a QEMU patch which updates our git submodule
> to point at a version of IPXE with the fix and also has the
> pre-built binaries corresponding to that new version.
>
> Gerd, it looks like you did the last IPXE update -- could
> we do another one with this fix in it?
Yes, makes sense to do that, last ipxe rebase was more than a year ago.
cheers,
Gerd
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [Bug 1801073] Re: util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
` (3 preceding siblings ...)
2019-01-21 12:25 ` Martin Liska
@ 2019-04-24 6:06 ` Thomas Huth
4 siblings, 0 replies; 8+ messages in thread
From: Thomas Huth @ 2019-04-24 6:06 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1801073
Title:
util/zbin.c:390:37: error: absolute value function 'abs' given an
argument of type 'long int' but has parameter of type 'int' which may
cause truncation of value [-Werror=absolute-value]
Status in QEMU:
Fix Released
Bug description:
For qemu-3.0.0 I see with GCC 9 compiler a new warning:
$ make -j1 -C roms pxerom VERBOSE=1 V=1
make: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms'
make -C ipxe/src CONFIG=qemu \
PACKAGING_TIMESTAMP=1534273834 \
CROSS_COMPILE= \
bin/8086100e.rom bin/808610d3.rom bin/80861209.rom bin/10500940.rom bin/10222000.rom bin/10ec8139.rom bin/1af41000.rom bin/15ad07b0.rom
make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/qemu-3.0.0/roms/ipxe/src'
gcc -Wall -W -Wformat-nonliteral -O2 -g -Werror util/zbin.c -llzma -o util/zbin
util/zbin.c: In function 'process_zinfo_add':
util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
390 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:398:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
398 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ), size,
| ^~~
util/zbin.c:419:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value]
419 | ( ( addend < 0 ) ? "-" : "" ), abs ( addend ),
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile.housekeeping:1368: util/zbin] Error 1
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1801073/+subscriptions
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-24 6:20 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 13:18 [Qemu-devel] [Bug 1801073] [NEW] util/zbin.c:390:37: error: absolute value function 'abs' given an argument of type 'long int' but has parameter of type 'int' which may cause truncation of value [-Werror=absolute-value] Martin Liska
2018-12-05 11:40 ` [Qemu-devel] [Bug 1801073] " Alex Bennée
2019-01-18 17:22 ` Peter Maydell
2019-01-21 9:41 ` Martin Liska
2019-01-21 12:25 ` Martin Liska
2019-01-21 12:57 ` Peter Maydell
2019-01-21 14:35 ` Gerd Hoffmann
2019-04-24 6:06 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.