* [PATCH] clk: imx: pll14xx: drop unused variable
@ 2019-04-25 10:14 ` Peng Fan
0 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2019-04-25 10:14 UTC (permalink / raw)
To: mturquette, sboyd, shawnguo, s.hauer
Cc: kernel, festevam, dl-linux-imx, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, Peng Fan
It does not make sense to only get value from pll->base and assign
to a local variable when recalc_rate.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-pll14xx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 1acfa3e3cfb4..12e584185daf 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -74,10 +74,9 @@ static unsigned long clk_pll1416x_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate)
{
struct clk_pll14xx *pll = to_clk_pll14xx(hw);
- u32 mdiv, pdiv, sdiv, pll_gnrl, pll_div;
+ u32 mdiv, pdiv, sdiv, pll_div;
u64 fvco = parent_rate;
- pll_gnrl = readl_relaxed(pll->base);
pll_div = readl_relaxed(pll->base + 4);
mdiv = (pll_div & MDIV_MASK) >> MDIV_SHIFT;
pdiv = (pll_div & PDIV_MASK) >> PDIV_SHIFT;
@@ -93,11 +92,10 @@ static unsigned long clk_pll1443x_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate)
{
struct clk_pll14xx *pll = to_clk_pll14xx(hw);
- u32 mdiv, pdiv, sdiv, pll_gnrl, pll_div_ctl0, pll_div_ctl1;
+ u32 mdiv, pdiv, sdiv, pll_div_ctl0, pll_div_ctl1;
short int kdiv;
u64 fvco = parent_rate;
- pll_gnrl = readl_relaxed(pll->base);
pll_div_ctl0 = readl_relaxed(pll->base + 4);
pll_div_ctl1 = readl_relaxed(pll->base + 8);
mdiv = (pll_div_ctl0 & MDIV_MASK) >> MDIV_SHIFT;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] clk: imx: pll14xx: drop unused variable
@ 2019-04-25 10:14 ` Peng Fan
0 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2019-04-25 10:14 UTC (permalink / raw)
To: mturquette, sboyd, shawnguo, s.hauer
Cc: Peng Fan, Jacky Bai, linux-kernel, dl-linux-imx, kernel,
festevam, linux-clk, linux-arm-kernel
It does not make sense to only get value from pll->base and assign
to a local variable when recalc_rate.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-pll14xx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c
index 1acfa3e3cfb4..12e584185daf 100644
--- a/drivers/clk/imx/clk-pll14xx.c
+++ b/drivers/clk/imx/clk-pll14xx.c
@@ -74,10 +74,9 @@ static unsigned long clk_pll1416x_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate)
{
struct clk_pll14xx *pll = to_clk_pll14xx(hw);
- u32 mdiv, pdiv, sdiv, pll_gnrl, pll_div;
+ u32 mdiv, pdiv, sdiv, pll_div;
u64 fvco = parent_rate;
- pll_gnrl = readl_relaxed(pll->base);
pll_div = readl_relaxed(pll->base + 4);
mdiv = (pll_div & MDIV_MASK) >> MDIV_SHIFT;
pdiv = (pll_div & PDIV_MASK) >> PDIV_SHIFT;
@@ -93,11 +92,10 @@ static unsigned long clk_pll1443x_recalc_rate(struct clk_hw *hw,
unsigned long parent_rate)
{
struct clk_pll14xx *pll = to_clk_pll14xx(hw);
- u32 mdiv, pdiv, sdiv, pll_gnrl, pll_div_ctl0, pll_div_ctl1;
+ u32 mdiv, pdiv, sdiv, pll_div_ctl0, pll_div_ctl1;
short int kdiv;
u64 fvco = parent_rate;
- pll_gnrl = readl_relaxed(pll->base);
pll_div_ctl0 = readl_relaxed(pll->base + 4);
pll_div_ctl1 = readl_relaxed(pll->base + 8);
mdiv = (pll_div_ctl0 & MDIV_MASK) >> MDIV_SHIFT;
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx: pll14xx: drop unused variable
2019-04-25 10:14 ` Peng Fan
@ 2019-04-25 21:42 ` Stephen Boyd
-1 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-04-25 21:42 UTC (permalink / raw)
To: mturquette, s.hauer, shawnguo, Peng Fan
Cc: kernel, festevam, dl-linux-imx, Jacky Bai, linux-clk,
linux-arm-kernel, linux-kernel, Peng Fan
Quoting Peng Fan (2019-04-25 03:14:28)
> It does not make sense to only get value from pll->base and assign
> to a local variable when recalc_rate.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx: pll14xx: drop unused variable
@ 2019-04-25 21:42 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-04-25 21:42 UTC (permalink / raw)
To: mturquette, s.hauer, shawnguo, Peng Fan
Cc: Peng Fan, Jacky Bai, linux-kernel, dl-linux-imx, kernel,
festevam, linux-clk, linux-arm-kernel
Quoting Peng Fan (2019-04-25 03:14:28)
> It does not make sense to only get value from pll->base and assign
> to a local variable when recalc_rate.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-25 21:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-25 10:14 [PATCH] clk: imx: pll14xx: drop unused variable Peng Fan
2019-04-25 10:14 ` Peng Fan
2019-04-25 21:42 ` Stephen Boyd
2019-04-25 21:42 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.