From: Lucas Stach <l.stach@pengutronix.de> To: Robin Gong <yibin.gong@nxp.com>, "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "plyatov@gmail.com" <plyatov@gmail.com>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will.deacon@arm.com" <will.deacon@arm.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Date: Fri, 26 Apr 2019 10:19:39 +0200 [thread overview] Message-ID: <1556266779.2584.15.camel@pengutronix.de> (raw) In-Reply-To: <1556265512-9130-1-git-send-email-yibin.gong@nxp.com> Hi Robin, Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong: > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA mode. Please get more information from: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding > new sdma ram script which works in XCH mode as PIO inside sdma instead > of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. I would like to have a more in-depth explanation about how this new RAM script differs from the existing ROM script and the changes to the state transitions. > The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul, > NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/ > i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set > add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma > driver to choose if need errata or not. > The first two reverted patches should be the same issue, though, it > seems 'fixed' by changing to other shp script. Hope Sean or Sascha could > have the chance to test this patch set if could fix their issues. > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work > on i.mx8mm because the event id is zero. > > PS: > Please get sdma firmware from below linux-firmware and copy it to your > local rootfs /lib/firmware/imx/sdma. > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma This is not an option as long as the SDMA RAM firmware breaks the mainline serial DMA support. Please provide a fixed SDMA RAM firmware that doesn't replace the ROM serial script, as that one is totally fine. Regards, Lucas > v2: > 1. add commit log for reverted patches. > 2. add comment for 'ecspi_fixed' in sdma driver. > 3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi' > rather than remove. > > > Robin Gong (15): > Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" > Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" > Revert "dmaengine: imx-sdma: refine to load context only once" > dmaengine: imx-sdma: remove dupilicated sdma_load_context > dma: engine: imx-sdma: add mcu_2_ecspi script > spi: imx: fix ERR009165 > spi: imx: remove ERR009165 workaround on i.mx6ul > dt-bindings: spi: imx: add i.mx6ul to state errata fixed > dmaengine: imx-sdma: remove ERR009165 on i.mx6ul > dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name > dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm > ARM64: dts: freescale: imx8mm/8mq: update new compatible name for > ecspi and sdma > ARM: dts: imx6ul: add dma support on ecspi > ARM: dts: imx6sll: correct ecspi/sdma compatible > arm64: defconfig: Enable SDMA on i.mx8mq/8mm > > .../devicetree/bindings/dma/fsl-imx-sdma.txt | 2 + > .../devicetree/bindings/spi/fsl-imx-cspi.txt | 2 + > arch/arm/boot/dts/imx6q.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl.dtsi | 8 +-- > arch/arm/boot/dts/imx6sll.dtsi | 10 ++-- > arch/arm/boot/dts/imx6ul.dtsi | 8 +++ > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 ++--- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +- > arch/arm64/configs/defconfig | 3 + > drivers/dma/imx-sdma.c | 67 ++++++++++++++++------ > drivers/spi/spi-imx.c | 46 ++++++++++++--- > include/linux/platform_data/dma-imx-sdma.h | 1 + > 12 files changed, 124 insertions(+), 45 deletions(-) > > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Robin Gong <yibin.gong@nxp.com>, "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>, "plyatov@gmail.com" <plyatov@gmail.com>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "catalin.marinas@arm.com" <catalin.marinas@arm.com>, "will.deacon@arm.com" <will.deacon@arm.com> Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Date: Fri, 26 Apr 2019 10:19:39 +0200 [thread overview] Message-ID: <1556266779.2584.15.camel@pengutronix.de> (raw) In-Reply-To: <1556265512-9130-1-git-send-email-yibin.gong@nxp.com> Hi Robin, Am Freitag, den 26.04.2019, 08:05 +0000 schrieb Robin Gong: > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA mode. Please get more information from: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding > new sdma ram script which works in XCH mode as PIO inside sdma instead > of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. I would like to have a more in-depth explanation about how this new RAM script differs from the existing ROM script and the changes to the state transitions. > The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul, > NXP fix this design issue from i.mx6ul, so newer chips such as i.mx6ull/ > i.mx8mq/i.mx8mm, don't need this workaroud anymore. This patch set > add new 'fsl,imx6ul-ecspi' for ecspi driver and 'ecspi_fixed' in sdma > driver to choose if need errata or not. > The first two reverted patches should be the same issue, though, it > seems 'fixed' by changing to other shp script. Hope Sean or Sascha could > have the chance to test this patch set if could fix their issues. > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work > on i.mx8mm because the event id is zero. > > PS: > Please get sdma firmware from below linux-firmware and copy it to your > local rootfs /lib/firmware/imx/sdma. > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma This is not an option as long as the SDMA RAM firmware breaks the mainline serial DMA support. Please provide a fixed SDMA RAM firmware that doesn't replace the ROM serial script, as that one is totally fine. Regards, Lucas > v2: > 1. add commit log for reverted patches. > 2. add comment for 'ecspi_fixed' in sdma driver. > 3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi' > rather than remove. > > > Robin Gong (15): > Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" > Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" > Revert "dmaengine: imx-sdma: refine to load context only once" > dmaengine: imx-sdma: remove dupilicated sdma_load_context > dma: engine: imx-sdma: add mcu_2_ecspi script > spi: imx: fix ERR009165 > spi: imx: remove ERR009165 workaround on i.mx6ul > dt-bindings: spi: imx: add i.mx6ul to state errata fixed > dmaengine: imx-sdma: remove ERR009165 on i.mx6ul > dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name > dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm > ARM64: dts: freescale: imx8mm/8mq: update new compatible name for > ecspi and sdma > ARM: dts: imx6ul: add dma support on ecspi > ARM: dts: imx6sll: correct ecspi/sdma compatible > arm64: defconfig: Enable SDMA on i.mx8mq/8mm > > .../devicetree/bindings/dma/fsl-imx-sdma.txt | 2 + > .../devicetree/bindings/spi/fsl-imx-cspi.txt | 2 + > arch/arm/boot/dts/imx6q.dtsi | 2 +- > arch/arm/boot/dts/imx6qdl.dtsi | 8 +-- > arch/arm/boot/dts/imx6sll.dtsi | 10 ++-- > arch/arm/boot/dts/imx6ul.dtsi | 8 +++ > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 14 ++--- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 +- > arch/arm64/configs/defconfig | 3 + > drivers/dma/imx-sdma.c | 67 ++++++++++++++++------ > drivers/spi/spi-imx.c | 46 ++++++++++++--- > include/linux/platform_data/dma-imx-sdma.h | 1 + > 12 files changed, 124 insertions(+), 45 deletions(-) > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-26 8:19 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-26 8:05 [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` [v2,08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed Robin Gong 2019-04-26 8:05 ` [PATCH v2 08/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-05-01 20:07 ` [v2,08/15] " Rob Herring 2019-05-01 20:07 ` [PATCH v2 08/15] " Rob Herring 2019-05-01 20:07 ` Rob Herring 2019-05-01 20:07 ` Rob Herring 2019-05-01 20:07 ` Rob Herring 2019-05-05 8:55 ` [EXT] " Robin Gong 2019-05-05 8:55 ` Robin Gong 2019-05-05 8:55 ` Robin Gong 2019-05-05 8:55 ` Robin Gong 2019-05-02 6:59 ` [v2,08/15] " Uwe Kleine-König 2019-05-02 6:59 ` [PATCH v2 08/15] " Uwe Kleine-König 2019-05-02 6:59 ` Uwe Kleine-König 2019-05-02 6:59 ` Uwe Kleine-König 2019-05-05 8:47 ` [EXT] " Robin Gong 2019-05-05 8:47 ` Robin Gong 2019-05-05 8:47 ` Robin Gong 2019-05-05 8:47 ` Robin Gong 2019-04-26 8:19 ` Lucas Stach [this message] 2019-04-26 8:19 ` [PATCH v2 00/15] add ecspi ERR009165 for i.mx6/7 soc family Lucas Stach 2019-04-26 8:19 ` Lucas Stach 2019-04-26 8:47 ` [EXT] " Robin Gong 2019-04-26 8:47 ` Robin Gong 2019-04-26 9:06 ` Lucas Stach 2019-04-26 9:06 ` Lucas Stach 2019-04-26 9:06 ` Lucas Stach 2019-04-26 8:05 [v2,01/15] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong 2019-04-26 8:05 ` [PATCH v2 01/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,02/15] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong 2019-04-26 8:05 ` [PATCH v2 02/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,03/15] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong 2019-04-26 8:05 ` [PATCH v2 03/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,04/15] dmaengine: imx-sdma: remove dupilicated sdma_load_context Robin Gong 2019-04-26 8:05 ` [PATCH v2 04/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,05/15] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong 2019-04-26 8:05 ` [PATCH v2 05/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,06/15] spi: imx: fix ERR009165 Robin Gong 2019-04-26 8:05 ` [PATCH v2 06/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2019-04-26 8:05 ` [PATCH v2 07/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 [v2,09/15] dmaengine: imx-sdma: remove ERR009165 " Robin Gong 2019-04-26 8:05 ` [PATCH v2 09/15] " Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:05 ` Robin Gong 2019-04-26 8:06 [v2,10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name Robin Gong 2019-04-26 8:06 ` [PATCH v2 10/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 [v2,11/15] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong 2019-04-26 8:06 ` [PATCH v2 11/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 [v2,12/15] ARM64: dts: freescale: imx8mm/8mq: update new compatible name for ecspi and sdma Robin Gong 2019-04-26 8:06 ` [PATCH v2 12/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 [v2,13/15] ARM: dts: imx6ul: add dma support on ecspi Robin Gong 2019-04-26 8:06 ` [PATCH v2 13/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 [v2,14/15] ARM: dts: imx6sll: correct ecspi/sdma compatible Robin Gong 2019-04-26 8:06 ` [PATCH v2 14/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 [v2,15/15] arm64: defconfig: Enable SDMA on i.mx8mq/8mm Robin Gong 2019-04-26 8:06 ` [PATCH v2 15/15] " Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 8:06 ` Robin Gong 2019-04-26 9:07 [v2,06/15] spi: imx: fix ERR009165 Lucas Stach 2019-04-26 9:07 ` [PATCH v2 06/15] " Lucas Stach 2019-04-26 9:07 ` Lucas Stach 2019-04-26 9:07 ` Lucas Stach 2019-04-26 9:09 [v2,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Lucas Stach 2019-04-26 9:09 ` [PATCH v2 07/15] " Lucas Stach 2019-04-26 9:09 ` Lucas Stach 2019-04-26 9:09 ` Lucas Stach 2019-04-26 9:22 [v2,06/15] spi: imx: fix ERR009165 Robin Gong 2019-04-26 9:22 ` [EXT] Re: [PATCH v2 06/15] " Robin Gong 2019-04-26 9:22 ` Robin Gong 2019-04-26 9:22 ` Robin Gong 2019-04-26 9:32 [v2,07/15] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong 2019-04-26 9:32 ` [EXT] Re: [PATCH v2 07/15] " Robin Gong 2019-04-26 9:32 ` Robin Gong 2019-04-26 9:37 [v2,06/15] spi: imx: fix ERR009165 Lucas Stach 2019-04-26 9:37 ` [EXT] Re: [PATCH v2 06/15] " Lucas Stach 2019-04-26 9:37 ` Lucas Stach 2019-04-26 9:37 ` Lucas Stach 2019-04-26 9:53 [v2,06/15] " Robin Gong 2019-04-26 9:53 ` [EXT] Re: [PATCH v2 06/15] " Robin Gong 2019-04-26 9:53 ` Robin Gong 2019-04-26 9:53 ` Robin Gong 2019-05-01 20:07 [v2,10/15] dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name Rob Herring 2019-05-01 20:07 ` [PATCH v2 10/15] " Rob Herring 2019-05-01 20:07 ` Rob Herring 2019-05-01 20:07 ` Rob Herring 2019-05-01 20:07 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1556266779.2584.15.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=plyatov@gmail.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=u.kleine-koenig@pengutronix.de \ --cc=will.deacon@arm.com \ --cc=yibin.gong@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.