From: Biao Huang <biao.huang@mediatek.com>
To: Jose Abreu <joabreu@synopsys.com>, <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <yt.shen@mediatek.com>,
<biao.huang@mediatek.com>, <jianguo.zhang@mediatek.com>
Subject: [PATCH 2/6] net: stmmac: fix csr_clk can't be zero issue
Date: Sun, 28 Apr 2019 14:30:05 +0800 [thread overview]
Message-ID: <1556433009-25759-3-git-send-email-biao.huang@mediatek.com> (raw)
In-Reply-To: <1556433009-25759-1-git-send-email-biao.huang@mediatek.com>
The specific clk_csr value can be zero, and
stmmac_clk is necessary for MDC clock which can be set dynamically.
So, change the condition from plat->clk_csr to plat->stmmac_clk to
fix clk_csr can't be zero issue.
Signed-off-by: Biao Huang <biao.huang@mediatek.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 818ad88..9e89b94 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4376,7 +4376,7 @@ int stmmac_dvr_probe(struct device *device,
* set the MDC clock dynamically according to the csr actual
* clock input.
*/
- if (!priv->plat->clk_csr)
+ if (priv->plat->stmmac_clk)
stmmac_clk_csr_set(priv);
else
priv->clk_csr = priv->plat->clk_csr;
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Biao Huang <biao.huang@mediatek.com>
To: Jose Abreu <joabreu@synopsys.com>, davem@davemloft.net
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
yt.shen@mediatek.com, biao.huang@mediatek.com,
jianguo.zhang@mediatek.com
Subject: [PATCH 2/6] net: stmmac: fix csr_clk can't be zero issue
Date: Sun, 28 Apr 2019 14:30:05 +0800 [thread overview]
Message-ID: <1556433009-25759-3-git-send-email-biao.huang@mediatek.com> (raw)
In-Reply-To: <1556433009-25759-1-git-send-email-biao.huang@mediatek.com>
The specific clk_csr value can be zero, and
stmmac_clk is necessary for MDC clock which can be set dynamically.
So, change the condition from plat->clk_csr to plat->stmmac_clk to
fix clk_csr can't be zero issue.
Signed-off-by: Biao Huang <biao.huang@mediatek.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 818ad88..9e89b94 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4376,7 +4376,7 @@ int stmmac_dvr_probe(struct device *device,
* set the MDC clock dynamically according to the csr actual
* clock input.
*/
- if (!priv->plat->clk_csr)
+ if (priv->plat->stmmac_clk)
stmmac_clk_csr_set(priv);
else
priv->clk_csr = priv->plat->clk_csr;
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Biao Huang <biao.huang@mediatek.com>
To: Jose Abreu <joabreu@synopsys.com>, <davem@davemloft.net>
Cc: jianguo.zhang@mediatek.com,
Alexandre Torgue <alexandre.torgue@st.com>,
biao.huang@mediatek.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, yt.shen@mediatek.com,
linux-mediatek@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] net: stmmac: fix csr_clk can't be zero issue
Date: Sun, 28 Apr 2019 14:30:05 +0800 [thread overview]
Message-ID: <1556433009-25759-3-git-send-email-biao.huang@mediatek.com> (raw)
In-Reply-To: <1556433009-25759-1-git-send-email-biao.huang@mediatek.com>
The specific clk_csr value can be zero, and
stmmac_clk is necessary for MDC clock which can be set dynamically.
So, change the condition from plat->clk_csr to plat->stmmac_clk to
fix clk_csr can't be zero issue.
Signed-off-by: Biao Huang <biao.huang@mediatek.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 818ad88..9e89b94 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -4376,7 +4376,7 @@ int stmmac_dvr_probe(struct device *device,
* set the MDC clock dynamically according to the csr actual
* clock input.
*/
- if (!priv->plat->clk_csr)
+ if (priv->plat->stmmac_clk)
stmmac_clk_csr_set(priv);
else
priv->clk_csr = priv->plat->clk_csr;
--
1.7.9.5
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-28 6:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-28 6:30 [PATCH 0/6] fix some bugs and add some features in stmmac Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` [PATCH 1/6] net: stmmac: update rx tail pointer register to fix rx dma hang issue Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang [this message]
2019-04-28 6:30 ` [PATCH 2/6] net: stmmac: fix csr_clk can't be zero issue Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-29 7:18 ` Alexandre Torgue
2019-04-29 7:18 ` Alexandre Torgue
2019-04-29 7:18 ` Alexandre Torgue
2019-04-29 8:09 ` biao huang
2019-04-29 8:09 ` biao huang
2019-04-29 8:09 ` biao huang
2019-04-29 8:26 ` Alexandre Torgue
2019-04-29 8:26 ` Alexandre Torgue
2019-04-29 8:26 ` Alexandre Torgue
2019-04-30 9:15 ` biao huang
2019-04-30 9:15 ` biao huang
2019-04-30 9:15 ` biao huang
2019-04-30 9:43 ` Alexandre Torgue
2019-04-30 9:43 ` Alexandre Torgue
2019-04-30 9:43 ` Alexandre Torgue
2019-04-28 6:30 ` [PATCH 3/6] net: stmmac: write the modified value back to MTL_OPERATION_MODE Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` [PATCH 4/6] net: stmmac: add support for hash table size 128/256 in dwmac4 Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` [PATCH 5/6] net: stmmac: add mdio clause 45 access from mac device for dwmac4 Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 16:37 ` Andrew Lunn
2019-04-28 16:37 ` Andrew Lunn
2019-04-28 16:37 ` Andrew Lunn
2019-04-29 6:05 ` biao huang
2019-04-29 6:05 ` biao huang
2019-04-29 6:05 ` biao huang
2019-04-29 13:23 ` Andrew Lunn
2019-04-29 13:23 ` Andrew Lunn
2019-04-28 6:30 ` [PATCH 6/6] stmmac: dwmac-mediatek: modify csr_clk value to fix mdio read/write fail Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 6:30 ` Biao Huang
2019-04-28 12:48 ` [PATCH 0/6] fix some bugs and add some features in stmmac David Miller
2019-04-28 12:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556433009-25759-3-git-send-email-biao.huang@mediatek.com \
--to=biao.huang@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=jianguo.zhang@mediatek.com \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.