All of lore.kernel.org
 help / color / mirror / Atom feed
* [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
@ 2019-05-03  8:21 ` kbuild test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-05-03  8:21 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: kbuild-all, linux-clk, linux-arm-kernel, Stephen Boyd

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
head:   85ed1c299cca9beb5df6006361cf18bfa2305836
commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE

vim +534 drivers/clk/sifive/fu540-prci.c

   508	
   509	/**
   510	 * __prci_register_clocks() - register clock controls in the PRCI with Linux
   511	 * @dev: Linux struct device *
   512	 *
   513	 * Register the list of clock controls described in __prci_init_plls[] with
   514	 * the Linux clock framework.
   515	 *
   516	 * Return: 0 upon success or a negative error code upon failure.
   517	 */
   518	static int __prci_register_clocks(struct device *dev, struct __prci_data *pd)
   519	{
   520		struct clk_init_data init;
   521		struct __prci_clock *pic;
   522		int parent_count, i, clk_hw_count, r;
   523	
   524		parent_count = of_clk_get_parent_count(dev->of_node);
   525		if (parent_count != EXPECTED_CLK_PARENT_COUNT) {
   526			dev_err(dev, "expected only two parent clocks, found %d\n",
   527				parent_count);
   528			return -EINVAL;
   529		}
   530	
   531		memset(&init, 0, sizeof(struct clk_init_data));
   532	
   533		/* Register PLLs */
 > 534		clk_hw_count = sizeof(__prci_init_clocks) / sizeof(struct __prci_clock);
   535	
   536		for (i = 0; i < clk_hw_count; ++i) {
   537			pic = &__prci_init_clocks[i];
   538	
   539			init.name = pic->name;
   540			init.parent_names = &pic->parent_name;
   541			init.num_parents = 1;
   542			init.ops = pic->ops;
   543			pic->hw.init = &init;
   544	
   545			pic->pd = pd;
   546	
   547			if (pic->pwd)
   548				__prci_wrpll_read_cfg(pd, pic->pwd);
   549	
   550			r = devm_clk_hw_register(dev, &pic->hw);
   551			if (r) {
   552				dev_warn(dev, "Failed to register clock %s: %d\n",
   553					 init.name, r);
   554				return r;
   555			}
   556	
   557			r = clk_hw_register_clkdev(&pic->hw, pic->name, dev_name(dev));
   558			if (r) {
   559				dev_warn(dev, "Failed to register clkdev for %s: %d\n",
   560					 init.name, r);
   561				return r;
   562			}
   563	
   564			pd->hw_clks.hws[i] = &pic->hw;
   565		}
   566	
   567		pd->hw_clks.num = i;
   568	
   569		r = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
   570						&pd->hw_clks);
   571		if (r) {
   572			dev_err(dev, "could not add hw_provider: %d\n", r);
   573			return r;
   574		}
   575	
   576		return 0;
   577	}
   578	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
@ 2019-05-03  8:21 ` kbuild test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-05-03  8:21 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: Stephen Boyd, kbuild-all, linux-arm-kernel, linux-clk

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
head:   85ed1c299cca9beb5df6006361cf18bfa2305836
commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE

vim +534 drivers/clk/sifive/fu540-prci.c

   508	
   509	/**
   510	 * __prci_register_clocks() - register clock controls in the PRCI with Linux
   511	 * @dev: Linux struct device *
   512	 *
   513	 * Register the list of clock controls described in __prci_init_plls[] with
   514	 * the Linux clock framework.
   515	 *
   516	 * Return: 0 upon success or a negative error code upon failure.
   517	 */
   518	static int __prci_register_clocks(struct device *dev, struct __prci_data *pd)
   519	{
   520		struct clk_init_data init;
   521		struct __prci_clock *pic;
   522		int parent_count, i, clk_hw_count, r;
   523	
   524		parent_count = of_clk_get_parent_count(dev->of_node);
   525		if (parent_count != EXPECTED_CLK_PARENT_COUNT) {
   526			dev_err(dev, "expected only two parent clocks, found %d\n",
   527				parent_count);
   528			return -EINVAL;
   529		}
   530	
   531		memset(&init, 0, sizeof(struct clk_init_data));
   532	
   533		/* Register PLLs */
 > 534		clk_hw_count = sizeof(__prci_init_clocks) / sizeof(struct __prci_clock);
   535	
   536		for (i = 0; i < clk_hw_count; ++i) {
   537			pic = &__prci_init_clocks[i];
   538	
   539			init.name = pic->name;
   540			init.parent_names = &pic->parent_name;
   541			init.num_parents = 1;
   542			init.ops = pic->ops;
   543			pic->hw.init = &init;
   544	
   545			pic->pd = pd;
   546	
   547			if (pic->pwd)
   548				__prci_wrpll_read_cfg(pd, pic->pwd);
   549	
   550			r = devm_clk_hw_register(dev, &pic->hw);
   551			if (r) {
   552				dev_warn(dev, "Failed to register clock %s: %d\n",
   553					 init.name, r);
   554				return r;
   555			}
   556	
   557			r = clk_hw_register_clkdev(&pic->hw, pic->name, dev_name(dev));
   558			if (r) {
   559				dev_warn(dev, "Failed to register clkdev for %s: %d\n",
   560					 init.name, r);
   561				return r;
   562			}
   563	
   564			pd->hw_clks.hws[i] = &pic->hw;
   565		}
   566	
   567		pd->hw_clks.num = i;
   568	
   569		r = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
   570						&pd->hw_clks);
   571		if (r) {
   572			dev_err(dev, "could not add hw_provider: %d\n", r);
   573			return r;
   574		}
   575	
   576		return 0;
   577	}
   578	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
  2019-05-03  8:21 ` kbuild test robot
@ 2019-05-03 16:04   ` Stephen Boyd
  -1 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-05-03 16:04 UTC (permalink / raw)
  To: Paul Walmsley, kbuild test robot; +Cc: kbuild-all, linux-clk, linux-arm-kernel

Quoting kbuild test robot (2019-05-03 01:21:21)
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
> head:   85ed1c299cca9beb5df6006361cf18bfa2305836
> commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> coccinelle warnings: (new ones prefixed by >>)
> 
> >> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE

I had a review comment about this on the previous version... I'll go fix
it myself.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
@ 2019-05-03 16:04   ` Stephen Boyd
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Boyd @ 2019-05-03 16:04 UTC (permalink / raw)
  To: Paul Walmsley, kbuild test robot; +Cc: kbuild-all, linux-arm-kernel, linux-clk

Quoting kbuild test robot (2019-05-03 01:21:21)
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
> head:   85ed1c299cca9beb5df6006361cf18bfa2305836
> commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> 
> coccinelle warnings: (new ones prefixed by >>)
> 
> >> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE

I had a review comment about this on the previous version... I'll go fix
it myself.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
  2019-05-03 16:04   ` Stephen Boyd
@ 2019-05-03 18:26     ` Paul Walmsley
  -1 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2019-05-03 18:26 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Paul Walmsley, kbuild test robot, kbuild-all, linux-clk,
	linux-arm-kernel

On Fri, 3 May 2019, Stephen Boyd wrote:

> Quoting kbuild test robot (2019-05-03 01:21:21)
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
> > head:   85ed1c299cca9beb5df6006361cf18bfa2305836
> > commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > 
> > coccinelle warnings: (new ones prefixed by >>)
> > 
> > >> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
> 
> I had a review comment about this on the previous version... I'll go fix
> it myself.

Thanks; I had intended to make that change.  Sorry about that,

- Paul

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
@ 2019-05-03 18:26     ` Paul Walmsley
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Walmsley @ 2019-05-03 18:26 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: kbuild-all, linux-clk, kbuild test robot, linux-arm-kernel,
	Paul Walmsley

On Fri, 3 May 2019, Stephen Boyd wrote:

> Quoting kbuild test robot (2019-05-03 01:21:21)
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-sifive-fu540
> > head:   85ed1c299cca9beb5df6006361cf18bfa2305836
> > commit: 85ed1c299cca9beb5df6006361cf18bfa2305836 [3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > 
> > coccinelle warnings: (new ones prefixed by >>)
> > 
> > >> drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE
> 
> I had a review comment about this on the previous version... I'll go fix
> it myself.

Thanks; I had intended to make that change.  Sorry about that,

- Paul

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-05-03 18:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-03  8:21 [clk:clk-sifive-fu540 3/3] drivers/clk/sifive/fu540-prci.c:534:41-42: WARNING: Use ARRAY_SIZE kbuild test robot
2019-05-03  8:21 ` kbuild test robot
2019-05-03 16:04 ` Stephen Boyd
2019-05-03 16:04   ` Stephen Boyd
2019-05-03 18:26   ` Paul Walmsley
2019-05-03 18:26     ` Paul Walmsley

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.