[PATCH] python-numpy: Avoid installing copy of f2py script

[PATCH] python-numpy: Avoid installing copy of f2py script

[Alejandro Enedino Hernandez Samaniego]

Both python-numpy and python3-numpy try to install the file:

${D}/${bindir}/f2py

which causes an error during do_rootfs since the package manager complains about that.

The numpy packages create basically copies of f2py script with the following names:
f2py (on both)
f2py2 (on python 2)
f2py2.7 (on python 2)
f2py3 (on python 3)
f2py3.7 (on python 3)

Remove the copy of f2py from python-numpy in favor of using the one from python3
to avoid installation issues at do_rootfs().

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
---
 meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
index 5013789..a1133da 100644
--- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
+++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
@@ -4,3 +4,7 @@ require python-numpy.inc
 RDEPENDS_${PN}_class-target_append = " \
     ${PYTHON_PN}-subprocess \
 "
+
+do_install_append(){
+        rm ${D}/${bindir}/f2py
+}
-- 
2.7.4

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Philip Balister]

On 05/20/2019 10:52 AM, Khem Raj wrote:
> On Sun, May 19, 2019 at 11:56 PM Alejandro Enedino Hernandez Samaniego <
> alejandro.enedino.hernandez-samaniego@xilinx.com> wrote:
> 
>> Hey Khem,
>>
>>
>> On 5/18/19 10:09 PM, Khem Raj wrote:
>>>
>>>
>>> On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
>>>> Both python-numpy and python3-numpy try to install the file:
>>>>
>>>> ${D}/${bindir}/f2py
>>>>
>>>> which causes an error during do_rootfs since the package manager
>>>> complains about that.
>>>>
>>>> The numpy packages create basically copies of f2py script with the
>>>> following names:
>>>> f2py (on both)
>>>> f2py2 (on python 2)
>>>> f2py2.7 (on python 2)
>>>> f2py3 (on python 3)
>>>> f2py3.7 (on python 3)
>>>>
>>>> Remove the copy of f2py from python-numpy in favor of using the one
>>>> from python3
>>>> to avoid installation issues at do_rootfs().
>>>>
>>>
>>> what if one does not install py3 ?
>>
>>
>> If you only install py2, you could still execute f2py2 or f2py2.7, I'm
>> simply
>>
>> favoring the py3 installation by default but it should be mostly harmless
>>
>> since there's still two other copies of the script with different names.
> 
> 
> I think it should be such that it’s used from py2 if py3 is not installed
> since otherwise it might break scripts

I don't think working on python2 issues is that important for the
general OpenEmbedded case. Should be left to people that stubbornly
cling to python2.

https://python3statement.org/

numpy will not support Python2 after year end.

Philip

> 
>>
>>
>> Cheers,
>>
>> Alejandro
>>
>>>
>>>> Signed-off-by: Alejandro Enedino Hernandez Samaniego
>>>> <alejandr@xilinx.com>
>>>> ---
>>>>   meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git
>>>> a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>>>> b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>>>> index 5013789..a1133da 100644
>>>> --- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>>>> +++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>>>> @@ -4,3 +4,7 @@ require python-numpy.inc
>>>>   RDEPENDS_${PN}_class-target_append = " \
>>>>       ${PYTHON_PN}-subprocess \
>>>>   "
>>>> +
>>>> +do_install_append(){
>>>> +        rm ${D}/${bindir}/f2py
>>>> +}
>>>>
>>
> 
> 
> 

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]

On Mon, May 20, 2019 at 7:58 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2019-05-20 at 07:52 -0700, Khem Raj wrote:
> > On Sun, May 19, 2019 at 11:56 PM Alejandro Enedino Hernandez
> > Samaniego <alejandro.enedino.hernandez-samaniego@xilinx.com> wrote:
> > > Hey Khem,
> > >
> > >
> > > On 5/18/19 10:09 PM, Khem Raj wrote:
> > > >
> > > >
> > > > On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
> > > >> Both python-numpy and python3-numpy try to install the file:
> > > >>
> > > >> ${D}/${bindir}/f2py
> > > >>
> > > >> which causes an error during do_rootfs since the package
> > > manager
> > > >> complains about that.
> > > >>
> > > >> The numpy packages create basically copies of f2py script with
> > > the
> > > >> following names:
> > > >> f2py (on both)
> > > >> f2py2 (on python 2)
> > > >> f2py2.7 (on python 2)
> > > >> f2py3 (on python 3)
> > > >> f2py3.7 (on python 3)
> > > >>
> > > >> Remove the copy of f2py from python-numpy in favor of using the
> > > one
> > > >> from python3
> > > >> to avoid installation issues at do_rootfs().
> > > >>
> > > >
> > > > what if one does not install py3 ?
> > >
> > >
> > > If you only install py2, you could still execute f2py2 or f2py2.7,
> > > I'm
> > > simply
> > >
> > > favoring the py3 installation by default but it should be mostly
> > > harmless
> > >
> > > since there's still two other copies of the script with different
> > > names.
> >
> > I think it should be such that it’s used from py2 if py3 is not
> > installed since otherwise it might break scripts
>
> Given we're strongly favouring py3 now, I'd hope there aren't many such
> users and if there are, this might encourage them to move to py3? I'm
> not too worried about the lack of a py2 case for this as do we really
> want to add the complexity?
>
> If there are a load of py2 users and this will break things for them,
> fine but are there such users?


Yes I know people using py2 only but then they might not be using this
utility specifically so it might be okay to ignore it for now

>
>
> Cheers,
>
> Richard
>
>

[-- Attachment #2: Type: text/html, Size: 3273 bytes --]

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Richard Purdie]

On Mon, 2019-05-20 at 07:52 -0700, Khem Raj wrote:
> On Sun, May 19, 2019 at 11:56 PM Alejandro Enedino Hernandez
> Samaniego <alejandro.enedino.hernandez-samaniego@xilinx.com> wrote:
> > Hey Khem,
> > 
> > 
> > On 5/18/19 10:09 PM, Khem Raj wrote:
> > >
> > >
> > > On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
> > >> Both python-numpy and python3-numpy try to install the file:
> > >>
> > >> ${D}/${bindir}/f2py
> > >>
> > >> which causes an error during do_rootfs since the package
> > manager 
> > >> complains about that.
> > >>
> > >> The numpy packages create basically copies of f2py script with
> > the 
> > >> following names:
> > >> f2py (on both)
> > >> f2py2 (on python 2)
> > >> f2py2.7 (on python 2)
> > >> f2py3 (on python 3)
> > >> f2py3.7 (on python 3)
> > >>
> > >> Remove the copy of f2py from python-numpy in favor of using the
> > one 
> > >> from python3
> > >> to avoid installation issues at do_rootfs().
> > >>
> > >
> > > what if one does not install py3 ?
> > 
> > 
> > If you only install py2, you could still execute f2py2 or f2py2.7,
> > I'm 
> > simply
> > 
> > favoring the py3 installation by default but it should be mostly
> > harmless
> > 
> > since there's still two other copies of the script with different
> > names.
> 
> I think it should be such that it’s used from py2 if py3 is not
> installed since otherwise it might break scripts 

Given we're strongly favouring py3 now, I'd hope there aren't many such
users and if there are, this might encourage them to move to py3? I'm
not too worried about the lack of a py2 case for this as do we really
want to add the complexity?

If there are a load of py2 users and this will break things for them,
fine but are there such users?

Cheers,

Richard

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2101 bytes --]

On Sun, May 19, 2019 at 11:56 PM Alejandro Enedino Hernandez Samaniego <
alejandro.enedino.hernandez-samaniego@xilinx.com> wrote:

> Hey Khem,
>
>
> On 5/18/19 10:09 PM, Khem Raj wrote:
> >
> >
> > On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
> >> Both python-numpy and python3-numpy try to install the file:
> >>
> >> ${D}/${bindir}/f2py
> >>
> >> which causes an error during do_rootfs since the package manager
> >> complains about that.
> >>
> >> The numpy packages create basically copies of f2py script with the
> >> following names:
> >> f2py (on both)
> >> f2py2 (on python 2)
> >> f2py2.7 (on python 2)
> >> f2py3 (on python 3)
> >> f2py3.7 (on python 3)
> >>
> >> Remove the copy of f2py from python-numpy in favor of using the one
> >> from python3
> >> to avoid installation issues at do_rootfs().
> >>
> >
> > what if one does not install py3 ?
>
>
> If you only install py2, you could still execute f2py2 or f2py2.7, I'm
> simply
>
> favoring the py3 installation by default but it should be mostly harmless
>
> since there's still two other copies of the script with different names.


I think it should be such that it’s used from py2 if py3 is not installed
since otherwise it might break scripts

>
>
> Cheers,
>
> Alejandro
>
> >
> >> Signed-off-by: Alejandro Enedino Hernandez Samaniego
> >> <alejandr@xilinx.com>
> >> ---
> >>   meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git
> >> a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> >> b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> >> index 5013789..a1133da 100644
> >> --- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> >> +++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> >> @@ -4,3 +4,7 @@ require python-numpy.inc
> >>   RDEPENDS_${PN}_class-target_append = " \
> >>       ${PYTHON_PN}-subprocess \
> >>   "
> >> +
> >> +do_install_append(){
> >> +        rm ${D}/${bindir}/f2py
> >> +}
> >>
>

[-- Attachment #2: Type: text/html, Size: 3425 bytes --]

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Alejandro Enedino Hernandez Samaniego]

Hey Khem,


On 5/18/19 10:09 PM, Khem Raj wrote:
>
>
> On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
>> Both python-numpy and python3-numpy try to install the file:
>>
>> ${D}/${bindir}/f2py
>>
>> which causes an error during do_rootfs since the package manager 
>> complains about that.
>>
>> The numpy packages create basically copies of f2py script with the 
>> following names:
>> f2py (on both)
>> f2py2 (on python 2)
>> f2py2.7 (on python 2)
>> f2py3 (on python 3)
>> f2py3.7 (on python 3)
>>
>> Remove the copy of f2py from python-numpy in favor of using the one 
>> from python3
>> to avoid installation issues at do_rootfs().
>>
>
> what if one does not install py3 ?


If you only install py2, you could still execute f2py2 or f2py2.7, I'm 
simply

favoring the py3 installation by default but it should be mostly harmless

since there's still two other copies of the script with different names.

Cheers,

Alejandro

>
>> Signed-off-by: Alejandro Enedino Hernandez Samaniego 
>> <alejandr@xilinx.com>
>> ---
>>   meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git 
>> a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb 
>> b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>> index 5013789..a1133da 100644
>> --- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>> +++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
>> @@ -4,3 +4,7 @@ require python-numpy.inc
>>   RDEPENDS_${PN}_class-target_append = " \
>>       ${PYTHON_PN}-subprocess \
>>   "
>> +
>> +do_install_append(){
>> +        rm ${D}/${bindir}/f2py
>> +}
>>

Re: [PATCH] python-numpy: Avoid installing copy of f2py script

[Khem Raj]

On 5/17/19 4:49 PM, Alejandro Enedino Hernandez Samaniego wrote:
> Both python-numpy and python3-numpy try to install the file:
> 
> ${D}/${bindir}/f2py
> 
> which causes an error during do_rootfs since the package manager complains about that.
> 
> The numpy packages create basically copies of f2py script with the following names:
> f2py (on both)
> f2py2 (on python 2)
> f2py2.7 (on python 2)
> f2py3 (on python 3)
> f2py3.7 (on python 3)
> 
> Remove the copy of f2py from python-numpy in favor of using the one from python3
> to avoid installation issues at do_rootfs().
> 

what if one does not install py3 ?

> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
> ---
>   meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> index 5013789..a1133da 100644
> --- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> +++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
> @@ -4,3 +4,7 @@ require python-numpy.inc
>   RDEPENDS_${PN}_class-target_append = " \
>       ${PYTHON_PN}-subprocess \
>   "
> +
> +do_install_append(){
> +        rm ${D}/${bindir}/f2py
> +}
> 

[PATCH] python-numpy: Avoid installing copy of f2py script

[Alejandro Enedino Hernandez Samaniego]

Both python-numpy and python3-numpy try to install the file:

${D}/${bindir}/f2py

which causes an error during do_rootfs since the package manager complains about that.

The numpy packages create basically copies of f2py script with the following names:
f2py (on both)
f2py2 (on python 2)
f2py2.7 (on python 2)
f2py3 (on python 3)
f2py3.7 (on python 3)

Remove the copy of f2py from python-numpy in favor of using the one from python3
to avoid installation issues at do_rootfs().

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
---
 meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
index 5013789..a1133da 100644
--- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
+++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
@@ -4,3 +4,7 @@ require python-numpy.inc
 RDEPENDS_${PN}_class-target_append = " \
     ${PYTHON_PN}-subprocess \
 "
+
+do_install_append(){
+        rm ${D}/${bindir}/f2py
+}
-- 
2.7.4

[PATCH] python-numpy: Avoid installing copy of f2py script

[Alejandro Enedino Hernandez Samaniego]

Both python-numpy and python3-numpy try to install the file:

${D}/${bindir}/f2py

which causes an error during do_rootfs since the package manager complains about that.

The numpy packages create basically copies of f2py script with the following names:
f2py (on both)
f2py2 (on python 2)
f2py2.7 (on python 2)
f2py3 (on python 3)
f2py3.7 (on python 3)

Remove the copy of f2py from python-numpy in favor of using the one from python3
to avoid installation issues at do_rootfs().

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
---
 meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
index 5013789..a1133da 100644
--- a/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
+++ b/meta/recipes-devtools/python-numpy/python-numpy_1.16.3.bb
@@ -4,3 +4,7 @@ require python-numpy.inc
 RDEPENDS_${PN}_class-target_append = " \
     ${PYTHON_PN}-subprocess \
 "
+
+do_install_append(){
+        rm ${D}/${bindir}/f2py
+}
-- 
2.7.4