All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH ethtool] ethtool.spec: Use standard file location macros
@ 2019-05-20  8:09 Tariq Toukan
  2019-06-14 18:39 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2019-05-20  8:09 UTC (permalink / raw)
  To: John W. Linville; +Cc: netdev, Mikhael Goikhman, Tzafrir Cohen, Tariq Toukan

From: Mikhael Goikhman <migo@mellanox.com>

Use _prefix and _sbindir macros to allow building the package under a
different prefix.

Signed-off-by: Mikhael Goikhman <migo@mellanox.com>
Signed-off-by: Tzafrir Cohen <tzafrirc@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
 ethtool.spec.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ethtool.spec.in b/ethtool.spec.in
index 6e9e1f591240..9c01b07abf2b 100644
--- a/ethtool.spec.in
+++ b/ethtool.spec.in
@@ -22,7 +22,7 @@ network devices, especially Ethernet devices.
 
 
 %build
-CFLAGS="${RPM_OPT_FLAGS}" ./configure --prefix=/usr --mandir=%{_mandir}
+CFLAGS="${RPM_OPT_FLAGS}" ./configure --prefix=%{_prefix} --mandir=%{_mandir}
 make
 
 
@@ -32,7 +32,7 @@ make install DESTDIR=${RPM_BUILD_ROOT}
 
 %files
 %defattr(-,root,root)
-/usr/sbin/ethtool
+%{_sbindir}/ethtool
 %{_mandir}/man8/ethtool.8*
 %doc AUTHORS COPYING NEWS README
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH ethtool] ethtool.spec: Use standard file location macros
  2019-05-20  8:09 [PATCH ethtool] ethtool.spec: Use standard file location macros Tariq Toukan
@ 2019-06-14 18:39 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2019-06-14 18:39 UTC (permalink / raw)
  To: Tariq Toukan; +Cc: netdev, Mikhael Goikhman, Tzafrir Cohen

On Mon, May 20, 2019 at 11:09:40AM +0300, Tariq Toukan wrote:
> From: Mikhael Goikhman <migo@mellanox.com>
> 
> Use _prefix and _sbindir macros to allow building the package under a
> different prefix.
> 
> Signed-off-by: Mikhael Goikhman <migo@mellanox.com>
> Signed-off-by: Tzafrir Cohen <tzafrirc@mellanox.com>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
> ---
>  ethtool.spec.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks for the patch! Queued for next release...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-14 18:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-20  8:09 [PATCH ethtool] ethtool.spec: Use standard file location macros Tariq Toukan
2019-06-14 18:39 ` John W. Linville

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.