All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Jean Texier <pjtexier@koncepto.io>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] package/libubootenv: fix build with musl and static lib
Date: Tue, 21 May 2019 18:18:32 +0200	[thread overview]
Message-ID: <1558455512-31444-1-git-send-email-pjtexier@koncepto.io> (raw)

Libubootenv is a shared library, so add missing dependency on !BR2_STATIC_LIBS.

Also add BR2_TOOLCHAIN_USES_MUSL dependency to avoid 'unknown type name 'loff_t''.

Fixes:
 - http://autobuild.buildroot.net/results/206/206f1eba0dec39de1c02d760fa8f961d5a3879d0/
 - http://autobuild.buildroot.net/results/8a6/8a6b3087a4c2cb53f4e9b80183c7f4b0ea6ffd3b/

Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io>
---
 package/libubootenv/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libubootenv/Config.in b/package/libubootenv/Config.in
index 9be52c4..bad5aee 100644
--- a/package/libubootenv/Config.in
+++ b/package/libubootenv/Config.in
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_LIBUBOOTENV
 	bool "libubootenv"
+	depends on !BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_USES_MUSL # loff_t
 	select BR2_PACKAGE_ZLIB
 	help
 	  libubootenv is a library that provides a hardware independent
@@ -9,3 +11,6 @@ config BR2_PACKAGE_LIBUBOOTENV
 	  new tools build from the library and not from U-Boot.
 
 	  https://github.com/sbabic/libubootenv/
+
+comment "libubootenv application library needs a glibc or uClibc toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL
-- 
2.7.4

             reply	other threads:[~2019-05-21 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21 16:18 Pierre-Jean Texier [this message]
2019-05-21 18:59 ` [Buildroot] [PATCH/next 1/1] package/libubootenv: fix build with musl and static lib Thomas Petazzoni
2019-05-21 19:53   ` Pierre-Jean Texier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1558455512-31444-1-git-send-email-pjtexier@koncepto.io \
    --to=pjtexier@koncepto.io \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.