From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] package/libubootenv: fix build with musl and static lib
Date: Tue, 21 May 2019 20:59:11 +0200 [thread overview]
Message-ID: <20190521205911.5dca7351@windsurf.home> (raw)
In-Reply-To: <1558455512-31444-1-git-send-email-pjtexier@koncepto.io>
Hello Pierre-Jean,
On Tue, 21 May 2019 18:18:32 +0200
Pierre-Jean Texier <pjtexier@koncepto.io> wrote:
> Libubootenv is a shared library, so add missing dependency on !BR2_STATIC_LIBS.
I think instead src/CMakeLists.txt should be changed to not force
building a shared library.
> Also add BR2_TOOLCHAIN_USES_MUSL dependency to avoid 'unknown type name 'loff_t''.
And here I'm pretty sure musl provides loff_t, it's probably just a
missing #include.
> +comment "libubootenv application library needs a glibc or uClibc toolchain w/ dynamic library"
The correct comment would be:
comment "libubootenv needs a glibc or uClibc toolchain w/ dynamic library"
but I think it's better to fix the actual problems.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-21 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 16:18 [Buildroot] [PATCH/next 1/1] package/libubootenv: fix build with musl and static lib Pierre-Jean Texier
2019-05-21 18:59 ` Thomas Petazzoni [this message]
2019-05-21 19:53 ` Pierre-Jean Texier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521205911.5dca7351@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.