* [PATCH 0/2] tools: PCI: Fix broken pcitest compilation
@ 2019-05-23 20:14 ` Alan Mikhak
0 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
This patchset fixes a compiler error and two warnings that resulted in a
broken compilation of pcitest.
tools/pci/pcitest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/2] tools: PCI: Fix broken pcitest compilation
@ 2019-05-23 20:14 ` Alan Mikhak
0 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
This patchset fixes a compiler error and two warnings that resulted in a
broken compilation of pcitest.
tools/pci/pcitest.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/2] tools: PCI: Fix broken pcitest compilation
2019-05-23 20:14 ` Alan Mikhak
@ 2019-05-23 20:14 ` Alan Mikhak
-1 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
pcitest is currently broken due to the following compiler error
and related warning. Fix by changing the run_test() function
signature to return an integer result.
pcitest.c: In function run_test:
pcitest.c:143:9: warning: return with a value, in function
returning void
return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
pcitest.c: In function main:
pcitest.c:232:9: error: void value not ignored as it ought to be
return run_test(test);
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
---
tools/pci/pcitest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 5fa5c2bdd427..6dce894667f6 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -47,15 +47,15 @@ struct pci_test {
unsigned long size;
};
-static void run_test(struct pci_test *test)
+static int run_test(struct pci_test *test)
{
- long ret;
+ int ret = -EINVAL;
int fd;
fd = open(test->device, O_RDWR);
if (fd < 0) {
perror("can't open PCI Endpoint Test device");
- return;
+ return -ENODEV;
}
if (test->barnum >= 0 && test->barnum <= 5) {
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 1/2] tools: PCI: Fix broken pcitest compilation
@ 2019-05-23 20:14 ` Alan Mikhak
0 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
pcitest is currently broken due to the following compiler error
and related warning. Fix by changing the run_test() function
signature to return an integer result.
pcitest.c: In function run_test:
pcitest.c:143:9: warning: return with a value, in function
returning void
return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */
pcitest.c: In function main:
pcitest.c:232:9: error: void value not ignored as it ought to be
return run_test(test);
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
---
tools/pci/pcitest.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 5fa5c2bdd427..6dce894667f6 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -47,15 +47,15 @@ struct pci_test {
unsigned long size;
};
-static void run_test(struct pci_test *test)
+static int run_test(struct pci_test *test)
{
- long ret;
+ int ret = -EINVAL;
int fd;
fd = open(test->device, O_RDWR);
if (fd < 0) {
perror("can't open PCI Endpoint Test device");
- return;
+ return -ENODEV;
}
if (test->barnum >= 0 && test->barnum <= 5) {
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/2] tools: PCI: Fix broken pcitest compilation
2019-05-23 20:14 ` Alan Mikhak
@ 2019-05-23 20:29 ` Paul Walmsley
-1 siblings, 0 replies; 10+ messages in thread
From: Paul Walmsley @ 2019-05-23 20:29 UTC (permalink / raw)
To: Alan Mikhak
Cc: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv, palmer
On Thu, 23 May 2019, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@sifive.com>
Please drop this line.
> Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
This goes down below with the Signed-off-by: lines.
- Paul
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest
2019-05-23 20:14 ` Alan Mikhak
@ 2019-05-23 20:14 ` Alan Mikhak
-1 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Fix the following compiler warning in pcitest:
pcitest.c: In function main:
pcitest.c:214:4: warning: too many arguments for
format [-Wformat-extra-args]
"usage: %s [options]\n"
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
---
tools/pci/pcitest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 6dce894667f6..6f1303104d84 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -223,7 +223,7 @@ int main(int argc, char **argv)
"\t-r Read buffer test\n"
"\t-w Write buffer test\n"
"\t-c Copy buffer test\n"
- "\t-s <size> Size of buffer {default: 100KB}\n",
+ "\t-s <size> Size of buffer {default: 100KB}\n"
"\t-h Print this help message\n",
argv[0]);
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest
@ 2019-05-23 20:14 ` Alan Mikhak
0 siblings, 0 replies; 10+ messages in thread
From: Alan Mikhak @ 2019-05-23 20:14 UTC (permalink / raw)
To: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv,
palmer, paul.walmsley
Cc: Alan Mikhak
From: Alan Mikhak <alan.mikhak@sifive.com>
Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Fix the following compiler warning in pcitest:
pcitest.c: In function main:
pcitest.c:214:4: warning: too many arguments for
format [-Wformat-extra-args]
"usage: %s [options]\n"
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
---
tools/pci/pcitest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
index 6dce894667f6..6f1303104d84 100644
--- a/tools/pci/pcitest.c
+++ b/tools/pci/pcitest.c
@@ -223,7 +223,7 @@ int main(int argc, char **argv)
"\t-r Read buffer test\n"
"\t-w Write buffer test\n"
"\t-c Copy buffer test\n"
- "\t-s <size> Size of buffer {default: 100KB}\n",
+ "\t-s <size> Size of buffer {default: 100KB}\n"
"\t-h Print this help message\n",
argv[0]);
return -EINVAL;
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest
2019-05-23 20:14 ` Alan Mikhak
@ 2019-05-23 20:30 ` Paul Walmsley
-1 siblings, 0 replies; 10+ messages in thread
From: Paul Walmsley @ 2019-05-23 20:30 UTC (permalink / raw)
To: Alan Mikhak
Cc: linux-pci, linux-kernel, kishon, lorenzo.pieralisi, linux-riscv, palmer
On Thu, 23 May 2019, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@sifive.com>
>
> Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Same comments here as on the other patch - please drop the From: line
(since it's in the message header) and move the Fixes: line down with the
Signed-off-by:.
- Paul
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest
@ 2019-05-23 20:30 ` Paul Walmsley
0 siblings, 0 replies; 10+ messages in thread
From: Paul Walmsley @ 2019-05-23 20:30 UTC (permalink / raw)
To: Alan Mikhak
Cc: lorenzo.pieralisi, linux-pci, palmer, linux-kernel, kishon, linux-riscv
On Thu, 23 May 2019, Alan Mikhak wrote:
> From: Alan Mikhak <alan.mikhak@sifive.com>
>
> Fixes: fbca0b284bd0 ("tools: PCI: Add 'h' in optstring of getopt()")
Same comments here as on the other patch - please drop the From: line
(since it's in the message header) and move the Fixes: line down with the
Signed-off-by:.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-05-23 20:30 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-23 20:14 [PATCH 0/2] tools: PCI: Fix broken pcitest compilation Alan Mikhak
2019-05-23 20:14 ` Alan Mikhak
2019-05-23 20:14 ` [PATCH 1/2] " Alan Mikhak
2019-05-23 20:14 ` Alan Mikhak
2019-05-23 20:29 ` Paul Walmsley
2019-05-23 20:29 ` Paul Walmsley
2019-05-23 20:14 ` [PATCH 2/2] tools: PCI: Fix compiler warning in pcitest Alan Mikhak
2019-05-23 20:14 ` Alan Mikhak
2019-05-23 20:30 ` Paul Walmsley
2019-05-23 20:30 ` Paul Walmsley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.