* [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
@ 2019-05-24 7:32 ` Amelie Delaunay
0 siblings, 0 replies; 5+ messages in thread
From: Amelie Delaunay @ 2019-05-24 7:32 UTC (permalink / raw)
To: Lee Jones, Linus Walleij, Alexandre Torgue, Maxime Coquelin
Cc: linux-gpio, linux-kernel, linux-arm-kernel, linux-stm32,
kbuild-all, Randy Dunlap, Amelie Delaunay
When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
not exist:
drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
pctl->gpio_chip.of_node = np;
Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 1f380ca..7a33207 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -268,7 +268,7 @@ config PINCTRL_ST
config PINCTRL_STMFX
tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
depends on I2C
- depends on OF || COMPILE_TEST
+ depends on OF_GPIO
select GENERIC_PINCONF
select GPIOLIB_IRQCHIP
select MFD_STMFX
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
@ 2019-05-24 7:32 ` Amelie Delaunay
0 siblings, 0 replies; 5+ messages in thread
From: Amelie Delaunay @ 2019-05-24 7:32 UTC (permalink / raw)
To: Lee Jones, Linus Walleij, Alexandre Torgue, Maxime Coquelin
Cc: linux-gpio, linux-kernel, linux-arm-kernel, linux-stm32,
kbuild-all, Randy Dunlap, Amelie Delaunay
When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
not exist:
drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
pctl->gpio_chip.of_node = np;
Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 1f380ca..7a33207 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -268,7 +268,7 @@ config PINCTRL_ST
config PINCTRL_STMFX
tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
depends on I2C
- depends on OF || COMPILE_TEST
+ depends on OF_GPIO
select GENERIC_PINCONF
select GPIOLIB_IRQCHIP
select MFD_STMFX
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
@ 2019-05-24 7:32 ` Amelie Delaunay
0 siblings, 0 replies; 5+ messages in thread
From: Amelie Delaunay @ 2019-05-24 7:32 UTC (permalink / raw)
To: Lee Jones, Linus Walleij, Alexandre Torgue, Maxime Coquelin
Cc: Amelie Delaunay, Randy Dunlap, linux-kernel, linux-gpio,
kbuild-all, linux-stm32, linux-arm-kernel
When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
not exist:
drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
pctl->gpio_chip.of_node = np;
Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
drivers/pinctrl/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 1f380ca..7a33207 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -268,7 +268,7 @@ config PINCTRL_ST
config PINCTRL_STMFX
tristate "STMicroelectronics STMFX GPIO expander pinctrl driver"
depends on I2C
- depends on OF || COMPILE_TEST
+ depends on OF_GPIO
select GENERIC_PINCONF
select GPIOLIB_IRQCHIP
select MFD_STMFX
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
2019-05-24 7:32 ` Amelie Delaunay
@ 2019-05-24 8:10 ` Linus Walleij
-1 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-05-24 8:10 UTC (permalink / raw)
To: Amelie Delaunay
Cc: Lee Jones, Alexandre Torgue, Maxime Coquelin,
open list:GPIO SUBSYSTEM, linux-kernel, Linux ARM, linux-stm32,
kbuild-all, Randy Dunlap
On Fri, May 24, 2019 at 9:32 AM Amelie Delaunay <amelie.delaunay@st.com> wrote:
> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
> not exist:
> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
> drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
> pctl->gpio_chip.of_node = np;
>
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
@ 2019-05-24 8:10 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2019-05-24 8:10 UTC (permalink / raw)
To: Amelie Delaunay
Cc: Alexandre Torgue, Randy Dunlap, linux-kernel,
open list:GPIO SUBSYSTEM, kbuild-all, Maxime Coquelin, Lee Jones,
linux-stm32, Linux ARM
On Fri, May 24, 2019 at 9:32 AM Amelie Delaunay <amelie.delaunay@st.com> wrote:
> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does
> not exist:
> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe':
> drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node'
> pctl->gpio_chip.of_node = np;
>
> Fixes: 1490d9f841b1 ("pinctrl: Add STMFX GPIO expander Pinctrl/GPIO driver")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Patch applied for fixes.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-24 8:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-24 7:32 [PATCH v2] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined Amelie Delaunay
2019-05-24 7:32 ` Amelie Delaunay
2019-05-24 7:32 ` Amelie Delaunay
2019-05-24 8:10 ` Linus Walleij
2019-05-24 8:10 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.