* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
@ 2019-05-24 9:25 ` Chunfeng Yun
0 siblings, 0 replies; 13+ messages in thread
From: Chunfeng Yun @ 2019-05-24 9:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, Randy Dunlap, linux-kernel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > there is an issue:
> >
> > ld:
> > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> >
> > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > and use NULL instead.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Why resend?
Sorry, I should send it out as v2 due to acked-by is added.
>
> > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > index 62c57ddc554e..b7c86ccd50b4 100644
> > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> >
> > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > {
> > - ssusb->dbgfs_root =
> > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
>
> This moves the directory to a new location no matter what the
> configuration is. What's wrong with where it is today?
it seems usb_debug_root is only for host, but not for gadget only, it's
defined and created in usb/core/usb.c
> And shoudn't we
> create the usb root directory if only gadget is enabled?
Yes, need modify udc/core.c, it's better if support it, do you want me
to send a patch for it?
Thanks
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
@ 2019-05-24 9:25 ` Chunfeng Yun
0 siblings, 0 replies; 13+ messages in thread
From: Chunfeng Yun @ 2019-05-24 9:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Brugger, Randy Dunlap, linux-usb, linux-arm-kernel,
linux-mediatek, linux-kernel
On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > there is an issue:
> >
> > ld:
> > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> >
> > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > and use NULL instead.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Why resend?
Sorry, I should send it out as v2 due to acked-by is added.
>
> > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > index 62c57ddc554e..b7c86ccd50b4 100644
> > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> >
> > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > {
> > - ssusb->dbgfs_root =
> > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
>
> This moves the directory to a new location no matter what the
> configuration is. What's wrong with where it is today?
it seems usb_debug_root is only for host, but not for gadget only, it's
defined and created in usb/core/usb.c
> And shoudn't we
> create the usb root directory if only gadget is enabled?
Yes, need modify udc/core.c, it's better if support it, do you want me
to send a patch for it?
Thanks
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
2019-05-24 9:25 ` Chunfeng Yun
@ 2019-05-24 11:33 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-24 11:33 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Matthias Brugger, Randy Dunlap, linux-usb, linux-arm-kernel,
linux-mediatek, linux-kernel
On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > there is an issue:
> > >
> > > ld:
> > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > >
> > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > and use NULL instead.
> > >
> > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > ---
> > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Why resend?
> Sorry, I should send it out as v2 due to acked-by is added.
Then please document that below the --- line, otherwise I have no idea :(
> > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > >
> > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > {
> > > - ssusb->dbgfs_root =
> > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> >
> > This moves the directory to a new location no matter what the
> > configuration is. What's wrong with where it is today?
> it seems usb_debug_root is only for host, but not for gadget only, it's
> defined and created in usb/core/usb.c
True, but you just moved the root if usb core is present too.
> > And shoudn't we
> > create the usb root directory if only gadget is enabled?
> Yes, need modify udc/core.c, it's better if support it, do you want me
> to send a patch for it?
Yes please, let's see what that looks like.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
@ 2019-05-24 11:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 13+ messages in thread
From: Greg Kroah-Hartman @ 2019-05-24 11:33 UTC (permalink / raw)
To: Chunfeng Yun
Cc: linux-usb, Randy Dunlap, linux-kernel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > there is an issue:
> > >
> > > ld:
> > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > >
> > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > and use NULL instead.
> > >
> > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > ---
> > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Why resend?
> Sorry, I should send it out as v2 due to acked-by is added.
Then please document that below the --- line, otherwise I have no idea :(
> > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > >
> > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > {
> > > - ssusb->dbgfs_root =
> > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> >
> > This moves the directory to a new location no matter what the
> > configuration is. What's wrong with where it is today?
> it seems usb_debug_root is only for host, but not for gadget only, it's
> defined and created in usb/core/usb.c
True, but you just moved the root if usb core is present too.
> > And shoudn't we
> > create the usb root directory if only gadget is enabled?
> Yes, need modify udc/core.c, it's better if support it, do you want me
> to send a patch for it?
Yes please, let's see what that looks like.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
2019-05-24 11:33 ` Greg Kroah-Hartman
(?)
@ 2019-05-27 2:56 ` Chunfeng Yun
-1 siblings, 0 replies; 13+ messages in thread
From: Chunfeng Yun @ 2019-05-27 2:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Brugger, Randy Dunlap, linux-usb, linux-arm-kernel,
linux-mediatek, linux-kernel
On Fri, 2019-05-24 at 13:33 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> > On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > > there is an issue:
> > > >
> > > > ld:
> > > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > > >
> > > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > > and use NULL instead.
> > > >
> > > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > ---
> > > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > Why resend?
> > Sorry, I should send it out as v2 due to acked-by is added.
>
> Then please document that below the --- line, otherwise I have no idea :(
Ok
>
> > > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > > >
> > > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > > {
> > > > - ssusb->dbgfs_root =
> > > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> > >
> > > This moves the directory to a new location no matter what the
> > > configuration is. What's wrong with where it is today?
> > it seems usb_debug_root is only for host, but not for gadget only, it's
> > defined and created in usb/core/usb.c
>
> True, but you just moved the root if usb core is present too.
It's an easy way, and other dual-role driver also uses NULL
>
> > > And shoudn't we
> > > create the usb root directory if only gadget is enabled?
> > Yes, need modify udc/core.c, it's better if support it, do you want me
> > to send a patch for it?
>
> Yes please, let's see what that looks like.
I'll do it.
Thanks
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
@ 2019-05-27 2:56 ` Chunfeng Yun
0 siblings, 0 replies; 13+ messages in thread
From: Chunfeng Yun @ 2019-05-27 2:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-usb, Randy Dunlap, linux-kernel, linux-mediatek,
Matthias Brugger, linux-arm-kernel
On Fri, 2019-05-24 at 13:33 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> > On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > > there is an issue:
> > > >
> > > > ld:
> > > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > > >
> > > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > > and use NULL instead.
> > > >
> > > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > ---
> > > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > Why resend?
> > Sorry, I should send it out as v2 due to acked-by is added.
>
> Then please document that below the --- line, otherwise I have no idea :(
Ok
>
> > > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > > >
> > > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > > {
> > > > - ssusb->dbgfs_root =
> > > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> > >
> > > This moves the directory to a new location no matter what the
> > > configuration is. What's wrong with where it is today?
> > it seems usb_debug_root is only for host, but not for gadget only, it's
> > defined and created in usb/core/usb.c
>
> True, but you just moved the root if usb core is present too.
It's an easy way, and other dual-role driver also uses NULL
>
> > > And shoudn't we
> > > create the usb root directory if only gadget is enabled?
> > Yes, need modify udc/core.c, it's better if support it, do you want me
> > to send a patch for it?
>
> Yes please, let's see what that looks like.
I'll do it.
Thanks
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [RESEND PATCH] usb: mtu3: fix up undefined reference to usb_debug_root
@ 2019-05-27 2:56 ` Chunfeng Yun
0 siblings, 0 replies; 13+ messages in thread
From: Chunfeng Yun @ 2019-05-27 2:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Matthias Brugger, Randy Dunlap, linux-usb, linux-arm-kernel,
linux-mediatek, linux-kernel
On Fri, 2019-05-24 at 13:33 +0200, Greg Kroah-Hartman wrote:
> On Fri, May 24, 2019 at 05:25:51PM +0800, Chunfeng Yun wrote:
> > On Fri, 2019-05-24 at 09:45 +0200, Greg Kroah-Hartman wrote:
> > > On Fri, May 24, 2019 at 02:11:33PM +0800, Chunfeng Yun wrote:
> > > > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set,
> > > > there is an issue:
> > > >
> > > > ld:
> > > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root':
> > > > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root'
> > > >
> > > > usb_debug_root is only built when CONFIG_USB is enabled, so here drop it
> > > > and use NULL instead.
> > > >
> > > > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > > > Acked-by: Randy Dunlap <rdunlap@infradead.org>
> > > > ---
> > > > drivers/usb/mtu3/mtu3_debugfs.c | 3 +--
> > > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > Why resend?
> > Sorry, I should send it out as v2 due to acked-by is added.
>
> Then please document that below the --- line, otherwise I have no idea :(
Ok
>
> > > > diff --git a/drivers/usb/mtu3/mtu3_debugfs.c b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > index 62c57ddc554e..b7c86ccd50b4 100644
> > > > --- a/drivers/usb/mtu3/mtu3_debugfs.c
> > > > +++ b/drivers/usb/mtu3/mtu3_debugfs.c
> > > > @@ -528,8 +528,7 @@ void ssusb_dr_debugfs_init(struct ssusb_mtk *ssusb)
> > > >
> > > > void ssusb_debugfs_create_root(struct ssusb_mtk *ssusb)
> > > > {
> > > > - ssusb->dbgfs_root =
> > > > - debugfs_create_dir(dev_name(ssusb->dev), usb_debug_root);
> > > > + ssusb->dbgfs_root = debugfs_create_dir(dev_name(ssusb->dev), NULL);
> > >
> > > This moves the directory to a new location no matter what the
> > > configuration is. What's wrong with where it is today?
> > it seems usb_debug_root is only for host, but not for gadget only, it's
> > defined and created in usb/core/usb.c
>
> True, but you just moved the root if usb core is present too.
It's an easy way, and other dual-role driver also uses NULL
>
> > > And shoudn't we
> > > create the usb root directory if only gadget is enabled?
> > Yes, need modify udc/core.c, it's better if support it, do you want me
> > to send a patch for it?
>
> Yes please, let's see what that looks like.
I'll do it.
Thanks
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 13+ messages in thread