All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Li Jun <jun.li@nxp.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Min Guo <min.guo@mediatek.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	Biju Das <biju.das@bp.renesas.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Yu Chen <chenyu56@huawei.com>
Subject: [PATCH v6 08/10] usb: roles: get usb-role-switch from parent
Date: Wed, 29 May 2019 15:43:46 +0800	[thread overview]
Message-ID: <1559115828-19146-9-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1559115828-19146-1-git-send-email-chunfeng.yun@mediatek.com>

when the USB host controller is the parent of the connector,
usually type-B, sometimes don't need the graph, so we should
check whether it's parent registers usb-role-switch or not
firstly, and get it if exists.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v6:
  new patch
---
 drivers/usb/roles/class.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index aab795b54c7f..1f6af0ef3954 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -114,6 +114,19 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
 	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
 }
 
+static struct usb_role_switch *
+usb_role_switch_is_parent(struct fwnode_handle *fwnode)
+{
+	struct fwnode_handle *parent = fwnode_get_parent(fwnode);
+	struct device *dev;
+
+	if (!parent || !fwnode_property_present(parent, "usb-role-switch"))
+		return NULL;
+
+	dev = class_find_device(role_class, NULL, parent, switch_fwnode_match);
+	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
+}
+
 /**
  * usb_role_switch_get - Find USB role switch linked with the caller
  * @dev: The caller device
@@ -125,8 +138,10 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev)
 {
 	struct usb_role_switch *sw;
 
-	sw = device_connection_find_match(dev, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(dev_fwnode(dev));
+	if (!sw)
+		sw = device_connection_find_match(dev, "usb-role-switch", NULL,
+						  usb_role_switch_match);
 
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
@@ -146,8 +161,10 @@ struct usb_role_switch *fwnode_usb_role_switch_get(struct fwnode_handle *fwnode)
 {
 	struct usb_role_switch *sw;
 
-	sw = fwnode_connection_find_match(fwnode, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(fwnode);
+	if (!sw)
+		sw = fwnode_connection_find_match(fwnode, "usb-role-switch",
+						  NULL, usb_role_switch_match);
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
 
-- 
2.21.0


WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Li Jun <jun.li@nxp.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Min Guo <min.guo@mediatek.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Biju Das <biju.das@bp.renesas.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Yu Chen <chenyu56@huawei.com>
Subject: [PATCH v6 08/10] usb: roles: get usb-role-switch from parent
Date: Wed, 29 May 2019 15:43:46 +0800	[thread overview]
Message-ID: <1559115828-19146-9-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1559115828-19146-1-git-send-email-chunfeng.yun@mediatek.com>

when the USB host controller is the parent of the connector,
usually type-B, sometimes don't need the graph, so we should
check whether it's parent registers usb-role-switch or not
firstly, and get it if exists.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v6:
  new patch
---
 drivers/usb/roles/class.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index aab795b54c7f..1f6af0ef3954 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -114,6 +114,19 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
 	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
 }
 
+static struct usb_role_switch *
+usb_role_switch_is_parent(struct fwnode_handle *fwnode)
+{
+	struct fwnode_handle *parent = fwnode_get_parent(fwnode);
+	struct device *dev;
+
+	if (!parent || !fwnode_property_present(parent, "usb-role-switch"))
+		return NULL;
+
+	dev = class_find_device(role_class, NULL, parent, switch_fwnode_match);
+	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
+}
+
 /**
  * usb_role_switch_get - Find USB role switch linked with the caller
  * @dev: The caller device
@@ -125,8 +138,10 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev)
 {
 	struct usb_role_switch *sw;
 
-	sw = device_connection_find_match(dev, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(dev_fwnode(dev));
+	if (!sw)
+		sw = device_connection_find_match(dev, "usb-role-switch", NULL,
+						  usb_role_switch_match);
 
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
@@ -146,8 +161,10 @@ struct usb_role_switch *fwnode_usb_role_switch_get(struct fwnode_handle *fwnode)
 {
 	struct usb_role_switch *sw;
 
-	sw = fwnode_connection_find_match(fwnode, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(fwnode);
+	if (!sw)
+		sw = fwnode_connection_find_match(fwnode, "usb-role-switch",
+						  NULL, usb_role_switch_match);
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
 
-- 
2.21.0

WARNING: multiple messages have this Message-ID (diff)
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-usb@vger.kernel.org, Yu Chen <chenyu56@huawei.com>,
	linux-kernel@vger.kernel.org, Biju Das <biju.das@bp.renesas.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Min Guo <min.guo@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	linux-arm-kernel@lists.infradead.org, Li Jun <jun.li@nxp.com>
Subject: [PATCH v6 08/10] usb: roles: get usb-role-switch from parent
Date: Wed, 29 May 2019 15:43:46 +0800	[thread overview]
Message-ID: <1559115828-19146-9-git-send-email-chunfeng.yun@mediatek.com> (raw)
In-Reply-To: <1559115828-19146-1-git-send-email-chunfeng.yun@mediatek.com>

when the USB host controller is the parent of the connector,
usually type-B, sometimes don't need the graph, so we should
check whether it's parent registers usb-role-switch or not
firstly, and get it if exists.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v6:
  new patch
---
 drivers/usb/roles/class.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c
index aab795b54c7f..1f6af0ef3954 100644
--- a/drivers/usb/roles/class.c
+++ b/drivers/usb/roles/class.c
@@ -114,6 +114,19 @@ static void *usb_role_switch_match(struct device_connection *con, int ep,
 	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
 }
 
+static struct usb_role_switch *
+usb_role_switch_is_parent(struct fwnode_handle *fwnode)
+{
+	struct fwnode_handle *parent = fwnode_get_parent(fwnode);
+	struct device *dev;
+
+	if (!parent || !fwnode_property_present(parent, "usb-role-switch"))
+		return NULL;
+
+	dev = class_find_device(role_class, NULL, parent, switch_fwnode_match);
+	return dev ? to_role_switch(dev) : ERR_PTR(-EPROBE_DEFER);
+}
+
 /**
  * usb_role_switch_get - Find USB role switch linked with the caller
  * @dev: The caller device
@@ -125,8 +138,10 @@ struct usb_role_switch *usb_role_switch_get(struct device *dev)
 {
 	struct usb_role_switch *sw;
 
-	sw = device_connection_find_match(dev, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(dev_fwnode(dev));
+	if (!sw)
+		sw = device_connection_find_match(dev, "usb-role-switch", NULL,
+						  usb_role_switch_match);
 
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
@@ -146,8 +161,10 @@ struct usb_role_switch *fwnode_usb_role_switch_get(struct fwnode_handle *fwnode)
 {
 	struct usb_role_switch *sw;
 
-	sw = fwnode_connection_find_match(fwnode, "usb-role-switch", NULL,
-					  usb_role_switch_match);
+	sw = usb_role_switch_is_parent(fwnode);
+	if (!sw)
+		sw = fwnode_connection_find_match(fwnode, "usb-role-switch",
+						  NULL, usb_role_switch_match);
 	if (!IS_ERR_OR_NULL(sw))
 		WARN_ON(!try_module_get(sw->dev.parent->driver->owner));
 
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-05-29  7:44 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  7:43 [PATCH v6 00/10] add USB Type-B GPIO connector driver Chunfeng Yun
2019-05-29  7:43 ` Chunfeng Yun
2019-05-29  7:43 ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 01/10] dt-binding: usb: add usb-role-switch property Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 02/10] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 03/10] dt-bindings: usb: add binding for Type-B GPIO connector driver Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 04/10] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 05/10] usb: roles: Introduce stubs for the exiting functions in role.h Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-06-03 13:19   ` Greg Kroah-Hartman
2019-06-03 13:19     ` Greg Kroah-Hartman
2019-06-03 13:19     ` Greg Kroah-Hartman
2019-06-04  6:43     ` Chunfeng Yun
2019-06-04  6:43       ` Chunfeng Yun
2019-06-04  6:43       ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 06/10] device connection: Add fwnode_connection_find_match() Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-31  7:40   ` Biju Das
2019-05-31  7:40     ` Biju Das
2019-05-31  7:40     ` Biju Das
2019-06-07 10:30   ` Heikki Krogerus
2019-06-07 10:30     ` Heikki Krogerus
2019-06-07 10:30     ` Heikki Krogerus
2019-06-10  1:50     ` Chunfeng Yun
2019-06-10  1:50       ` Chunfeng Yun
2019-06-10  1:50       ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 07/10] usb: roles: Add fwnode_usb_role_switch_get() function Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-31  7:41   ` Biju Das
2019-05-31  7:41     ` Biju Das
2019-05-31  7:41     ` Biju Das
2019-06-03 13:19   ` Greg Kroah-Hartman
2019-06-03 13:19     ` Greg Kroah-Hartman
2019-06-04  6:42     ` Chunfeng Yun
2019-06-04  6:42       ` Chunfeng Yun
2019-06-04  6:42       ` Chunfeng Yun
2019-05-29  7:43 ` Chunfeng Yun [this message]
2019-05-29  7:43   ` [PATCH v6 08/10] usb: roles: get usb-role-switch from parent Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 09/10] usb: roles: add USB Type-B GPIO connector driver Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-06-05  8:45   ` Andy Shevchenko
2019-06-05  8:45     ` Andy Shevchenko
2019-06-05  8:45     ` Andy Shevchenko
2019-06-06  2:53     ` Chunfeng Yun
2019-06-06  2:53       ` Chunfeng Yun
2019-06-06  2:53       ` Chunfeng Yun
2019-06-06  6:31       ` Andy Shevchenko
2019-06-06  6:31         ` Andy Shevchenko
2019-06-06  6:31         ` Andy Shevchenko
2019-06-11  5:47         ` Chunfeng Yun
2019-06-11  5:47           ` Chunfeng Yun
2019-06-11  5:47           ` Chunfeng Yun
2019-06-10 10:33   ` Nagarjuna Kristam
2019-06-10 10:33     ` Nagarjuna Kristam
2019-06-10 10:33     ` Nagarjuna Kristam
2019-06-11  5:59     ` Chunfeng Yun
2019-06-11  5:59       ` Chunfeng Yun
2019-06-11  5:59       ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 10/10] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun
2019-05-29  7:43   ` Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1559115828-19146-9-git-send-email-chunfeng.yun@mediatek.com \
    --to=chunfeng.yun@mediatek.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=badhri@google.com \
    --cc=biju.das@bp.renesas.com \
    --cc=chenyu56@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jun.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=min.guo@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.