All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s
@ 2019-05-30  8:07 Fabrizio Castro
  2019-05-30  8:07 ` [PATCH 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-05-30  8:07 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

Dear All,

SDR50 has been broken on both the iwg20d and the iwg23s since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors").
Other Renesas' platforms may be affected as well due
to the lack of property enable-active-high.
This patch series fixes the problem with the iWave platforms.

Thanks,
Fab

Fabrizio Castro (2):
  ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
  ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator

 arch/arm/boot/dts/iwg20d-q7-common.dtsi   | 4 +++-
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
  2019-05-30  8:07 [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
@ 2019-05-30  8:07 ` Fabrizio Castro
  2019-05-30  8:07 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
  2019-06-03  8:27   ` Fabrizio Castro
  2 siblings, 0 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-05-30  8:07 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

The GPIO regulator is using descriptors since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
leading to calls into gpiolib now, which in turn consider
gpio2 30 as active low due to the fact that the corresponding
DT node is missing property enable-active-high, breaking
the SDR50 functionality.
This patch fixes the regulator DT definition, and that fixes
SDR50.

Fixes: 029efb3a03c5 ("ARM: dts: iwg20d-q7: Add SDHI1 support")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/iwg20d-q7-common.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index e2b1ab9..87be070 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -87,7 +87,9 @@
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
+		enable-active-high;
+
+		gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
 		gpios-states = <1>;
 		states = <3300000 1
 			  1800000 0>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
  2019-05-30  8:07 [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
  2019-05-30  8:07 ` [PATCH 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
@ 2019-05-30  8:07 ` Fabrizio Castro
  2019-06-03  8:27   ` Fabrizio Castro
  2 siblings, 0 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-05-30  8:07 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

The GPIO regulator is using descriptors since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
leading to calls into gpiolib now, which in turn consider
gpio2 24 as active low due to the fact that the corresponding
DT node is missing property enable-active-high, breaking
the SDR50 functionality.
This patch fixes the regulator DT definition, and that fixes
SDR50.

Fixes: 9eb36b945b5c ("ARM: dts: iwg23s-sbc: Add uSD and eMMC support")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index af78e77..a199ded 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -63,7 +63,9 @@
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		gpios = <&gpio2 24 GPIO_ACTIVE_LOW>;
+		enable-active-high;
+
+		gpios = <&gpio2 24 GPIO_ACTIVE_HIGH>;
 		gpios-states = <1>;
 		states = <3300000 1
 			  1800000 0>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* RE: [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s
  2019-05-30  8:07 [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
@ 2019-06-03  8:27   ` Fabrizio Castro
  2019-05-30  8:07 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
  2019-06-03  8:27   ` Fabrizio Castro
  2 siblings, 0 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-06-03  8:27 UTC (permalink / raw)
  To: Fabrizio Castro, Simon Horman, Geert Uytterhoeven, Rob Herring,
	Mark Rutland
  Cc: Magnus Damm, linux-renesas-soc, devicetree, Chris Paterson, Biju Das

Actually, it looks like that since commit
0e7d6f940164 ("gpio: of: Apply regulator-gpio quirk only to enable-gpios")
property enable-active-high is not necessary anymore.
I am going to send a v2 to only flip the polarity of the GPIOs.

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 30 May 2019 09:08
> Subject: [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s
> 
> Dear All,
> 
> SDR50 has been broken on both the iwg20d and the iwg23s since
> commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors").
> Other Renesas' platforms may be affected as well due
> to the lack of property enable-active-high.
> This patch series fixes the problem with the iWave platforms.
> 
> Thanks,
> Fab
> 
> Fabrizio Castro (2):
>   ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
>   ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
> 
>  arch/arm/boot/dts/iwg20d-q7-common.dtsi   | 4 +++-
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s
@ 2019-06-03  8:27   ` Fabrizio Castro
  0 siblings, 0 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-06-03  8:27 UTC (permalink / raw)
  To: Fabrizio Castro, Simon Horman, Geert Uytterhoeven, Rob Herring,
	Mark Rutland
  Cc: Magnus Damm, linux-renesas-soc, devicetree, Chris Paterson, Biju Das

Actually, it looks like that since commit
0e7d6f940164 ("gpio: of: Apply regulator-gpio quirk only to enable-gpios")
property enable-active-high is not necessary anymore.
I am going to send a v2 to only flip the polarity of the GPIOs.

Thanks,
Fab

> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 30 May 2019 09:08
> Subject: [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s
> 
> Dear All,
> 
> SDR50 has been broken on both the iwg20d and the iwg23s since
> commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors").
> Other Renesas' platforms may be affected as well due
> to the lack of property enable-active-high.
> This patch series fixes the problem with the iWave platforms.
> 
> Thanks,
> Fab
> 
> Fabrizio Castro (2):
>   ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
>   ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
> 
>  arch/arm/boot/dts/iwg20d-q7-common.dtsi   | 4 +++-
>  arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-03  8:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-30  8:07 [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
2019-05-30  8:07 ` [PATCH 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
2019-05-30  8:07 ` [PATCH 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
2019-06-03  8:27 ` [PATCH 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
2019-06-03  8:27   ` Fabrizio Castro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.