* [PATCH net-next] net: ena: Fix Kconfig dependencies X86
@ 2018-10-17 8:16 netanel
2018-10-17 8:37 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: netanel @ 2018-10-17 8:16 UTC (permalink / raw)
To: davem, netdev
Cc: akiyano, alisaidi, Netanel Belgazal, dwmw, zorik, matua, saeedb,
msw, aliguori, nafea, gtzalik
From: Netanel Belgazal <netanel@amazon.com>
The Kconfig limitation of X86 is to too wide.
The ENA driver only requires a little endian dependency.
Change the dependency to be on little endian CPU.
Signed-off-by: Netanel Belgazal <netanel@amazon.com>
---
drivers/net/ethernet/amazon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
index 99b30353541a..f4d16c7e104f 100644
--- a/drivers/net/ethernet/amazon/Kconfig
+++ b/drivers/net/ethernet/amazon/Kconfig
@@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON
config ENA_ETHERNET
tristate "Elastic Network Adapter (ENA) support"
- depends on (PCI_MSI && X86)
+ depends on (PCI_MSI && !CPU_BIG_ENDIAN)
---help---
This driver supports Elastic Network Adapter (ENA)"
--
2.15.2.AMZN
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86
2018-10-17 8:16 [PATCH net-next] net: ena: Fix Kconfig dependencies X86 netanel
@ 2018-10-17 8:37 ` Sergei Shtylyov
2018-10-17 10:01 ` Belgazal, Netanel
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2018-10-17 8:37 UTC (permalink / raw)
To: netanel, davem, netdev
Cc: akiyano, alisaidi, dwmw, zorik, matua, saeedb, msw, aliguori,
nafea, gtzalik
Hello!
On 17.10.2018 11:16, netanel@amazon.com wrote:
> From: Netanel Belgazal <netanel@amazon.com>
>
> The Kconfig limitation of X86 is to too wide.
> The ENA driver only requires a little endian dependency.
>
> Change the dependency to be on little endian CPU.
>
> Signed-off-by: Netanel Belgazal <netanel@amazon.com>
> ---
> drivers/net/ethernet/amazon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
> index 99b30353541a..f4d16c7e104f 100644
> --- a/drivers/net/ethernet/amazon/Kconfig
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON
>
> config ENA_ETHERNET
> tristate "Elastic Network Adapter (ENA) support"
> - depends on (PCI_MSI && X86)
> + depends on (PCI_MSI && !CPU_BIG_ENDIAN)
Parens not needed here. High time to remove them, I think.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86
2018-10-17 8:37 ` Sergei Shtylyov
@ 2018-10-17 10:01 ` Belgazal, Netanel
0 siblings, 0 replies; 3+ messages in thread
From: Belgazal, Netanel @ 2018-10-17 10:01 UTC (permalink / raw)
To: Sergei Shtylyov, davem, netdev
Cc: Kiyanovski, Arthur, Saidi, Ali, Woodhouse, David, Machulsky,
Zorik, Matushevsky, Alexander, Bshara, Saeed, Wilson, Matt,
Liguori, Anthony, Bshara, Nafea, Tzalik, Guy
Sure.
Removing them and resubmit.
On 10/17/18, 11:37 AM, "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com> wrote:
Hello!
On 17.10.2018 11:16, netanel@amazon.com wrote:
> From: Netanel Belgazal <netanel@amazon.com>
>
> The Kconfig limitation of X86 is to too wide.
> The ENA driver only requires a little endian dependency.
>
> Change the dependency to be on little endian CPU.
>
> Signed-off-by: Netanel Belgazal <netanel@amazon.com>
> ---
> drivers/net/ethernet/amazon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
> index 99b30353541a..f4d16c7e104f 100644
> --- a/drivers/net/ethernet/amazon/Kconfig
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON
>
> config ENA_ETHERNET
> tristate "Elastic Network Adapter (ENA) support"
> - depends on (PCI_MSI && X86)
> + depends on (PCI_MSI && !CPU_BIG_ENDIAN)
Parens not needed here. High time to remove them, I think.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-17 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-17 8:16 [PATCH net-next] net: ena: Fix Kconfig dependencies X86 netanel
2018-10-17 8:37 ` Sergei Shtylyov
2018-10-17 10:01 ` Belgazal, Netanel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.