All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bitan Biswas <bbiswas@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, Peter Rosin <peda@axentia.se>,
	Wolfram Sang <wsa@the-dreams.de>,
	Dmitry Osipenko <digetx@gmail.com>
Cc: Shardar Mohammed <smohammed@nvidia.com>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Mantravadi Karthik <mkarthik@nvidia.com>,
	Bitan Biswas <bbiswas@nvidia.com>
Subject: [PATCH V4 4/6] i2c: tegra: add spinlock definition comment
Date: Mon, 10 Jun 2019 10:08:33 -0700	[thread overview]
Message-ID: <1560186515-30797-4-git-send-email-bbiswas@nvidia.com> (raw)
In-Reply-To: <1560186515-30797-1-git-send-email-bbiswas@nvidia.com>

Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+       spinlock_t xfer_lock;

Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/i2c/busses/i2c-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 2d381de..bececa6 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -269,6 +269,7 @@ struct tegra_i2c_dev {
 	u32 bus_clk_rate;
 	u16 clk_divisor_non_hs_mode;
 	bool is_multimaster_mode;
+	/* xfer_lock: lock to serialize transfer submission and processing */
 	spinlock_t xfer_lock;
 	struct dma_chan *tx_dma_chan;
 	struct dma_chan *rx_dma_chan;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Bitan Biswas <bbiswas@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Peter Rosin <peda@axentia.se>,
	Wolfram Sang <wsa@the-dreams.de>,
	Dmitry Osipenko <digetx@gmail.com>
Cc: Shardar Mohammed <smohammed@nvidia.com>,
	Sowjanya Komatineni <skomatineni@nvidia.com>,
	Mantravadi Karthik <mkarthik@nvidia.com>,
	Bitan Biswas <bbiswas@nvidia.com>
Subject: [PATCH V4 4/6] i2c: tegra: add spinlock definition comment
Date: Mon, 10 Jun 2019 10:08:33 -0700	[thread overview]
Message-ID: <1560186515-30797-4-git-send-email-bbiswas@nvidia.com> (raw)
In-Reply-To: <1560186515-30797-1-git-send-email-bbiswas@nvidia.com>

Fix checkpatch.pl CHECK as follows:
CHECK: spinlock_t definition without comment
+       spinlock_t xfer_lock;

Signed-off-by: Bitan Biswas <bbiswas@nvidia.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/i2c/busses/i2c-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 2d381de..bececa6 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -269,6 +269,7 @@ struct tegra_i2c_dev {
 	u32 bus_clk_rate;
 	u16 clk_divisor_non_hs_mode;
 	bool is_multimaster_mode;
+	/* xfer_lock: lock to serialize transfer submission and processing */
 	spinlock_t xfer_lock;
 	struct dma_chan *tx_dma_chan;
 	struct dma_chan *rx_dma_chan;
-- 
2.7.4


  parent reply	other threads:[~2019-06-10 17:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10 17:08 [PATCH V4 1/6] i2c: tegra: clean up macros Bitan Biswas
2019-06-10 17:08 ` Bitan Biswas
2019-06-10 17:08 ` [PATCH V4 2/6] i2c: tegra: remove unnecessary variable init Bitan Biswas
2019-06-10 17:08   ` Bitan Biswas
2019-06-10 17:08 ` [PATCH V4 3/6] i2c: tegra: fix alignment and spacing violations Bitan Biswas
2019-06-10 17:08   ` Bitan Biswas
2019-06-10 17:08 ` Bitan Biswas [this message]
2019-06-10 17:08   ` [PATCH V4 4/6] i2c: tegra: add spinlock definition comment Bitan Biswas
2019-06-10 17:08 ` [PATCH V4 5/6] i2c: tegra: fix msleep warning Bitan Biswas
2019-06-10 17:08   ` Bitan Biswas
2019-06-10 17:08 ` [PATCH V4 6/6] i2c: tegra: remove BUG, BUG_ON Bitan Biswas
2019-06-10 17:08   ` Bitan Biswas
2019-06-10 18:12   ` Dmitry Osipenko
2019-06-10 18:18     ` Dmitry Osipenko
2019-06-10 19:41     ` Bitan Biswas
2019-06-10 19:41       ` Bitan Biswas
2019-06-10 21:00       ` Dmitry Osipenko
2019-06-11  7:38         ` Bitan Biswas
2019-06-11  7:38           ` Bitan Biswas
2019-06-11 11:34           ` Dmitry Osipenko
2019-06-11 18:22             ` Bitan Biswas
2019-06-11 18:22               ` Bitan Biswas
2019-06-12 13:33               ` Dmitry Osipenko
2019-06-13 11:33                 ` Bitan Biswas
2019-06-13 11:33                   ` Bitan Biswas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560186515-30797-4-git-send-email-bbiswas@nvidia.com \
    --to=bbiswas@nvidia.com \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mkarthik@nvidia.com \
    --cc=peda@axentia.se \
    --cc=skomatineni@nvidia.com \
    --cc=smohammed@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.