From: Bitan Biswas <bbiswas@nvidia.com> To: Laxman Dewangan <ldewangan@nvidia.com>, Thierry Reding <treding@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>, linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@the-dreams.de>, Dmitry Osipenko <digetx@gmail.com> Cc: Shardar Mohammed <smohammed@nvidia.com>, Sowjanya Komatineni <skomatineni@nvidia.com>, Mantravadi Karthik <mkarthik@nvidia.com>, Bitan Biswas <bbiswas@nvidia.com> Subject: [PATCH V5 5/7] i2c: tegra: fix msleep warning Date: Tue, 11 Jun 2019 03:51:12 -0700 [thread overview] Message-ID: <1560250274-18499-5-git-send-email-bbiswas@nvidia.com> (raw) In-Reply-To: <1560250274-18499-1-git-send-email-bbiswas@nvidia.com> Fix checkpatch.pl WARNING for delay of approximately 1msec in flush i2c FIFO polling loop by using usleep_range(1000, 2000): WARNING: msleep < 20ms can sleep for up to 20ms; see ... Documentation/timers/timers-howto.txt + msleep(1); Signed-off-by: Bitan Biswas <bbiswas@nvidia.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bececa6..4dfb4c1 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -476,7 +476,7 @@ static int tegra_i2c_flush_fifos(struct tegra_i2c_dev *i2c_dev) dev_warn(i2c_dev->dev, "timeout waiting for fifo flush\n"); return -ETIMEDOUT; } - msleep(1); + usleep_range(1000, 2000); } return 0; } -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Bitan Biswas <bbiswas@nvidia.com> To: Laxman Dewangan <ldewangan@nvidia.com>, Thierry Reding <treding@nvidia.com>, Jonathan Hunter <jonathanh@nvidia.com>, <linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@the-dreams.de>, Dmitry Osipenko <digetx@gmail.com> Cc: Shardar Mohammed <smohammed@nvidia.com>, Sowjanya Komatineni <skomatineni@nvidia.com>, Mantravadi Karthik <mkarthik@nvidia.com>, "Bitan Biswas" <bbiswas@nvidia.com> Subject: [PATCH V5 5/7] i2c: tegra: fix msleep warning Date: Tue, 11 Jun 2019 03:51:12 -0700 [thread overview] Message-ID: <1560250274-18499-5-git-send-email-bbiswas@nvidia.com> (raw) In-Reply-To: <1560250274-18499-1-git-send-email-bbiswas@nvidia.com> Fix checkpatch.pl WARNING for delay of approximately 1msec in flush i2c FIFO polling loop by using usleep_range(1000, 2000): WARNING: msleep < 20ms can sleep for up to 20ms; see ... Documentation/timers/timers-howto.txt + msleep(1); Signed-off-by: Bitan Biswas <bbiswas@nvidia.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/i2c/busses/i2c-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bececa6..4dfb4c1 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -476,7 +476,7 @@ static int tegra_i2c_flush_fifos(struct tegra_i2c_dev *i2c_dev) dev_warn(i2c_dev->dev, "timeout waiting for fifo flush\n"); return -ETIMEDOUT; } - msleep(1); + usleep_range(1000, 2000); } return 0; } -- 2.7.4
next prev parent reply other threads:[~2019-06-11 10:51 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-11 10:51 [PATCH V5 1/7] i2c: tegra: clean up macros Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-11 10:51 ` [PATCH V5 2/7] i2c: tegra: remove unnecessary variable init Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-12 10:21 ` Wolfram Sang 2019-06-11 10:51 ` [PATCH V5 3/7] i2c: tegra: fix alignment and spacing violations Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-12 10:21 ` Wolfram Sang 2019-06-11 10:51 ` [PATCH V5 4/7] i2c: tegra: add spinlock definition comment Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-12 10:21 ` Wolfram Sang 2019-06-11 10:51 ` Bitan Biswas [this message] 2019-06-11 10:51 ` [PATCH V5 5/7] i2c: tegra: fix msleep warning Bitan Biswas 2019-06-12 10:21 ` Wolfram Sang 2019-06-11 10:51 ` [PATCH V5 6/7] i2c: tegra: fix PIO rx/tx residual transfer check Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-12 10:24 ` Wolfram Sang 2019-06-13 11:43 ` Bitan Biswas 2019-06-13 11:43 ` Bitan Biswas 2019-06-13 11:52 ` Laxman Dewangan 2019-06-13 11:52 ` Laxman Dewangan 2019-06-13 13:13 ` Wolfram Sang 2019-06-12 13:55 ` Dmitry Osipenko 2019-06-13 9:59 ` Bitan Biswas 2019-06-13 9:59 ` Bitan Biswas 2019-06-12 14:30 ` Dmitry Osipenko 2019-06-13 11:30 ` Bitan Biswas 2019-06-13 11:30 ` Bitan Biswas 2019-06-13 12:28 ` Dmitry Osipenko 2019-06-14 9:50 ` Bitan Biswas 2019-06-14 9:50 ` Bitan Biswas 2019-06-14 13:02 ` Dmitry Osipenko 2019-06-18 5:21 ` Bitan Biswas 2019-06-18 5:21 ` Bitan Biswas 2019-06-11 10:51 ` [PATCH V5 7/7] i2c: tegra: remove BUG, BUG_ON Bitan Biswas 2019-06-11 10:51 ` Bitan Biswas 2019-06-11 11:38 ` Dmitry Osipenko 2019-06-12 10:21 ` [PATCH V5 1/7] i2c: tegra: clean up macros Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1560250274-18499-5-git-send-email-bbiswas@nvidia.com \ --to=bbiswas@nvidia.com \ --cc=digetx@gmail.com \ --cc=jonathanh@nvidia.com \ --cc=ldewangan@nvidia.com \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mkarthik@nvidia.com \ --cc=peda@axentia.se \ --cc=skomatineni@nvidia.com \ --cc=smohammed@nvidia.com \ --cc=treding@nvidia.com \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.