All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ath11k: fix extended stats update issue
@ 2019-06-17 13:27 Karthikeyan Periyasamy
  2019-06-17 14:26 ` John Crispin
  2019-06-18 12:25 ` Kalle Valo
  0 siblings, 2 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-17 13:27 UTC (permalink / raw)
  To: ath11k; +Cc: Karthikeyan Periyasamy

user not able to see the valid tx stats. htt stats update
process get failed due to the wrong argument pass to
ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
the pdev index. so avoid the conversion logic of pdev id to pdev
index in htt stats update process.

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 1d9892e..971c437 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
 
 	len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
 	pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
-	pdev_id = DP_HW2SW_MACID(pdev_id);
 	ppdu_id = *((u32 *)data + 1);
 
 	rcu_read_lock();
-- 
1.9.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: fix extended stats update issue
  2019-06-17 13:27 [PATCH] ath11k: fix extended stats update issue Karthikeyan Periyasamy
@ 2019-06-17 14:26 ` John Crispin
  2019-06-18 12:25 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: John Crispin @ 2019-06-17 14:26 UTC (permalink / raw)
  To: Karthikeyan Periyasamy, ath11k


On 17/06/2019 15:27, Karthikeyan Periyasamy wrote:
> user not able to see the valid tx stats. htt stats update
> process get failed due to the wrong argument pass to
> ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
> the pdev index. so avoid the conversion logic of pdev id to pdev
> index in htt stats update process.
>
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>

Hi,

thanks, i just ran into this problem an hour ago :-)

     John

> ---
>   drivers/net/wireless/ath/ath11k/dp_rx.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 1d9892e..971c437 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
>   
>   	len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
>   	pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
> -	pdev_id = DP_HW2SW_MACID(pdev_id);
>   	ppdu_id = *((u32 *)data + 1);
>   
>   	rcu_read_lock();

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: fix extended stats update issue
  2019-06-17 13:27 [PATCH] ath11k: fix extended stats update issue Karthikeyan Periyasamy
  2019-06-17 14:26 ` John Crispin
@ 2019-06-18 12:25 ` Kalle Valo
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-06-18 12:25 UTC (permalink / raw)
  To: Karthikeyan Periyasamy; +Cc: ath11k

Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:

> user not able to see the valid tx stats. htt stats update
> process get failed due to the wrong argument pass to
> ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
> the pdev index. so avoid the conversion logic of pdev id to pdev
> index in htt stats update process.
> 
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

b24d6461d9cf ath11k: fix extended stats update issue

-- 
https://patchwork.kernel.org/patch/10999267/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: fix extended stats update issue
       [not found] ` <20190620134957.7A6726137D@smtp.codeaurora.org>
@ 2019-06-20 13:59   ` Karthikeyan Periyasamy
  0 siblings, 0 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-20 13:59 UTC (permalink / raw)
  To: Kalle Valo; +Cc: ath11k

On 2019-06-20 19:19, Kalle Valo wrote:
> Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:
> 
>> user not able to see the valid tx stats. htt stats update
>> process get failed due to the wrong argument pass to
>> ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
>> the pdev index. so avoid the conversion logic of pdev id to pdev
>> index in htt stats update process.
>> 
>> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> 
> This was already applied, right?

Yes, Its already applied

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath11k-bringup&id=b24d6461d9cf254e512a91ca430be59e70da0d5d


> 
> error: patch failed: drivers/net/wireless/ath/ath11k/dp_rx.c:1294
> error: drivers/net/wireless/ath/ath11k/dp_rx.c: patch does not apply
> stg import: Diff does not apply cleanly
> 
> Patch set to Rejected.

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ath11k: fix extended stats update issue
  2019-06-18  4:35 Karthikeyan Periyasamy
@ 2019-06-20 13:49 ` Kalle Valo
       [not found] ` <20190620134957.7A6726137D@smtp.codeaurora.org>
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-06-20 13:49 UTC (permalink / raw)
  To: Karthikeyan Periyasamy; +Cc: ath11k

Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:

> user not able to see the valid tx stats. htt stats update
> process get failed due to the wrong argument pass to
> ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
> the pdev index. so avoid the conversion logic of pdev id to pdev
> index in htt stats update process.
> 
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>

This was already applied, right?

error: patch failed: drivers/net/wireless/ath/ath11k/dp_rx.c:1294
error: drivers/net/wireless/ath/ath11k/dp_rx.c: patch does not apply
stg import: Diff does not apply cleanly

Patch set to Rejected.

-- 
https://patchwork.kernel.org/patch/11000877/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ath11k: fix extended stats update issue
@ 2019-06-18  4:35 Karthikeyan Periyasamy
  2019-06-20 13:49 ` Kalle Valo
       [not found] ` <20190620134957.7A6726137D@smtp.codeaurora.org>
  0 siblings, 2 replies; 6+ messages in thread
From: Karthikeyan Periyasamy @ 2019-06-18  4:35 UTC (permalink / raw)
  To: ath11k; +Cc: Karthikeyan Periyasamy

user not able to see the valid tx stats. htt stats update
process get failed due to the wrong argument pass to
ath11k_get_ar_by_pdev_id API. Expected argument is pdev_id not
the pdev index. so avoid the conversion logic of pdev id to pdev
index in htt stats update process.

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 1d9892e..971c437 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -1294,7 +1294,6 @@ static int ath11k_htt_pull_ppdu_stats(struct ath11k_base *ab,
 
 	len = FIELD_GET(HTT_T2H_PPDU_STATS_PAYLOAD_SIZE_M, *(u32 *)data);
 	pdev_id = FIELD_GET(HTT_T2H_PPDU_STATS_PDEV_ID_M, *(u32 *)data);
-	pdev_id = DP_HW2SW_MACID(pdev_id);
 	ppdu_id = *((u32 *)data + 1);
 
 	rcu_read_lock();
-- 
1.9.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-20 13:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 13:27 [PATCH] ath11k: fix extended stats update issue Karthikeyan Periyasamy
2019-06-17 14:26 ` John Crispin
2019-06-18 12:25 ` Kalle Valo
2019-06-18  4:35 Karthikeyan Periyasamy
2019-06-20 13:49 ` Kalle Valo
     [not found] ` <20190620134957.7A6726137D@smtp.codeaurora.org>
2019-06-20 13:59   ` Karthikeyan Periyasamy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.