From: <Eugen.Hristev@microchip.com> To: <hverkuil@xs4all.nl>, <linux-media@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <sakari.ailus@iki.fi> Cc: <Eugen.Hristev@microchip.com> Subject: [PATCH] media: atmel: atmel-isc: fix i386 build error Date: Wed, 19 Jun 2019 07:24:41 +0000 [thread overview] Message-ID: <1560928828-31471-1-git-send-email-eugen.hristev@microchip.com> (raw) From: Eugen Hristev <eugen.hristev@microchip.com> ld: drivers/media/platform/atmel/atmel-isc-base.o:(.bss+0x0): multiple definition of `debug'; arch/x86/entry/entry_32.o:(.entry.text+0x21ac): first defined here Changed module parameters to static. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- Hello Hans, Sorry for this, it looks like i386 has a stray weird 'debug' symbol which causes an error. I changed the module parameters of the atmel-isc to 'static' but now they cannot be accessed in the other module files. Will have to create a get function to be used in the other files if needed later. Any other way to make a symbol static to current module and not current file ? It would be useful for other config variables as well. I was not sure if you want to squash this over the faulty patch or add it as a separate patch. If you want me to squash it let me know and I will come up with a squashed new version. Thanks, Eugen drivers/media/platform/atmel/atmel-isc-base.c | 4 ++-- drivers/media/platform/atmel/atmel-isc.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index eb1f5d4..c1c776b 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -35,11 +35,11 @@ #include "atmel-isc-regs.h" #include "atmel-isc.h" -unsigned int debug; +static unsigned int debug; module_param(debug, int, 0644); MODULE_PARM_DESC(debug, "debug level (0-2)"); -unsigned int sensor_preferred = 1; +static unsigned int sensor_preferred = 1; module_param(sensor_preferred, uint, 0644); MODULE_PARM_DESC(sensor_preferred, "Sensor is preferred to output the specified format (1-on 0-off), default 1"); diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h index f5f5932..bfaed2f 100644 --- a/drivers/media/platform/atmel/atmel-isc.h +++ b/drivers/media/platform/atmel/atmel-isc.h @@ -230,10 +230,6 @@ struct isc_device { #define ATMEL_ISC_NAME "atmel-isc" -/* module parameters */ -extern unsigned int debug; -extern unsigned int sensor_preferred; - extern struct isc_format formats_list[]; extern const struct isc_format controller_formats[]; extern const u32 isc_gamma_table[GAMMA_MAX + 1][GAMMA_ENTRIES]; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: <Eugen.Hristev@microchip.com> To: <hverkuil@xs4all.nl>, <linux-media@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <sakari.ailus@iki.fi> Cc: Eugen.Hristev@microchip.com Subject: [PATCH] media: atmel: atmel-isc: fix i386 build error Date: Wed, 19 Jun 2019 07:24:41 +0000 [thread overview] Message-ID: <1560928828-31471-1-git-send-email-eugen.hristev@microchip.com> (raw) From: Eugen Hristev <eugen.hristev@microchip.com> ld: drivers/media/platform/atmel/atmel-isc-base.o:(.bss+0x0): multiple definition of `debug'; arch/x86/entry/entry_32.o:(.entry.text+0x21ac): first defined here Changed module parameters to static. Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- Hello Hans, Sorry for this, it looks like i386 has a stray weird 'debug' symbol which causes an error. I changed the module parameters of the atmel-isc to 'static' but now they cannot be accessed in the other module files. Will have to create a get function to be used in the other files if needed later. Any other way to make a symbol static to current module and not current file ? It would be useful for other config variables as well. I was not sure if you want to squash this over the faulty patch or add it as a separate patch. If you want me to squash it let me know and I will come up with a squashed new version. Thanks, Eugen drivers/media/platform/atmel/atmel-isc-base.c | 4 ++-- drivers/media/platform/atmel/atmel-isc.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index eb1f5d4..c1c776b 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -35,11 +35,11 @@ #include "atmel-isc-regs.h" #include "atmel-isc.h" -unsigned int debug; +static unsigned int debug; module_param(debug, int, 0644); MODULE_PARM_DESC(debug, "debug level (0-2)"); -unsigned int sensor_preferred = 1; +static unsigned int sensor_preferred = 1; module_param(sensor_preferred, uint, 0644); MODULE_PARM_DESC(sensor_preferred, "Sensor is preferred to output the specified format (1-on 0-off), default 1"); diff --git a/drivers/media/platform/atmel/atmel-isc.h b/drivers/media/platform/atmel/atmel-isc.h index f5f5932..bfaed2f 100644 --- a/drivers/media/platform/atmel/atmel-isc.h +++ b/drivers/media/platform/atmel/atmel-isc.h @@ -230,10 +230,6 @@ struct isc_device { #define ATMEL_ISC_NAME "atmel-isc" -/* module parameters */ -extern unsigned int debug; -extern unsigned int sensor_preferred; - extern struct isc_format formats_list[]; extern const struct isc_format controller_formats[]; extern const u32 isc_gamma_table[GAMMA_MAX + 1][GAMMA_ENTRIES]; -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-06-19 7:24 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-19 7:24 Eugen.Hristev [this message] 2019-06-19 7:24 ` [PATCH] media: atmel: atmel-isc: fix i386 build error Eugen.Hristev 2019-06-19 8:03 ` Sakari Ailus 2019-06-19 8:03 ` Sakari Ailus 2019-06-22 7:44 ` Hans Verkuil 2019-06-22 7:44 ` Hans Verkuil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1560928828-31471-1-git-send-email-eugen.hristev@microchip.com \ --to=eugen.hristev@microchip.com \ --cc=hverkuil@xs4all.nl \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.